Page MenuHomePhorge

Declare missing class properties in ArcanistDownloadWorkflow
ClosedPublic

Authored by aklapper on Jul 2 2024, 19:00.
Tags
None
Referenced Files
F4011605: D25713.1746626220.diff
Tue, May 6, 13:57
F3987863: D25713.1746586037.diff
Tue, May 6, 02:47
F3720384: D25713.1745712306.diff
Sat, Apr 26, 00:05
F3720303: D25713.1745708146.diff
Fri, Apr 25, 22:55
F3712169: D25713.1745675025.diff
Fri, Apr 25, 13:43
F3701412: D25713.1745601229.diff
Thu, Apr 24, 17:13
F3681937: D25713.1745563747.diff
Thu, Apr 24, 06:49
F3621058: D25713.1745312837.diff
Mon, Apr 21, 09:07

Details

Summary

rARCbd9769ba92df63d0429f74ec7fb8b00a4989f28b added and declared the three private properties $id, $saveAs, $show.
However rARC21e80a635d798c5be2c6e5c272497b3170c1e079 removed their declarations while still initializing these properties in didParseArguments().

Test Plan

Run PHPStan static code analysis; grep the code in this class.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable