Page MenuHomePhorge

Declare missing class properties in ArcanistDownloadWorkflow
ClosedPublic

Authored by aklapper on Jul 2 2024, 19:00.
Tags
None
Referenced Files
F2935753: D25713.1737868319.diff
Sat, Jan 25, 05:11
F2931742: D25713.1737724977.diff
Thu, Jan 23, 13:22
F2929708: D25713.1737664239.diff
Wed, Jan 22, 20:30
F2913277: D25713.1737424808.diff
Mon, Jan 20, 02:00
F2913276: D25713.1737424807.diff
Mon, Jan 20, 02:00
F2908558: D25713.1737379284.diff
Sun, Jan 19, 13:21
F2904851: D25713.1737334836.diff
Sun, Jan 19, 01:00
F2867637: D25713.1736648454.diff
Sat, Jan 11, 02:20

Details

Summary

rARCbd9769ba92df63d0429f74ec7fb8b00a4989f28b added and declared the three private properties $id, $saveAs, $show.
However rARC21e80a635d798c5be2c6e5c272497b3170c1e079 removed their declarations while still initializing these properties in didParseArguments().

Test Plan

Run PHPStan static code analysis; grep the code in this class.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable