Explicitly set "Created" as ActionName (to be used as a mail subject line vary prefix) when the transaction type is PhabricatorTransactions::TYPE_CREATE to avoid falling back to a generic "Updated" prefix.
Closes T15865
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15865: [Regression] Incorrect mail subject header [Updated] instead of [Created]
- Commits
- rP5a454cef8a98: Set ActionName to "Created" for PhabricatorTransactions::TYPE_CREATE
Either create a new task and check the mail subject line prefix (if you have a mail setup in your Phorge instance), or use the debug patch in P45 and check the order of action strengths.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
So:
- was this improving the situation? rPf4d9d6920bcd: The feed "created this task" should be the first one seems yes, accordingly to your comments
- was PhabricatorTransactions::TYPE_CREATE needing a nice action name? yes
- Am I confused about newActionStrengthSortVector? Yes. I don't know why it works, but it works. But this deserves further discussion.
Comment Actions
The change made sense but triggered this regression by introducing a non-default ActionStrength with value 140, thus changing the previous order of the PhutilSortVector defining the Vary Prefix subject.