Double-slam-accept! Thanks and happy landing

Update after comments

Yet another orphan method, it seems 🤔

Fix $Mailer default value in docs

• Between class.phpmailer-lite.php and class.phpmailer.php there were two differences in default values of variables, for $Mailer and $SingleTo:
  • I kept Lite's public $SingleTo = true as src/applications/metamta/adapter/PhabricatorMailSMTPAdapter.php (using non-Lite) already explicitly sets $smtp->SingleTo = false.
  • I kept Lite's public $Mailer = 'mail' instead of non-Lite's public $Mailer = 'sendmail' as SMTP in non-Lite already explicitly sets $Mailer = 'smtp' via calling $smtp->IsSMTP(), same for Sendmail via $mailer->IsSendmail(), and custom AmazonSES's code already explicitly sets $mailer->Mailer = 'amazon-ses' in src/applications/metamta/adapter/PhabricatorMailAmazonSESAdapter.php - so our default value sendmail does not really matter here anyway.
• The other PhabricatorMail*Adapter subclasses of PhabricatorMailAdapter do not seem to utilize PHPMailer.
• No documentation to update as https://we.phorge.it/book/phorge/article/configuring_outbound_email/ does not mention any PHPMailer.

I don't know what an "hardpoint" is.

BTW: You can use commit hash in place of branch name in URL, to set link to display specific file at the time of that commit, in this case https://github.com/unicode-org/cldr/blob/9d96f340ab145003b3e6d12d95ffb16f19a8a529/common/supplemental/windowsZones.xml. I'm not gonna update commit message, though. (so you can do it when landing? :P)

In https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php ,
getMailAction() does return $this->getStrongestAction($object, $xactions)->getActionName()
and
getStrongestAction() does return head(msortv($xactions, 'newActionStrengthSortVector'))
and
newActionStrengthSortVector() does return id(new PhutilSortVector())->addInt(-$this->getActionStrength()) (note the minus)
so I'm wondering if rPf4d9d6920bcdcafedd6a05f34c28642589b3c285 broke something while it was supposed to do the opposite (cannot remember another recent commit that feels related to this area).

I haven't looked at Phorge's internals much yet, but perhaps the user could unmark a task as duplicate, or have the "Close As Duplicate" box be prefilled with the task that closed it and let the user deselect that and choose another one?

Once we remove this, we'll need to handle this edge-case:

• I've closed a ticket as "duplicate of T1", but I was wrong and want to mark it as "duplicate of T2" instead (and say it's not a dup of T1).

lol

I was able to reproduce this on a test instance even though the task is closed long ago:

Remove unused final protected methods in PhabricatorEditorExtension

But it's designed to accept an array of futures, not a single one. Maybe just wrap in array($result).

Test plan needed. But I don't know what an "hardpoint" is.

In D25709#19636, @valerio.bozzolan wrote:

OK.

@avivey what do you think about a new silly commodity method PhabricatorTransactions::findOneByType(array, string) ?

Thanks. I'm quite sure that everything is just calling writeCache().

Please wait at least for another +1, or, a week, before landing this. Since others may have different opinions on PhabricatorTransactions::findOneByType().

Updates after comments

Updates after comments

@avivey what do you think about a new silly commodity method PhabricatorTransactions::findOneByType(array, string) ?

Partially related to T15822: When a phriction page is moved, history should follow the page move

Thanks

In D25709#19616, @valerio.bozzolan wrote:

P.S. Why does Phriction have the field text_metadata? And why does Conpherence have content_metadata? 🤔