Page MenuHomePhorge

PHPMailer: Merge class.phpmailer-lite.php into class.phpmailer.php
Open, Needs TriagePublic


As has not magically appeared right around the corner, we have a 14 year old copy of PHPMailer in the stack, added in January 2011, (with a small number of custom downstream patches on top). implies that upstream moved from Sourceforge to at some point.

I remain clueless where our "Lite" version originally came from. In upstream, the only reference I could find to a "Lite" version is the removal of some references in (I admit I did not try to dig up things in SourceForge though.)

The other three PHPMailer files (non-lite, pop3, smtp) got added in Dec 2012 to "support SMTP" in . Again, such differentiation is long gone in upstream (which had several file renames and moving stuff around too).

Our first downstream versions of lite and non-lite seem to closest resemble upstream when it comes to upstream history.

Running a diff between lite and non-lite in our downstream, I do not spot large differences hard to overcome, so we should get rid of that "lite" version to reduce long-term maintenance costs.

./phorge/src/applications/metamta/adapter/PhabricatorMailAmazonSESAdapter.php:    require_once $root.'/externals/phpmailer/class.phpmailer-lite.php';
./phorge/src/applications/metamta/adapter/PhabricatorMailSendmailAdapter.php:    require_once $root.'/externals/phpmailer/class.phpmailer-lite.php';
./phorge/src/applications/metamta/adapter/PhabricatorMailSMTPAdapter.php:    require_once $root.'/externals/phpmailer/class.phpmailer.php';