Also remove now unused private $objectPHID

Remove a needless ->setObjectPHID($object_phid) call I missed now that we pass $object

I still don't like the solution of using place-holder text for that

Thanks for the review (and for your patience!).

Updating D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy

I still don't like the solution of using place-holder text for that; But this implementation also adds another DB access which I think is redundant.

Instead of this diff, can you add a modern endpoint that uses the EditEngine/transactions? e.g. maniphest.edit, badge.edit, etc.
That will need a different name (phriction.document.edit?), but will allow full editing capability.

Thank you!

I have this look on Windows for

a {
  outline-style: auto;
}

Last Chrome	Last Firefox

This is the same as Q132: Why is there an `outline-style: none;` declaration for all links within Phorge/Phabricator?

Cleaner attempt in D25546 Diff 2113.

Allow to setEditEngine when constructing a PhabricatorApplicationTransactionCommentView

Thanks for the pointers, I really appreciate them.

Ah, thanks, makes sense now. I'd probably rephrase "but harms the authors constraint" a little bit to explicitly cover what you explained well in D25676#18549 - an author PHID in $this->responsibles might not always be a member of a project or owner of a package, so the query results were incomplete beforehand.

Ah I see below it assumes string. Thanks!

Is it possible tasks isn’t a string in this case, where non_empty_scalar might be more of a match?

seems good, ty!

Thanks. Moreover, looking at PhutilKeyValueCache it seems that setKey(null) has no sense. So thanks also for that extra care you already set.

Hi bekay, thanks for looking into this, very appreciated!

There is no reason to expose "Manage" for admins only. I'm abandoning this in favor of D25687.

I will then need a rebase for D25363

Could you clarify if this is only supposed to work for import an .ics URI and not for importing a single event via an .ics file? Maybe I'm overcomplicating things, what I tried:

I admit I am quite interested in the changes in src/applications/people/query/PhabricatorPeopleUserEmailQuery.php adding $userPhids and $isVerified as I have a downstream use case for them.
Would be lovely to get them in, nevertheless where the actual calendar feature request is going.

Use PhabricatorMarkupEngine::summarizeSentence() instead of mb_substr().

thanks you

To me it makes sense thanks. Maybe just add a comment somewhere to say that the menu should be automatically generated - T15224

So the "right" fix is to find what creates the current side-menu and make sure we call that, or figuring out why they're different here and normally the same.

So PHP, very wow