Test plan: I finished my ideas. It seems it just works 🤔
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jun 7 2024
In D25685#18805, @avivey wrote:this menu should have the same content as the side-menu on non-mobile view; And in most places, the framework handles that, by actually moving that menu.
So the "right" fix is to find what creates the current side-menu and make sure we call that, or figuring out why they're different here and normally the same.
As T15224 suggest, this menu should have the same content as the side-menu on non-mobile view; And in most places, the framework handles that, by actually moving that menu.
So the "right" fix is to find what creates the current side-menu and make sure we call that, or figuring out why they're different here and normally the same.
Better than before.
all those tears shed by devastated users after clicking the Calendar menu item
Ah, thanks.
No, it never was called anywhere. Read the HTML comment this commit deletes.
I cannot find getDateTranslations anywhere so I'm having the (probably very stupid) question where this function was called once upon a time (edit: oh well, I now realize it's a test case so I guess this just gets executed when running tests. sigh.).
Add minimal PHPDoc
Maybe a good moment for minimal PHPDoc with
I will update the screenshots. Let's wait another +1 on strings.
Tried to re-phrase a bit, thanks to feedback from Italian coworkers and Andrè. lol
... but it turns out by concidence most of the date elements that are worth translating are already translatable from other references in the code:
// The only purpose of this function is to provide a static list of // translations which can come from PhutilTranslator::translateDate() to // allow translation extractor getting them.
I seem to have a bad habit of doing things and realizing they were stupid or I had missed something weeks to months later.
Jun 6 2024
That would probably be a better User-Agent
/settings/panel/multifactor/ requires users to add a custom Name so there is likely code to adapt/reuse for /settings/panel/apitokens/
https://we.phorge.it/source/phorge/browse/master/src/applications/auth/adapter/PhutilGitHubAuthAdapter.php$57-58 uses a boring
$future->addHeader('User-Agent', __CLASS__); for this.
Use consistent CSS scopes. Tested. And really really last change for now. I think.
There may be some room for extra clarity for users in complex organization setups, but this is a rare enough operation (outside of dev) that it's probably not worth worrying about.
I would be find with turning this into "your PlatformSymbols::getPlatformServerName() account" instead if that's seen as clearer but I'm not convinced the platform is necessary here at all. Opinions on that welcome.
Jun 5 2024
Use consistent class scope; fix a typo
IMHO this is ready to review.
Avoid non-ASCII bytes in CSS by using FontAwesome
Display custom collapse/expand arrows only on mobile screens; display them after the column header name instead of before
Add PHPDoc for setCollapsible
Fix syntax
Not sure if we prefer to make isCollabsable a property of the base classes, instead of making them non-final
Yeah right, NuanceFormItemType returns an array so NuanceGitHubEventItemType should also return an empty array. Good point, thanks!
kill it
Also fix the typo in the function name
$ grep -FR 'extends PhabricatorIconSet' . ./src/applications/people/icon/PhabricatorPeopleIconSet.php: extends PhabricatorIconSet { ./src/applications/calendar/icon/PhabricatorCalendarIconSet.php: extends PhabricatorIconSet { ./src/applications/project/icon/PhabricatorProjectIconSet.php: extends PhabricatorIconSet { ./src/applications/badges/icon/PhabricatorBadgesIconSet.php: extends PhabricatorIconSet { ./src/applications/search/menuitem/PhabricatorProfileMenuItemIconSet.php: extends PhabricatorIconSet { ./src/applications/dashboard/icon/PhabricatorDashboardIconSet.php: extends PhabricatorIconSet {
Thanks. Your edit effectively reflects what already happens, but interestingly, it still may crash 🤔
@valerio.bozzolan: Y U so sirious??? :D
A bit more than Normal, since it reflects on a database with orphan elements that creates "ghosts in the UI".
Wow. With my proposal is not funny anymore. OK I will refrain myself from contributing here. But I personally like the new proposal from Andrè and @pppery. Personally approving.
I understand the points. Third proposal, starting with useful tips (good idea), and shorter: