😆

Eh, the PHP pitfalls that I'll never learn by heart... Thanks! :)
Let's try if ($file !== null && $file !== '') instead of if ($file) then?

The best way is probably to make an Extension:

• How to Write Extensions
• Phactory: Hosting Projects Here
• T15030: Support a Phorge Extensions ecosystem

Thanks for the confirmation!

git rebase master (again)

Sorry for waiting.

git rebase master

This might regress the case where file is “0”

Restore an empty line

This broken code is intended to find MailTags (means: each entry listed under http://phorge.localhost/settings/panel/emailpreferences/ , grep for const MAILTAG_ to get a list of them) defined more than once to display them in a Common section on top:

Before:

these pages should have Macro disabled, probably. A user on the install can add more macros that would break the page in some other ways. Probably.

(↑ isn't this lovely? lol)

This is a low quality image that could be used by "fair use" as meme. Source:

Double-slam-accept! Thanks and happy landing

Update after comments

Yet another orphan method, it seems 🤔

Fix $Mailer default value in docs

• Between class.phpmailer-lite.php and class.phpmailer.php there were two differences in default values of variables, for $Mailer and $SingleTo:
  • I kept Lite's public $SingleTo = true as src/applications/metamta/adapter/PhabricatorMailSMTPAdapter.php (using non-Lite) already explicitly sets $smtp->SingleTo = false.
  • I kept Lite's public $Mailer = 'mail' instead of non-Lite's public $Mailer = 'sendmail' as SMTP in non-Lite already explicitly sets $Mailer = 'smtp' via calling $smtp->IsSMTP(), same for Sendmail via $mailer->IsSendmail(), and custom AmazonSES's code already explicitly sets $mailer->Mailer = 'amazon-ses' in src/applications/metamta/adapter/PhabricatorMailAmazonSESAdapter.php - so our default value sendmail does not really matter here anyway.
• The other PhabricatorMail*Adapter subclasses of PhabricatorMailAdapter do not seem to utilize PHPMailer.
• No documentation to update as https://we.phorge.it/book/phorge/article/configuring_outbound_email/ does not mention any PHPMailer.

I don't know what an "hardpoint" is.

BTW: You can use commit hash in place of branch name in URL, to set link to display specific file at the time of that commit, in this case https://github.com/unicode-org/cldr/blob/9d96f340ab145003b3e6d12d95ffb16f19a8a529/common/supplemental/windowsZones.xml. I'm not gonna update commit message, though. (so you can do it when landing? :P)

In https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php ,
getMailAction() does return $this->getStrongestAction($object, $xactions)->getActionName()
and
getStrongestAction() does return head(msortv($xactions, 'newActionStrengthSortVector'))
and
newActionStrengthSortVector() does return id(new PhutilSortVector())->addInt(-$this->getActionStrength()) (note the minus)
so I'm wondering if rPf4d9d6920bcdcafedd6a05f34c28642589b3c285 broke something while it was supposed to do the opposite (cannot remember another recent commit that feels related to this area).