To avoid that $xactions[0] we should probably find the desired transaction.

LC_ALL=C is not risky on GNU systems.

Sigh, xdebug... and seems I need to drop the new from the constructor when the class is final.

Thanks my friend, this works perfectly

we can remove an undeclared variable, and add a nonempty-str check

dedicating Conpherence its own diff as mturdus requested

(BTW, in D25698 we started deprecating remarkup.diviner for RemarkupReferenceController)

I think GitHub allows that syntax only in comments 🤔

removing from review queue until the underlying task discussion is settled.

In T15744#18236, @20after4 wrote:

I was unaware of `#0969DA` syntax from github/gitlab.

I was unaware of #0969DA syntax from github/gitlab. I'm not sure if I like that syntax better than {} but I am generally in favor of using the same syntax as other systems in order to converge towards defacto standardization.

OK try this to restore your desired situation (so, two diffs)

OK, I think we have something mathematical and bombproof

In D25705#19485, @valerio.bozzolan wrote:

(Do you need a little help to split the changes in two diffs?)

Updates after comments

https://unix.stackexchange.com/a/87763 is also a useful reference, specifically:

add even more useful links

I must read this:

Papa Beaver's Storytime done. Thanks

Well, to be honest, feel free to generalize the description and commit message to include both changes, since they are the very same thing

(Do you need a little help to split the changes in two diffs?)

Fix file attachment in Conpherence

Per https://caniuse.com/?search=-webkit-transform, transform without a vendor prefix has been supported since Chrome 36 in 2014.
Personally I'd prefer to simply remove old vendor prefixed CSS definitions but that would first require a shared understanding which dates (and/or which browser versions) are "too old" for Phorge code.
See "List of changes, most recent first" on https://www.mediawiki.org/wiki/Compatibility#Browser_support_matrix for a random example.

Thanks again. I've found this interesting, so, added in the code itself:

improvement thanks to dear @l2dy

Update after comments

Updates after comments

Thanks again @20after4 for the efforts.

This documentation is nice but unfortunately the feature introduced in 4d12d014fd9d never worked :( So documenting this as-is may create confusion, at the moment. Next steps:

Updates after comments

Wow 😍 looks promising (untested from my side)

A day later this turns out to be a rather stupid patch. Things should remain as is as javascript:void(0) nowadays may trigger CSP errors.

what will this do?

Also run ./bin/celerity map because it's JS

@Wikivu: Why?

are a bit esoteric

it works indeed for editing Maniphest tasks but not for Phriction documents.
I have been analyzing this "attach code" but it's too complex for me.
It seems that the content_metadata (with the attachedFilePHIDs) is correctly sent by the javascript, but it's not processed in the PHP, which makes it not attach the file object to the wiki page.

About the cursor: pointer;, yep it would be super-nice, but no need to create distinctions between mobile and desktop for that probably 🤔 let's always show it.

Premising that as web developer I'm really super surprised to have never seen in my life a native <summary> + <detail>, even in demos 🤔 I've never seen it in basic online courses for beginners ( https://www.w3schools.com/howto/howto_js_collapsible.asp ) - and that's surprising since there it would be nice; not in online forums with super-basic "spoiler" features (e.g. https://www.minecraftforum.net/forums/forums/forum-discussion-info/514283-how-do-i-make-spoilers-on-the-forum ) and there it would be nice, not in Bootstrap and not in MaterializeCSS (and it would be nice to have examples there to save some JavaScript); not in MediaWiki (because there, "esoteric" tags are disabled; so, since the beginning, every single wiki in the planet has 10 lines of JavaScript in their Common.js), etc.

we should probably toggle visibility by JavaScript

(About my "like Wikipedia" I mean https://en.wikipedia.org/wiki/Template:Hidden )

To have this a bit more flexible we should probably toggle visibility by JavaScript. (So, we can keep divs, and this makes the change also a bit more backward compatible probably)

In D25672#19381, @valerio.bozzolan wrote:

I love this collapsible on mobile since it saves a lot of scrolls, but I think the collapsible on desktop can just add confusion without clear benefits (since the desktop layout is not vertical, and saving vertical space does not help in showing more information). Probably this should only apply on .device-tablet and .device-phone, but not .device-desktop

I do not understand if we have some race conditions, or, if the __destruct() is not properly called because of a bug in PHP 8.3.8, which is possible but unlikely

I've seen this occasionally when trying to log in via a /bin/auth recover link with same stacktrace as above, PHP 8.3.8 on a Fedora 40 machine:

Visually marking this as "ongoing discussion for code changes" to keep historically nice error messages

I love this collapsible on mobile since it saves a lot of scrolls, but I think the collapsible on desktop can just add confusion without clear benefits (since the desktop layout is not vertical, and saving vertical space does not help in showing more information). Probably this should only apply on .device-tablet and .device-phone, but not .device-desktop

It makes sense since these are Phorge stuff, not Arcanist stuff. Thanks.