Agree with your considerations and tested 🌈

I'm assuming you're talking about dropping a file in the text area when editing the page, right? Not just dropping it when viewing a wiki page?

Presumably resolved by D25134.

Maybe in the future. At the moment it's just an extra unnecessary configuration.

I see you marked this question as Resolved. Was it?

It seems that the function PHUIDiffTableOfContentsItemView.php::render() is not called anymore as rPf21f1d8ab9e909b3e2c4dc07af7a358a8336902c removed $rows[] = $item->render();. I cannot spot another direct render() call anywhere else in the files instantiating a PHUIDiffTableOfContentsItemView.
However, PHUIDiffTableOfContentsItemView must define render() as it's defined as an abstract method in parent AphrontView.
After emptying render(), renderChangesetMetadata() does not have any other callers either, thus also removing it.

In D25658#19351, @avivey wrote:

grep for PHUIDiffTableOfContentsItemView in the codebase to see where we might be using this class.

❤️

somewhere before the this

maybe just add if ($value === null) { continue; } somewhere before the this?

grep for PHUIDiffTableOfContentsItemView in the codebase to see where we might be using this class.

If we can't find the problem, that probably means we have some dead code here that should be removed.

The called method renderChangesetLink() is not defined anywhere so static code analysis complains.
UI-wise I could not spot anything obviously broken in the "Paths" sidebar under ToC for a merged commit, though.

Is there something that's not working here?

:shrug:

click

(re-opening, there's more work left here)

Confirming this works as expected - thanks!

Congrats to this patch.

I love this at unbelievable level, thanks all 🌈

Looks like installing php-xdebug forces me to set 'xdebug.mode' to 'coverage' in 'php.ini' to pass arc unit, no matter what...

Move CDN check from generic AphrontResponse to more correct AphrontHTMLResponse.

probably need to escape the URI

Make the Remarkup Help Page Extensible

After 15 minutes of reading stuff around on the web, I think we need a little help. Waiting for answers (and waiting for downvotes lol).

Do we still need the auto-complete feature? In modern times, the OS has the "insert emoji" feature built-in (at least, Windows and Android and KDE do).

Make the Remarkup Help Page Extensible

Make the Remarkup Help Page Extensible

Ok, this looks much better then what we have today, so yay.

I did not add a real index page.
The remarkup reference acts a bit as index page as cowsay and figlet references are referenced in here as hyperlinks.

The diff below suppresses the error (and checks like trying to "Sign With MFA" without another action should fail etc still work) but no idea about potential side effects as isPreviewRequest() is called in numerous places.