:shrug:

click

(re-opening, there's more work left here)

Confirming this works as expected - thanks!

Congrats to this patch.

I love this at unbelievable level, thanks all 🌈

Looks like installing php-xdebug forces me to set 'xdebug.mode' to 'coverage' in 'php.ini' to pass arc unit, no matter what...

Move CDN check from generic AphrontResponse to more correct AphrontHTMLResponse.

probably need to escape the URI

Make the Remarkup Help Page Extensible

After 15 minutes of reading stuff around on the web, I think we need a little help. Waiting for answers (and waiting for downvotes lol).

Do we still need the auto-complete feature? In modern times, the OS has the "insert emoji" feature built-in (at least, Windows and Android and KDE do).

Make the Remarkup Help Page Extensible

Make the Remarkup Help Page Extensible

Could be related to https://we.phorge.it/T15036. A short automated email containing a link to another domain is suspicious in the eyes of a spam filter.

Ok, this looks much better then what we have today, so yay.

I did not add a real index page.
The remarkup reference acts a bit as index page as cowsay and figlet references are referenced in here as hyperlinks.

The diff below suppresses the error (and checks like trying to "Sign With MFA" without another action should fail etc still work) but no idea about potential side effects as isPreviewRequest() is called in numerous places.

Looks good! I want to play with it locally before accepting.

Make the Remarkup Help Page Extensible

Make the Remarkup Help Page Extensible

It also collected lots of commits, since May 2023.

I don't understand what happened here?
I only had these files changed/added:

• src/applications/reference/src/application/ReferenceApplication.php
• src/applications/reference/src/controller/CowayReferenceController.php
• src/applications/reference/src/controller/FigletReferenceController.php
• src/applications/reference/src/controller/ReferenceController.php
• src/applications/reference/src/controller/RemarkupReferenceController.php
• src/infrastructure/markup/interface/RemarkupSyntaxDocumentationProvider.php
• src/infrastructure/markup/interpreter/PhabricatorRemarkupCowsayBlockInterpreter.php
• src/infrastructure/markup/interpreter/PhabricatorRemarkupFigletBlockInterpreter.php
• src/view/form/control/PhabricatorRemarkupControl.php

ty

This might (or should be) covered by the unit tests

Feel free to kill this method violently 🗡 since as you said this is protected (no external usages) + final (no overrides) and visibly broken since 5 years

Partially related, it's damn easy to type a dagger "🗡" since it appears by typing :D ... lol

@valerio.bozzolan Any thoughts/opinion regarding my last comment? :) TIA

In D25697#19176, @20after4 wrote:

I obviously failed to run ./bin/celerity map one more time before running arc diff.

There should really be some way to detect and prevent that mistake. It's one I've made probably 100 times before.

I obviously failed to run ./bin/celerity map one more time before running arc diff.

Sigh I screwed up (again) by not running ./bin/celerity map one more time. :( Followup in D25697

Meh, after removing the value from the "Page Size" field on phorge.localhost/maniphest/query/advanced/, field entry will incorrectly display "0" but list 100 results. Need to find out how to keep the value displayed/reset after manually removing it to avoid PHP converting an empty integer to a 0.

Make Celerity happy (I hope)