Page MenuHomePhorge
Feed Advanced Search

Jun 19 2023

aklapper committed rP324470e39b0d: Give embedded image files with transparency a checkered background.
Give embedded image files with transparency a checkered background
Jun 19 2023, 09:57
aklapper updated the diff for D25294: Give embedded image files with transparency a checkered background.

rebase

Jun 19 2023, 09:55

Jun 17 2023

aklapper added a comment to T15470: Include user email address in Conduit output when query is run by admin.

The sysop sees the email addresses of recipients already anyway by running an SQL query in the database if they operate the system anyway.
Running SQL queries is what I've been doing so far and it's cumbersome. Thus my request to allow this on an API level.
(I don't mind how MediaWiki behaves as that software covers different use cases.)

Jun 17 2023, 11:19 · Conduit, Discussion Needed, Feature Requests

Jun 16 2023

aklapper renamed T15483: EditEngine: allow to Duplicate a Form from EditEngine: allo to Duplicate a Form to EditEngine: allow to Duplicate a Form.
Jun 16 2023, 16:18 · Affects-Wikimedia
valerio.bozzolan awarded T15473: Give embedded image files with transparency (alpha channel) a checkered background a Love token.
Jun 16 2023, 15:19
aklapper closed T15480: Add serious business string for defrocking a user as Resolved by committing rP478012cd463d: Add serious business string for defrocking a user (remove admin rights).
Jun 16 2023, 11:58
aklapper closed D25298: Add serious business string for defrocking a user (remove admin rights).
Jun 16 2023, 11:58
aklapper committed rP478012cd463d: Add serious business string for defrocking a user (remove admin rights).
Add serious business string for defrocking a user (remove admin rights)
Jun 16 2023, 11:58

Jun 15 2023

aklapper added a comment to T15480: Add serious business string for defrocking a user.

Just for my curiosity, is serious business mode enabled in Wikimedia?

Yes, because I'd like to allow people to understand what is going on. Not everybody speaks perfectly "omg that's so phunny" English. "Set Sail for Adventure", really?

Jun 15 2023, 22:49
valerio.bozzolan awarded T15480: Add serious business string for defrocking a user a Pterodactyl token.
Jun 15 2023, 19:33
aklapper updated the summary of D25298: Add serious business string for defrocking a user (remove admin rights).
Jun 15 2023, 19:25
aklapper requested review of D25298: Add serious business string for defrocking a user (remove admin rights).
Jun 15 2023, 19:22
aklapper added a revision to T15480: Add serious business string for defrocking a user: D25298: Add serious business string for defrocking a user (remove admin rights).
Jun 15 2023, 19:22
aklapper created T15480: Add serious business string for defrocking a user.
Jun 15 2023, 19:20
aklapper closed T15479: Update "Google" icon on Phorge OAuth as Resolved by committing rPc300f0e87416: Update Google icon on Auth Provider page.
Jun 15 2023, 10:37
aklapper closed D25297: Update Google icon on Auth Provider page.
Jun 15 2023, 10:37
aklapper committed rPc300f0e87416: Update Google icon on Auth Provider page.
Update Google icon on Auth Provider page
Jun 15 2023, 10:37
aklapper requested review of D25297: Update Google icon on Auth Provider page.
Jun 15 2023, 10:10
aklapper added a revision to T15479: Update "Google" icon on Phorge OAuth: D25297: Update Google icon on Auth Provider page.
Jun 15 2023, 10:10
aklapper created T15479: Update "Google" icon on Phorge OAuth.
Jun 15 2023, 10:10
aklapper closed T15403: Fix "Amazon" icon on Phorge OAuth as Resolved by committing rP8e6bb9b6903c: Correct Phorge icon on Auth Provider page.
Jun 15 2023, 10:02 · Phorge
aklapper closed D25255: Correct Phorge icon on Auth Provider page.
Jun 15 2023, 10:02
aklapper committed rP8e6bb9b6903c: Correct Phorge icon on Auth Provider page.
Correct Phorge icon on Auth Provider page
Jun 15 2023, 10:02
aklapper updated the diff for D25255: Correct Phorge icon on Auth Provider page.

Thanks! Used PNG images from T15478; then ran ./bin/celerity sprites (which replaced ./scripts/celerity/generate_sprites.php)

Jun 15 2023, 08:35

Jun 14 2023

aklapper updated the task description for T15476: PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo.
Jun 14 2023, 20:14 · Diffusion, PHP 8 support
aklapper added a comment to T15477: Event names in Calendar monthly view can become unreadable, lack tooltips.

Posted a diff in P15 which works for me - independent of the day|month|list view, make the existing tooltips also display the event title.

Jun 14 2023, 20:05
aklapper created P15 T15477.
Jun 14 2023, 20:04
aklapper created T15477: Event names in Calendar monthly view can become unreadable, lack tooltips.
Jun 14 2023, 20:04
aklapper requested review of D25296: Fix PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo.
Jun 14 2023, 19:31
aklapper added a revision to T15476: PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo: D25296: Fix PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo.
Jun 14 2023, 19:31 · Diffusion, PHP 8 support
aklapper created T15476: PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo.
Jun 14 2023, 19:26 · Diffusion, PHP 8 support
aklapper requested review of D25295: Fix PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after setting maintenance mode.
Jun 14 2023, 19:21
aklapper added a revision to T15475: PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after setting maintenance mode: D25295: Fix PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after setting maintenance mode.
Jun 14 2023, 19:21 · Differential, PHP 8 support
aklapper created T15475: PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after setting maintenance mode.
Jun 14 2023, 19:20 · Differential, PHP 8 support
aklapper requested review of D25294: Give embedded image files with transparency a checkered background.
Jun 14 2023, 18:44
aklapper created T15473: Give embedded image files with transparency (alpha channel) a checkered background.
Jun 14 2023, 18:39
aklapper added a comment to D25249: Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding.

The use of error_get_last() in this very code has been unhelpful and misleading to me as it led to displaying messages entirely unrelated to invalid encodings (e.g. about libxml_disable_entity_loader having been deprecated).

Jun 14 2023, 02:28

Jun 13 2023

aklapper added a comment to T15408: PHP 8.1 "json_decode(null)" exception blocks creating Almanac Hosts blueprint in Drydock.

For the records, the part in src/applications/passphrase/view/PassphraseCredentialControl.php is also triggered when setting a URI for a Diffusion repository and then trying to "Set Credential" via /diffusion/1/uri/credential/123/edit/. Should probably split that out into a separate task and patch to make progress.

Jun 13 2023, 13:36 · Almanac/Drydock/Harbormaster, PHP 8 support
aklapper created T15470: Include user email address in Conduit output when query is run by admin.
Jun 13 2023, 13:33 · Conduit, Discussion Needed, Feature Requests
aklapper created P14 Include email address in Conduit's user.query output when run by admin.
Jun 13 2023, 13:32
aklapper closed T15469: PHP 8.1 "strlen(null)" exception calling Conduit's user.whoami, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 13 2023, 05:31 · PHP 8 support
aklapper closed T15469: PHP 8.1 "strlen(null)" exception calling Conduit's user.whoami as Resolved by committing rP1c098c273d06: Fix PHP 8.1 "strlen(null)" exception calling Conduit's user.whoami.
Jun 13 2023, 05:31 · PHP 8 support
aklapper closed D25292: Fix PHP 8.1 "strlen(null)" exception calling Conduit's user.whoami.
Jun 13 2023, 05:31
aklapper committed rP1c098c273d06: Fix PHP 8.1 "strlen(null)" exception calling Conduit's user.whoami.
Fix PHP 8.1 "strlen(null)" exception calling Conduit's user.whoami
Jun 13 2023, 05:31
aklapper requested review of D25292: Fix PHP 8.1 "strlen(null)" exception calling Conduit's user.whoami.
Jun 13 2023, 00:26
aklapper added a revision to T15469: PHP 8.1 "strlen(null)" exception calling Conduit's user.whoami: D25292: Fix PHP 8.1 "strlen(null)" exception calling Conduit's user.whoami.
Jun 13 2023, 00:26 · PHP 8 support
aklapper created T15469: PHP 8.1 "strlen(null)" exception calling Conduit's user.whoami.
Jun 13 2023, 00:25 · PHP 8 support

Jun 12 2023

valerio.bozzolan awarded T15343: Herald Transcript of old Tasks: Unhandled Exception: Call to a member function getAppliedTransactionPHIDs() on bool a Love token.
Jun 12 2023, 20:31 · Bug Reports, Affects-Wikimedia, Herald
aklapper closed T15461: PHP 8.1 "strlen(null)" exception when Diffusion repository has no tags, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 12 2023, 19:50 · PHP 8 support
aklapper closed T15461: PHP 8.1 "strlen(null)" exception when Diffusion repository has no tags as Resolved by committing rP7bbd657c19c4: Fix PHP 8.1 "strlen(null)" exception when Diffusion repository has no tags.
Jun 12 2023, 19:50 · PHP 8 support
aklapper closed D25285: Fix PHP 8.1 "strlen(null)" exception when Diffusion repository has no tags.
Jun 12 2023, 19:50
aklapper committed rP7bbd657c19c4: Fix PHP 8.1 "strlen(null)" exception when Diffusion repository has no tags.
Fix PHP 8.1 "strlen(null)" exception when Diffusion repository has no tags
Jun 12 2023, 19:50
aklapper closed T15343: Herald Transcript of old Tasks: Unhandled Exception: Call to a member function getAppliedTransactionPHIDs() on bool as Resolved by committing rP54ee51d7abd0: Work around exception in Herald transcript of old tasks: Call to a member….
Jun 12 2023, 19:49 · Bug Reports, Affects-Wikimedia, Herald
aklapper closed D25246: Work around exception in Herald transcript of old tasks: Call to a member function getAppliedTransactionPHIDs() on bool.
Jun 12 2023, 19:49
aklapper committed rP54ee51d7abd0: Work around exception in Herald transcript of old tasks: Call to a member….
Work around exception in Herald transcript of old tasks: Call to a member…
Jun 12 2023, 19:49
aklapper added a comment to T15343: Herald Transcript of old Tasks: Unhandled Exception: Call to a member function getAppliedTransactionPHIDs() on bool.

@valerio.bozzolan Thanks a lot for your help, debugging, deeper investigation! Resolving.

Jun 12 2023, 19:49 · Bug Reports, Affects-Wikimedia, Herald
aklapper closed T15465: PHP 8.1 "strlen(null)" exception on Diffusion repository History page after setting Callsign, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 12 2023, 19:47 · PHP 8 support
aklapper closed T15465: PHP 8.1 "strlen(null)" exception on Diffusion repository History page after setting Callsign as Resolved by committing rP3f8846d80c53: Fix PHP 8.1 "strlen(null)" exception on Diffusion repository History page after….
Jun 12 2023, 19:47 · PHP 8 support
aklapper closed D25289: Fix PHP 8.1 "strlen(null)" exception on Diffusion repository History page after setting Callsign.
Jun 12 2023, 19:47
aklapper committed rP3f8846d80c53: Fix PHP 8.1 "strlen(null)" exception on Diffusion repository History page after….
Fix PHP 8.1 "strlen(null)" exception on Diffusion repository History page after…
Jun 12 2023, 19:47
aklapper added inline comments to D25285: Fix PHP 8.1 "strlen(null)" exception when Diffusion repository has no tags.
Jun 12 2023, 15:44
aklapper updated the diff for D25246: Work around exception in Herald transcript of old tasks: Call to a member function getAppliedTransactionPHIDs() on bool.

Fix underlying root cause (after investigation of valerio.bozzolan)

Jun 12 2023, 15:35
aklapper closed T15454: Some icons not displayed on UIExamples' "Icons and Images" (PHUIIconExample) page as Resolved by committing rP1060736e895b: Fix some icons not displayed on UIExamples' "Icons and Images"….
Jun 12 2023, 15:29
aklapper closed D25280: Fix some icons not displayed on UIExamples' "Icons and Images" (PHUIIconExample) page.
Jun 12 2023, 15:29
aklapper committed rP1060736e895b: Fix some icons not displayed on UIExamples' "Icons and Images"….
Fix some icons not displayed on UIExamples' "Icons and Images"…
Jun 12 2023, 15:29
aklapper added a comment to D25289: Fix PHP 8.1 "strlen(null)" exception on Diffusion repository History page after setting Callsign.
In D25289#8438, @speck wrote:

Do you think this also requires the strlen() check?

Jun 12 2023, 15:00
aklapper closed T15466: PHP 8.1 "strlen(null)" exception blocks rendering commit page in Diffusion, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 12 2023, 09:21 · PHP 8 support
aklapper closed D25290: Fix PHP 8.1 "strlen(null)" exception which blocks rendering commit page in Diffusion.
Jun 12 2023, 09:21
aklapper closed T15466: PHP 8.1 "strlen(null)" exception blocks rendering commit page in Diffusion as Resolved by committing rPefbb809d420f: Fix PHP 8.1 "strlen(null)" exception which blocks rendering commit page in….
Jun 12 2023, 09:21 · PHP 8 support
aklapper committed rPefbb809d420f: Fix PHP 8.1 "strlen(null)" exception which blocks rendering commit page in….
Fix PHP 8.1 "strlen(null)" exception which blocks rendering commit page in…
Jun 12 2023, 09:21
aklapper merged T15439: AphrontQueryException creating a Diffusion Identity without entering assignee into T15453: Diffusion: Create Identity form is incomplete.
Jun 12 2023, 02:06 · Bug Reports, Diffusion
aklapper merged task T15439: AphrontQueryException creating a Diffusion Identity without entering assignee into T15453: Diffusion: Create Identity form is incomplete.
Jun 12 2023, 02:06
aklapper updated the diff for D25290: Fix PHP 8.1 "strlen(null)" exception which blocks rendering commit page in Diffusion.

Also add check for $has_callsign

Jun 12 2023, 01:55
aklapper added inline comments to D25290: Fix PHP 8.1 "strlen(null)" exception which blocks rendering commit page in Diffusion.
Jun 12 2023, 01:52
aklapper closed T15462: PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository code, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 12 2023, 01:50 · PHP 8 support
aklapper closed T15462: PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository code as Resolved by committing rP32b2d3871f72: Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository code.
Jun 12 2023, 01:50 · PHP 8 support
aklapper closed D25286: Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository code.
Jun 12 2023, 01:50
aklapper committed rP32b2d3871f72: Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository code.
Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository code
Jun 12 2023, 01:50
aklapper closed D25284: Fix PHP 8.1 "strlen(null)" exceptions on History page of Diffusion repo after changing text encoding.
Jun 12 2023, 01:49
aklapper closed T15460: PHP 8.1 "strlen(null)" exceptions on History page of Diffusion repo after changing text encoding, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 12 2023, 01:49 · PHP 8 support
aklapper closed T15460: PHP 8.1 "strlen(null)" exceptions on History page of Diffusion repo after changing text encoding as Resolved by committing rPdb19b23dce9a: Fix PHP 8.1 "strlen(null)" exceptions on History page of Diffusion repo after….
Jun 12 2023, 01:49 · PHP 8 support
aklapper committed rPdb19b23dce9a: Fix PHP 8.1 "strlen(null)" exceptions on History page of Diffusion repo after….
Fix PHP 8.1 "strlen(null)" exceptions on History page of Diffusion repo after…
Jun 12 2023, 01:49
aklapper updated the diff for D25289: Fix PHP 8.1 "strlen(null)" exception on Diffusion repository History page after setting Callsign.

Use null checks instead of phutil_nonempty_string

Jun 12 2023, 01:48
aklapper updated the diff for D25284: Fix PHP 8.1 "strlen(null)" exceptions on History page of Diffusion repo after changing text encoding.

Use null checks instead of phutil_nonempty_string

Jun 12 2023, 01:45
aklapper updated the diff for D25286: Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository code.

Use phutil_nonempty_string instead as requested

Jun 12 2023, 01:42
aklapper closed T15464: PHP 8.1 "strlen(null)" exception rendering a commit in Diffusion when bugtraq.url = null, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 12 2023, 01:37 · PHP 8 support
aklapper closed D25288: Fix PHP 8.1 "strlen(null)" exception rendering a commit in Diffusion when bugtraq.url = null.
Jun 12 2023, 01:37
aklapper closed T15464: PHP 8.1 "strlen(null)" exception rendering a commit in Diffusion when bugtraq.url = null as Resolved by committing rP331b9cca4260: Fix PHP 8.1 "strlen(null)" exception rendering a commit in Diffusion when….
Jun 12 2023, 01:37 · PHP 8 support
aklapper committed rP331b9cca4260: Fix PHP 8.1 "strlen(null)" exception rendering a commit in Diffusion when….
Fix PHP 8.1 "strlen(null)" exception rendering a commit in Diffusion when…
Jun 12 2023, 01:37
aklapper requested review of D25290: Fix PHP 8.1 "strlen(null)" exception which blocks rendering commit page in Diffusion.
Jun 12 2023, 01:35
aklapper added a revision to T15466: PHP 8.1 "strlen(null)" exception blocks rendering commit page in Diffusion: D25290: Fix PHP 8.1 "strlen(null)" exception which blocks rendering commit page in Diffusion.
Jun 12 2023, 01:35 · PHP 8 support
aklapper created T15466: PHP 8.1 "strlen(null)" exception blocks rendering commit page in Diffusion.
Jun 12 2023, 01:33 · PHP 8 support
aklapper requested review of D25289: Fix PHP 8.1 "strlen(null)" exception on Diffusion repository History page after setting Callsign.
Jun 12 2023, 01:23
aklapper added a revision to T15465: PHP 8.1 "strlen(null)" exception on Diffusion repository History page after setting Callsign: D25289: Fix PHP 8.1 "strlen(null)" exception on Diffusion repository History page after setting Callsign.
Jun 12 2023, 01:23 · PHP 8 support
aklapper created T15465: PHP 8.1 "strlen(null)" exception on Diffusion repository History page after setting Callsign.
Jun 12 2023, 01:22 · PHP 8 support
aklapper requested review of D25288: Fix PHP 8.1 "strlen(null)" exception rendering a commit in Diffusion when bugtraq.url = null.
Jun 12 2023, 01:12
aklapper added a revision to T15464: PHP 8.1 "strlen(null)" exception rendering a commit in Diffusion when bugtraq.url = null: D25288: Fix PHP 8.1 "strlen(null)" exception rendering a commit in Diffusion when bugtraq.url = null.
Jun 12 2023, 01:12 · PHP 8 support
aklapper created T15464: PHP 8.1 "strlen(null)" exception rendering a commit in Diffusion when bugtraq.url = null.
Jun 12 2023, 01:11 · PHP 8 support
aklapper added inline comments to D25286: Fix PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository code.
Jun 12 2023, 00:56
aklapper closed T15463: PHP 8.1 "strlen(null)" exceptions trying to browse Diffusion repository history, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 12 2023, 00:51 · PHP 8 support