Paths

Table of Contentst

Fix some icons not displayed on UIExamples' "Icons and Images" (PHUIIconExample) page
ClosedPublic
Actions

Authored by aklapper on Jun 8 2023, 14:51.

Tags

None

Referenced Files

	F3318241: D25280.1743276667.diff
	Fri, Mar 28, 19:31

	F3315739: D25280.1743243542.diff
	Fri, Mar 28, 10:19

	F3304025: D25280.1743090677.diff
	Wed, Mar 26, 15:51

	F3293803: D25280.1742922826.diff
	Mon, Mar 24, 17:13

	F3289040: D25280.1742839855.diff
	Sun, Mar 23, 18:10

	F3280112: D25280.1742642825.diff
	Fri, Mar 21, 11:27

	F3250583: D25280.1742305604.diff
	Mon, Mar 17, 13:46

	F3223440: D25280.1741951535.diff
	Thu, Mar 13, 11:25

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15454: Some icons not displayed on UIExamples' "Icons and Images" (PHUIIconExample) page

Commits

rP1060736e895b: Fix some icons not displayed on UIExamples' "Icons and Images"…

Summary

Fix three typos in icon names

Closes T15454

Test Plan

Go to /uiexample/view/PHUIIconExample/ before and after applying the change; compare icons displayed for fa-codiepie, fa-user-o, fa-thermometer-0

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Jun 8 2023, 14:51

Owners added a reviewer: O1: Blessed Committers.Jun 8 2023, 14:51

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJun 8 2023, 14:51

aklapper requested review of this revision.Jun 8 2023, 14:51

Harbormaster completed remote builds in B521: Diff 907.Jun 8 2023, 14:51

This is beautiful :D Thanks

lgtm

This revision is now accepted and ready to land.Jun 12 2023, 15:07

What the hell is "codiepie holistic coding" ihih

Closed by commit rP1060736e895b: Fix some icons not displayed on UIExamples' "Icons and Images"…. · Explain WhyJun 12 2023, 15:29

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP1060736e895b: Fix some icons not displayed on UIExamples' "Icons and Images"….

Revision Contents
Changeset List

Path

Size

Packages

src/

view/

phui/

PHUIIconView.php

6 lines

O1: Blessed Committers

Diff 952

View Options

src/view/phui/PHUIIconView.php

Fix some icons not displayed on UIExamples' "Icons and Images" (PHUIIconExample) pageClosedPublicActions