Paths

Table of Contentst

Fix some icons not displayed on UIExamples' "Icons and Images" (PHUIIconExample) page
ClosedPublic
Actions

Authored by aklapper on Jun 8 2023, 14:51.

Tags

None

Referenced Files

	F2962461: D25280.1739179827.diff
	Sun, Feb 9, 09:30

	F2944262: D25280.1738259497.diff
	Wed, Jan 29, 17:51

	F2932295: D25280.1737732137.diff
	Thu, Jan 23, 15:22

	F2932294: D25280.1737732130.diff
	Thu, Jan 23, 15:22

	F2932293: D25280.1737732123.diff
	Thu, Jan 23, 15:22

	F2931775: D25280.1737725680.diff
	Thu, Jan 23, 13:34

	F2929251: D25280.1737654633.diff
	Jan 22 2025, 17:50

	F2929221: D25280.1737654625.diff
	Jan 22 2025, 17:50

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15454: Some icons not displayed on UIExamples' "Icons and Images" (PHUIIconExample) page

Commits

rP1060736e895b: Fix some icons not displayed on UIExamples' "Icons and Images"…

Summary

Fix three typos in icon names

Closes T15454

Test Plan

Go to /uiexample/view/PHUIIconExample/ before and after applying the change; compare icons displayed for fa-codiepie, fa-user-o, fa-thermometer-0

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Jun 8 2023, 14:51

Owners added a reviewer: O1: Blessed Committers.Jun 8 2023, 14:51

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJun 8 2023, 14:51

aklapper requested review of this revision.Jun 8 2023, 14:51

Harbormaster completed remote builds in B521: Diff 907.Jun 8 2023, 14:51

This is beautiful :D Thanks

lgtm

This revision is now accepted and ready to land.Jun 12 2023, 15:07

What the hell is "codiepie holistic coding" ihih

Closed by commit rP1060736e895b: Fix some icons not displayed on UIExamples' "Icons and Images"…. · Explain WhyJun 12 2023, 15:29

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP1060736e895b: Fix some icons not displayed on UIExamples' "Icons and Images"….

Revision Contents
Changeset List

Path

Size

Packages

src/

view/

phui/

PHUIIconView.php

6 lines

O1: Blessed Committers

Diff 952

View Options

src/view/phui/PHUIIconView.php

Fix some icons not displayed on UIExamples' "Icons and Images" (PHUIIconExample) pageClosedPublicActions