Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception calling Conduit's user.whoami
ClosedPublic

Authored by aklapper on Jun 13 2023, 00:26.
Tags
None
Referenced Files
F3317379: D25292.1743260729.diff
Fri, Mar 28, 15:05
F3307509: D25292.1743147810.diff
Thu, Mar 27, 07:43
F3306551: D25292.1743129696.diff
Thu, Mar 27, 02:41
F3291132: D25292.1742876794.diff
Mon, Mar 24, 04:26
F3248322: D25292.1742250503.diff
Sun, Mar 16, 22:28
F3222541: D25292.1741925871.diff
Thu, Mar 13, 04:17
F3218072: D25292.1741731771.diff
Mon, Mar 10, 22:22
F3171627: D25292.1741276272.diff
Wed, Mar 5, 15:51

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=97e163187418), phorge(head=master, ref.master=7bbd657c19c4)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/conduit/controller/PhabricatorConduitAPIController.php:686]

Closes T15469

Test Plan

After applying this change, /api/user.whoami correctly renders the "Method Call Result"

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable