Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception calling Conduit's user.whoami
ClosedPublic

Authored by aklapper on Jun 13 2023, 00:26.
Tags
None
Referenced Files
F2982496: D25292.1739960414.diff
Tue, Feb 18, 10:20
F2971302: D25292.1739539538.diff
Thu, Feb 13, 13:25
F2971301: D25292.1739539534.diff
Thu, Feb 13, 13:25
F2971300: D25292.1739539531.diff
Thu, Feb 13, 13:25
F2971299: D25292.1739539527.diff
Thu, Feb 13, 13:25
F2970930: D25292.1739533722.diff
Thu, Feb 13, 11:48
F2970929: D25292.1739533718.diff
Thu, Feb 13, 11:48
F2970928: D25292.1739533714.diff
Thu, Feb 13, 11:48

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=97e163187418), phorge(head=master, ref.master=7bbd657c19c4)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/conduit/controller/PhabricatorConduitAPIController.php:686]

Closes T15469

Test Plan

After applying this change, /api/user.whoami correctly renders the "Method Call Result"

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable