Paths

Table of Contentst

Differential D25485

CSS adjustments to Conpherence
ClosedPublic
Actions

Authored by waldyrious on Dec 2 2023, 10:25.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPe59702569f8e: CSS adjustments to Conpherence

Summary

Fix Conpherence messages overlapping header in mobile mode

Before:

After:

Make Conpherence input box be one line even in desktop mode

Before:

After:

This second change, in particular, is motivated by the fact that pressing Enter sends the message, whereas the multi-line box gives the impression that the Enter key would simply introduce a line break in the message. (That's still possible via Shift+Enter, btw.)

Test Plan

Visit a Conpherence room with some content in mobile mode; scroll down and notice that the messages no longer slightly overlap the header.
Visit a Conpherence room in desktop mode; verify that the input box now has the height of a single line.

Diff Detail

Repository

rP Phorge

Branch

conpherence-css-fixes

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 966
Build 966: arc lint + arc unit

Event Timeline

waldyrious created this revision.Dec 2 2023, 10:25

Owners added a reviewer: O1: Blessed Committers.Dec 2 2023, 10:25

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptDec 2 2023, 10:25

waldyrious requested review of this revision.Dec 2 2023, 10:25

Harbormaster completed remote builds in B966: Diff 1557.Dec 2 2023, 10:25

valerio.bozzolan awarded a token.Dec 2 2023, 10:27

waldyrious edited the summary of this revision. (Show Details)Dec 2 2023, 10:34

waldyrious edited the test plan for this revision. (Show Details)

waldyrious mentioned this in Z5: Phorge (flame).

waldyrious edited the summary of this revision. (Show Details)Dec 2 2023, 10:38

waldyrious added a project: Conpherence.

waldyrious mentioned this in T15225: Conpherence: add a dedicated "Send" button (not just the Enter key).Dec 2 2023, 10:42

Thank you so much for the header fix that’s been bugging me every time I use conpherence lol

I think changing desktop mode is now consistent for the reasons you indicate, though I was thinking we might want to better enable multi-line messages and remove the Enter = submit for both desktop and mobile (on mobile making a send button like most other chat apps).

In D25485#14022, @speck wrote:

I was thinking we might want to better enable multi-line messages and remove the Enter = submit for both desktop and mobile (on mobile making a send button like most other chat apps).

I agree, but I'd rather that be done separately, since there's a dedicated task for it (T15225), on which I've already suggested something along the same lines:

In T15225#14509, @waldyrious wrote:

if a dedicated send button is added, perhaps the multi-line input box could be restored, if the default behavior is changed to not send on Enter and only send when pressing the button.

Besides, I have no idea how I would go about doing that change, which seems significantly more complex than these CSS tweaks! 😅

Thanks @waldyrious - I agree with both you and @speck since I was affected by the first issue and since I believe that T15225 is a good thing. Tested, nice!

This revision is now accepted and ready to land.Dec 6 2023, 07:05

Thanks both! I'll land this, then.

Closed by commit rPe59702569f8e: CSS adjustments to Conpherence. · Explain WhyDec 6 2023, 15:36

This revision was automatically updated to reflect the committed changes.

waldyrious added a commit: rPe59702569f8e: CSS adjustments to Conpherence.