Page MenuHomePhorge

CSS adjustments to Conpherence
ClosedPublic

Authored by waldyrious on Dec 2 2023, 10:25.
Referenced Files
F2243071: D25485.1719379918.diff
Tue, Jun 25, 05:31
F2242668: D25485.1719301503.diff
Mon, Jun 24, 07:45
Unknown Object (File)
Sun, Jun 23, 20:57
Unknown Object (File)
Sun, Jun 23, 18:00
Unknown Object (File)
Sun, Jun 23, 18:00
Unknown Object (File)
Sun, Jun 23, 17:29
Unknown Object (File)
Sat, Jun 22, 11:08
Unknown Object (File)
Fri, Jun 21, 11:48
Tokens
"Love" token, awarded by valerio.bozzolan.

Details

Summary

Fix Conpherence messages overlapping header in mobile mode

Before:

image.png (337×398 px, 18 KB)

After:
image.png (337×398 px, 18 KB)

Make Conpherence input box be one line even in desktop mode

Before:

image.png (248×1 px, 17 KB)

After:
image.png (159×1 px, 14 KB)

This second change, in particular, is motivated by the fact that pressing Enter sends the message, whereas the multi-line box gives the impression that the Enter key would simply introduce a line break in the message. (That's still possible via Shift+Enter, btw.)

Test Plan
  • Visit a Conpherence room with some content in mobile mode; scroll down and notice that the messages no longer slightly overlap the header.
  • Visit a Conpherence room in desktop mode; verify that the input box now has the height of a single line.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

waldyrious edited the test plan for this revision. (Show Details)
waldyrious mentioned this in Z5: Phorge (flame).

Thank you so much for the header fix that’s been bugging me every time I use conpherence lol

I think changing desktop mode is now consistent for the reasons you indicate, though I was thinking we might want to better enable multi-line messages and remove the Enter = submit for both desktop and mobile (on mobile making a send button like most other chat apps).

In D25485#14022, @speck wrote:

I was thinking we might want to better enable multi-line messages and remove the Enter = submit for both desktop and mobile (on mobile making a send button like most other chat apps).

I agree, but I'd rather that be done separately, since there's a dedicated task for it (T15225), on which I've already suggested something along the same lines:

if a dedicated send button is added, perhaps the multi-line input box could be restored, if the default behavior is changed to not send on Enter and only send when pressing the button.

Besides, I have no idea how I would go about doing that change, which seems significantly more complex than these CSS tweaks! 😅

Thanks @waldyrious - I agree with both you and @speck since I was affected by the first issue and since I believe that T15225 is a good thing. Tested, nice!

This revision is now accepted and ready to land.Dec 6 2023, 07:05

Thanks both! I'll land this, then.

This revision was automatically updated to reflect the committed changes.