Paths

Table of Contentst

Mobile: hide unuseful "Persistent Chat" checkbox
ClosedPublic
Actions

Authored by valerio.bozzolan on Apr 13 2023, 19:38.

Details

Reviewers

Cigaryno
bfs
speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15240: Conpherence Notifications: on mobile, hide "Persisted Chat" flag

Commits

rP980293b707a0: Mobile: hide unuseful "Persistent Chat" checkbox

Summary

On mobile devices like tablets or toasters the "Persistent Chat"
floating widget is already hidden.

So, the related checkbox available from the top navigation bar
is just confusing on tablet and mobile devices / toasters, since
that nice checkbox does nothing there.

On mobile and tablet, this is the graphical change:

Before	After

This change do not change anything for desktop devices.
So, on desktop, that checkbox is obviously still visible.

Closes T15240

Test Plan

test on tablet and below: now the checkbox should be not visible
test on desktop: the checkbox should still be visible

Diff Detail

Repository

rP Phorge

Branch

arcpatch-D25120_3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 379
Build 379: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Apr 13 2023, 19:38

Owners added a reviewer: O1: Blessed Committers.Apr 13 2023, 19:38

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptApr 13 2023, 19:38

valerio.bozzolan requested review of this revision.Apr 13 2023, 19:38

Harbormaster completed remote builds in B243: Diff 483.Apr 13 2023, 19:38

valerio.bozzolan edited the summary of this revision. (Show Details)Apr 13 2023, 19:39

valerio.bozzolan added a task: T15240: Conpherence Notifications: on mobile, hide "Persisted Chat" flag .

valerio.bozzolan mentioned this in T15250: Raw use of "git diff" provides insufficient Diff Context.Apr 14 2023, 08:45

Hi @chris - if you would like to change the world tonight, don't tell anybody, but this is a good starting point ihih

Cigaryno accepted this revision.Apr 15 2023, 11:29

valerio.bozzolan mentioned this in Z1: Phorge.Apr 18 2023, 07:36

valerio.bozzolan edited the summary of this revision. (Show Details)

Last chance for @chris to become reviewer on this super-boring patch

😎

Edited: then a kitten will die :O

Hi @dcog :D do you like Conpherence?

It seems "Persistent Chat" is nonsense on mobile/tablet devices. I mean this check:

Conpherence - mobile - before.png (443×640 px, 58 KB)

Maybe you can share your ideas here. Thank you so much

Hi @Matthew :D

Do you like to surf on mobile devices? Here a lovely stupid fix

Feel free to share a comment!

update celerity

improve inline comment

Harbormaster completed remote builds in B344: Diff 635.May 3 2023, 13:46

bfs awarded a token.May 3 2023, 17:55

update celerity map again

Harbormaster completed remote builds in B379: Diff 692.May 8 2023, 13:34

Does anybody want to share any question? :)

valerio.bozzolan mentioned this in Wikimedia Hackaton 2023 Athens Code Sprint.May 18 2023, 10:16

Makes sense to me, as it mirrors the way the persistent chat tab/box itself is hidden in durable-column.css:

.device .conpherence-durable-column,
.printable .conpherence-durable-column,
!print .conpherence-durable-column {
  display: none;
}

In D25120#6771, @bfs wrote:
Makes sense to me, as it mirrors the way the persistent chat tab/box itself is hidden in durable-column.css:
.device .conpherence-durable-column,
.printable .conpherence-durable-column,
!print .conpherence-durable-column {
  display: none;
}

Thanks, I agree indeed

(Ufff I'm always super-hiped when I see "Accepted" in the email notification... but then I realize it's not from Blessed Committers 🥺 What a difficult world for us #PuppyCommitters.)

In D25120#6777, @valerio.bozzolan wrote:

(Ufff I'm always super-hiped when I see "Accepted" in the email notification... but then I realize it's not from Blessed Committers 🥺 What a difficult world for us #PuppyCommitters.)

Heh, yeah, I've been doing a few reviews on the simpler stuff with the hope that it might nudge along a blessing so it can be landed.

Macro makeitso: