Differential D25085

PonderQuestion: add method isStatusClosed() and test cases
AbandonedPublic
Actions

Authored by valerio.bozzolan on Mar 23 2023, 14:32.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15166: Render Ponder mentions as striked if resolved (like Tasks)

Summary

This modification should not change anything logically.

Now you can call $ponderQuestion->isStatusClosed() that just returns true
for whatever closed status, and false otherwise.

The next step then is:

https://we.phorge.it/T15166

This is a very small change but this also adds two unit tests,
so there are more files edited than expected to keep the linter
happy.

Ref T15166

Test Plan

Verify that nothing has changed logically

Diff Detail

Repository

rP Phorge

Branch

ponder-resolved

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 161
Build 161: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Mar 23 2023, 14:32

Owners added a reviewer: O1: Blessed Committers.Mar 23 2023, 14:32

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMar 23 2023, 14:32

valerio.bozzolan requested review of this revision.Mar 23 2023, 14:32

Harbormaster completed remote builds in B160: Diff 372.Mar 23 2023, 14:32

valerio.bozzolan retitled this revision from PonderQuestion: add method isStatusClosed() and test cases This modification should not change anything logically. So, now you can call $ponderQuestion->isStatusClosed() that it just returns true for whatever closed status, and false... to PonderQuestion: add method isStatusClosed() and test cases.Mar 23 2023, 14:32

valerio.bozzolan edited the summary of this revision. (Show Details)

apply lint tips

Harbormaster completed remote builds in B161: Diff 373.Mar 23 2023, 14:34

valerio.bozzolan mentioned this in 2023-03-27.Mar 27 2023, 14:06

For some reasons, this patch was not auto closed from:

D25086: Ponder: strike code of resolved questions in query results

I mark this as abandoned but it's merged really automatically by arc diff.

https://we.phorge.it/rP5eac69b79dbb37b5efa29c3d7383605ea64426e0