Page MenuHomePhorge

PonderQuestion: add method isStatusClosed() and test cases
AbandonedPublic

Authored by valerio.bozzolan on Mar 23 2023, 14:32.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 31, 06:08
Unknown Object (File)
May 7 2023, 08:22
Unknown Object (File)
Apr 30 2023, 19:37
Unknown Object (File)
Apr 26 2023, 20:48
Unknown Object (File)
Apr 10 2023, 11:08
Unknown Object (File)
Apr 4 2023, 05:37
Unknown Object (File)
Apr 3 2023, 16:27
Unknown Object (File)
Apr 2 2023, 20:15

Details

Summary

This modification should not change anything logically.

Now you can call $ponderQuestion->isStatusClosed() that just returns true
for whatever closed status, and false otherwise.

The next step then is:

https://we.phorge.it/T15166

This is a very small change but this also adds two unit tests,
so there are more files edited than expected to keep the linter
happy.

Ref T15166

Test Plan
  • Verify that nothing has changed logically

Diff Detail

Repository
rP Phorge
Branch
ponder-resolved
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 161
Build 161: arc lint + arc unit

Event Timeline

valerio.bozzolan retitled this revision from PonderQuestion: add method isStatusClosed() and test cases This modification should not change anything logically. So, now you can call $ponderQuestion->isStatusClosed() that it just returns true for whatever closed status, and false... to PonderQuestion: add method isStatusClosed() and test cases.Mar 23 2023, 14:32
valerio.bozzolan edited the summary of this revision. (Show Details)

For some reasons, this patch was not auto closed from:

D25086: Ponder: strike code of resolved questions in query results

I mark this as abandoned but it's merged really automatically by arc diff.

https://we.phorge.it/rP5eac69b79dbb37b5efa29c3d7383605ea64426e0