Page MenuHomePhorge

PonderQuestion: add method isStatusClosed() and test cases
AbandonedPublic

Authored by valerio.bozzolan on Mar 23 2023, 14:32.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 05:55
Unknown Object (File)
Thu, Mar 21, 20:32
Unknown Object (File)
Thu, Mar 21, 10:55
Unknown Object (File)
Thu, Mar 21, 01:04
Unknown Object (File)
Wed, Mar 20, 16:29
Unknown Object (File)
Wed, Mar 20, 10:06
Unknown Object (File)
Tue, Mar 19, 15:00
Unknown Object (File)
Mon, Mar 18, 12:37

Details

Summary

This modification should not change anything logically.

Now you can call $ponderQuestion->isStatusClosed() that just returns true
for whatever closed status, and false otherwise.

The next step then is:

https://we.phorge.it/T15166

This is a very small change but this also adds two unit tests,
so there are more files edited than expected to keep the linter
happy.

Ref T15166

Test Plan
  • Verify that nothing has changed logically

Diff Detail

Repository
rP Phorge
Branch
ponder-resolved
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 161
Build 161: arc lint + arc unit

Event Timeline

valerio.bozzolan retitled this revision from PonderQuestion: add method isStatusClosed() and test cases This modification should not change anything logically. So, now you can call $ponderQuestion->isStatusClosed() that it just returns true for whatever closed status, and false... to PonderQuestion: add method isStatusClosed() and test cases.Mar 23 2023, 14:32
valerio.bozzolan edited the summary of this revision. (Show Details)

For some reasons, this patch was not auto closed from:

D25086: Ponder: strike code of resolved questions in query results

I mark this as abandoned but it's merged really automatically by arc diff.

https://we.phorge.it/rP5eac69b79dbb37b5efa29c3d7383605ea64426e0