Page MenuHomePhorge
Differential D25086

Ponder: strike code of resolved questions in query results
ClosedPublic
Actions

Authored by valerio.bozzolan on Mar 23 2023, 14:56.
Tags
None
Referenced Files
F3284763: D25086.1742785020.diff
Sun, Mar 23, 02:57
F3250768: D25086.1742315692.diff
Mon, Mar 17, 16:34
F3250423: D25086.1742301116.diff
Mon, Mar 17, 12:31
F3224855: D25086.1742089402.diff
Sat, Mar 15, 01:43
F3220670: D25086.1741813003.diff
Tue, Mar 11, 20:56
F3220416: D25086.1741809991.diff
Tue, Mar 11, 20:06
F3220415: D25086.1741809988.diff
Tue, Mar 11, 20:06
F3220414: D25086.1741809985.diff
Tue, Mar 11, 20:06
View All 39 Files
Subscribers
Cigaryno
Matthew
speck
tobiaswiese

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15166: Render Ponder mentions as striked if resolved (like Tasks)
Commits
rP5eac69b79dbb: Ponder: strike code of resolved questions in query results
Summary

After this change, search results with resolved
questions are striked, just like any Closed Maniphest
Tasks is already striked, etc.

https://we.phorge.it/T15166

There is still the same thing to be done at Remarkup.

Ref T15166

Test Plan
  • go in the page /ponder/query/all/ and see that closed questions are now striked

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.Mar 23 2023, 14:56
Owners added a reviewer: O1: Blessed Committers.Mar 23 2023, 14:56
Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMar 23 2023, 14:56
valerio.bozzolan requested review of this revision.Mar 23 2023, 14:56
Harbormaster completed remote builds in B162: Diff 374.Mar 23 2023, 14:56
valerio.bozzolan updated this revision to Diff 410.Mar 27 2023, 05:23

add inline comment

Harbormaster completed remote builds in B193: Diff 410.Mar 27 2023, 05:23
valerio.bozzolan mentioned this in 2023-03-27.Mar 27 2023, 13:59
valerio.bozzolan retitled this revision from Ponder: strike resolved questions in query results to Ponder: strike code of resolved questions in query results.Mar 27 2023, 18:25
avivey accepted this revision.Mar 27 2023, 18:26
This revision is now accepted and ready to land.Mar 27 2023, 18:26
Closed by commit rP5eac69b79dbb: Ponder: strike code of resolved questions in query results. · Explain WhyMar 27 2023, 18:55
This revision was automatically updated to reflect the committed changes.
valerio.bozzolan added a commit: rP5eac69b79dbb: Ponder: strike code of resolved questions in query results.
valerio.bozzolan mentioned this in Z1: Phorge.Mar 27 2023, 19:00
valerio.bozzolan mentioned this in 2023 Week 2.Mar 27 2023, 20:28
valerio.bozzolan mentioned this in D25085: PonderQuestion: add method isStatusClosed() and test cases.Mar 28 2023, 05:54
valerio.bozzolan mentioned this in T15166: Render Ponder mentions as striked if resolved (like Tasks).Mar 28 2023, 06:31
avivey mentioned this in 2023 Week 17.Apr 25 2023, 06:54

Revision Contents
Changeset List

Diff 417

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/ponder/constants/PonderQuestionStatus.php

Loading...
View Options

src/applications/ponder/query/PonderQuestionSearchEngine.php

Loading...
View Options

src/applications/ponder/storage/PonderQuestion.php

Loading...
View Options

src/applications/ponder/storage/__tests__/PonderQuestionStatusTestCase.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0