valerio.bozzolan retitled this revision from Ponder: strike resolved questions in query results to Ponder: strike code of resolved questions in query results.Mar 27 2023, 18:25

avivey accepted this revision.Mar 27 2023, 18:26

This revision is now accepted and ready to land.Mar 27 2023, 18:26

Closed by commit rP5eac69b79dbb: Ponder: strike code of resolved questions in query results. · Explain WhyMar 27 2023, 18:55

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rP5eac69b79dbb: Ponder: strike code of resolved questions in query results.

valerio.bozzolan mentioned this in Z1: Phorge.Mar 27 2023, 19:00

valerio.bozzolan mentioned this in 2023 Week 2.Mar 27 2023, 20:28

valerio.bozzolan mentioned this in D25085: PonderQuestion: add method isStatusClosed() and test cases.Mar 28 2023, 05:54

valerio.bozzolan mentioned this in T15166: Render Ponder mentions as striked if resolved (like Tasks).Mar 28 2023, 06:31

avivey mentioned this in 2023 Week 17.Apr 25 2023, 06:54

Revision Contents
Changeset List

Path

Size

Packages

src/

__phutil_library_map__.php

O1: Blessed Committers

applications/

ponder/

constants/

PonderQuestionStatus.php

10 lines

O1: Blessed Committers

query/

PonderQuestionSearchEngine.php

3 lines

O1: Blessed Committers

storage/

PonderQuestion.php

8 lines

O1: Blessed Committers

__tests__/

PonderQuestionStatusTestCase.php

25 lines

O1: Blessed Committers

Diff 417

View Options

src/__phutil_library_map__.php

View Options

src/applications/ponder/constants/PonderQuestionStatus.php

Show First 20 Lines • Show All 80 Lines • ▼ Show 20 Lines	final class PonderQuestionStatus extends PonderConstants {
public static function getQuestionStatusClosedMap() {		public static function getQuestionStatusClosedMap() {
return array(		return array(
self::STATUS_CLOSED_RESOLVED,		self::STATUS_CLOSED_RESOLVED,
self::STATUS_CLOSED_OBSOLETE,		self::STATUS_CLOSED_OBSOLETE,
self::STATUS_CLOSED_INVALID,		self::STATUS_CLOSED_INVALID,
);		);
}		}

		/**
		* Check whenever a Ponder question status is Closed
		*
		* @param $status string
		* @return bool
		*/
		public static function isQuestionStatusClosed($status) {
		return in_array($status, self::getQuestionStatusClosedMap(), true);
		}

}		}

View Options

src/applications/ponder/query/PonderQuestionSearchEngine.php

Show First 20 Lines • Show All 151 Lines • ▼ Show 20 Lines	foreach ($questions as $question) {

$created_date = phabricator_date($question->getDateCreated(), $viewer);		$created_date = phabricator_date($question->getDateCreated(), $viewer);
$item->addIcon('none', $created_date);		$item->addIcon('none', $created_date);
$item->addByline(		$item->addByline(
pht(		pht(
'Asked by %s',		'Asked by %s',
$handles[$question->getAuthorPHID()]->renderLink()));		$handles[$question->getAuthorPHID()]->renderLink()));

		// Render Closed Questions as striked in query results
		$item->setDisabled($question->isStatusClosed());

$item->addAttribute(		$item->addAttribute(
pht(		pht(
'%s Answer(s)',		'%s Answer(s)',
new PhutilNumber($question->getAnswerCount())));		new PhutilNumber($question->getAnswerCount())));

if ($project_handles) {		if ($project_handles) {
$item->addAttribute(		$item->addAttribute(
id(new PHUIHandleTagListView())		id(new PHUIHandleTagListView())
Show All 35 Lines

View Options

src/applications/ponder/storage/PonderQuestion.php

View Options

src/applications/ponder/storage/tests/PonderQuestionStatusTestCase.php

Ponder: strike code of resolved questions in query resultsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 417

src/__phutil_library_map__.php

src/applications/ponder/constants/PonderQuestionStatus.php

src/applications/ponder/query/PonderQuestionSearchEngine.php

src/applications/ponder/storage/PonderQuestion.php

src/applications/ponder/storage/__tests__/PonderQuestionStatusTestCase.php

Ponder: strike code of resolved questions in query results
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/ponder/storage/tests/PonderQuestionStatusTestCase.php