Page MenuHomePhorge
Differential D25051

Destroy file attachments when file is deleted
Changes PlannedPublic
Actions

Authored by Dylsss on Sep 12 2022, 13:25.
Tags
Referenced Files
Unknown Object (File)
Sat, Jun 3, 17:54
Unknown Object (File)
Sat, Jun 3, 17:54
Unknown Object (File)
Sat, Jun 3, 17:54
Unknown Object (File)
Sat, Jun 3, 17:53
Unknown Object (File)
Sat, Jun 3, 17:53
Unknown Object (File)
Fri, Jun 2, 22:54
Unknown Object (File)
Wed, May 31, 23:08
Unknown Object (File)
Wed, May 31, 22:58
View All 99 Files
Subscribers
Cigaryno
Matthew
speck
tobiaswiese
valerio.bozzolan

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15110: File reference not removed when file is deleted
Summary

Adds new file attachment destruction engine and SQL patch for existing leftover attachments from deleted files.

Test Plan

Upload file, delete file. No Unknown Object in Referenced Files curtain.

Diff Detail

Repository
rP Phorge
Branch
arcpatch-D25051
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 84
Build 84: arc lint + arc unit

Event Timeline

Dylsss created this revision.Sep 12 2022, 13:25
Owners added a reviewer: O1: Blessed Committers.Sep 12 2022, 13:25
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptSep 12 2022, 13:25
Dylsss requested review of this revision.Sep 12 2022, 13:25
Harbormaster completed remote builds in B82: Diff 266.Sep 12 2022, 13:25
Dylsss added a task: T15110: File reference not removed when file is deleted.Sep 12 2022, 13:26
Dylsss updated this revision to Diff 267.Sep 12 2022, 18:06

Linting

Harbormaster completed remote builds in B83: Diff 267.Sep 12 2022, 18:07
Dylsss updated this revision to Diff 268.Sep 12 2022, 18:08

arc liberate

Harbormaster completed remote builds in B84: Diff 268.Sep 12 2022, 18:08
Cigaryno added a project: Files (archived).Sep 16 2022, 19:31
avivey accepted this revision.Jan 28 2023, 10:40
This revision is now accepted and ready to land.Jan 28 2023, 10:40
valerio.bozzolan added a comment.Mar 9 2023, 17:54

Do you want an hand to land this accepted revision?

Dylsss planned changes to this revision.Mar 22 2023, 23:21
valerio.bozzolan added a comment.Apr 7 2023, 22:22

I'm very curious about this improvement.

Feel free to share a comment about your current concerns on this change. I ask this since it's indicated as "planned changes".

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
resources/
sql/
autopatches/
6 lines--O1: Blessed Committers
src/
--O1: Blessed Committers
applications/
files/
engineextension/
28 lines10%
Loading...
O1: Blessed Committers

Diff 268

View Options

resources/sql/autopatches/20220912.fileattachment.01.delete.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/engineextension/PhabricatorFileAttachmentDestructionEngineExtension.php

Loading...