Page MenuHomePhorge

Destroy file attachments when file is deleted
Changes PlannedPublic

Authored by Dylsss on Sep 12 2022, 13:25.
Tags
Referenced Files
Unknown Object (File)
Wed, Mar 22, 20:46
Unknown Object (File)
Mon, Mar 20, 15:13
Unknown Object (File)
Thu, Mar 16, 21:53
Unknown Object (File)
Mon, Mar 13, 14:23
Unknown Object (File)
Mon, Mar 13, 00:04
Unknown Object (File)
Sun, Mar 12, 00:15
Unknown Object (File)
Sat, Mar 11, 22:50
Unknown Object (File)
Sat, Mar 11, 21:50

Details

Summary

Adds new file attachment destruction engine and SQL patch for existing leftover attachments from deleted files.

Test Plan

Upload file, delete file. No Unknown Object in Referenced Files curtain.

Diff Detail

Repository
rP Phorge
Branch
arcpatch-D25051
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 83
Build 83: arc lint + arc unit

Unit TestsFailed

TimeTest
1,645 msPhabricatorLibraryTestCase::testEverythingImplemented
EXCEPTION (Exception): Source file "/opt/phabricator/src/applications/files/engineextension/PhabricatorFilesAttachmentsDestructionEngineExtension.php" failed to load. #0 /opt/arcanist/src/init/lib/PhutilBootloader.php(211): PhutilBootloader->executeInclude('/opt/phabricato...') #1 /opt/arcanist/src/symbols/PhutilSymbolLoader.php(423): PhutilBootloader->loadLibrarySource('phorge', 'applications/fi...')
945 msPhabricatorLibraryTestCase::testLibraryMap
Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:51): The library map is out of date. Rebuild it with `arc liberate`. These entries differ: class.PhabricatorFileAttachmentDestructionEngineExtension, class.PhabricatorFileAttachmentsDestructionEngineExtension, xmap.PhabricatorFileAttachmentDestructionEngineExtension, xmap.PhabricatorFileAttachmentsDestructionEngineExtension.
465 msPhabricatorLibraryTestCase::testMethodVisibility
EXCEPTION (Exception): Source file "/opt/phabricator/src/applications/files/engineextension/PhabricatorFilesAttachmentsDestructionEngineExtension.php" failed to load. #0 /opt/arcanist/src/init/lib/PhutilBootloader.php(211): PhutilBootloader->executeInclude('/opt/phabricato...') #1 /opt/arcanist/src/symbols/PhutilSymbolLoader.php(423): PhutilBootloader->loadLibrarySource('phorge', 'applications/fi...')
881 msPhabricatorCelerityTestCase::testCelerityMaps
1 assertion passed.
908 msPhabricatorConduitTestCase::testConduitMethods
1 assertion passed.
View Full Test Results (3 Failed · 4 Passed)

Event Timeline

Dylsss requested review of this revision.Sep 12 2022, 13:25
This revision is now accepted and ready to land.Jan 28 2023, 10:40

Do you want an hand to land this accepted revision?

Dylsss planned changes to this revision.Wed, Mar 22, 23:21