Differential D25051

Destroy file attachments when file is deleted
Changes PlannedPublic
Actions

Authored by Dylsss on Sep 12 2022, 13:25.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15110: File reference not removed when file is deleted

Summary

Adds new file attachment destruction engine and SQL patch for existing leftover attachments from deleted files.

Test Plan

Upload file, delete file. No Unknown Object in Referenced Files curtain.

Diff Detail

Repository

rP Phorge

Branch

arcpatch-D25051

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 83
Build 83: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1,645 ms	PhabricatorLibraryTestCase::testEverythingImplemented EXCEPTION (Exception): Source file "/opt/phabricator/src/applications/files/engineextension/PhabricatorFilesAttachmentsDestructionEngineExtension.php" failed to load. #0 /opt/arcanist/src/init/lib/PhutilBootloader.php(211): PhutilBootloader->executeInclude('/opt/phabricato...') #1 /opt/arcanist/src/symbols/PhutilSymbolLoader.php(423): PhutilBootloader->loadLibrarySource('phorge', 'applications/fi...')
	945 ms	PhabricatorLibraryTestCase::testLibraryMap Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:51): The library map is out of date. Rebuild it with `arc liberate`. These entries differ: class.PhabricatorFileAttachmentDestructionEngineExtension, class.PhabricatorFileAttachmentsDestructionEngineExtension, xmap.PhabricatorFileAttachmentDestructionEngineExtension, xmap.PhabricatorFileAttachmentsDestructionEngineExtension.
	465 ms	PhabricatorLibraryTestCase::testMethodVisibility EXCEPTION (Exception): Source file "/opt/phabricator/src/applications/files/engineextension/PhabricatorFilesAttachmentsDestructionEngineExtension.php" failed to load. #0 /opt/arcanist/src/init/lib/PhutilBootloader.php(211): PhutilBootloader->executeInclude('/opt/phabricato...') #1 /opt/arcanist/src/symbols/PhutilSymbolLoader.php(423): PhutilBootloader->loadLibrarySource('phorge', 'applications/fi...')
	881 ms	PhabricatorCelerityTestCase::testCelerityMaps 1 assertion passed.
	908 ms	PhabricatorConduitTestCase::testConduitMethods 1 assertion passed.
		View Full Test Results (3 Failed · 4 Passed)