Page MenuHomePhorge

Destroy file attachments when file is deleted
Changes PlannedPublic

Authored by Dylsss on Sep 12 2022, 13:25.
Tags
Referenced Files
F271053: D25051.diff
Fri, Mar 24, 22:25
Unknown Object (File)
Wed, Mar 22, 20:46
Unknown Object (File)
Mon, Mar 20, 15:13
Unknown Object (File)
Thu, Mar 16, 21:53
Unknown Object (File)
Mon, Mar 13, 14:23
Unknown Object (File)
Mon, Mar 13, 00:04
Unknown Object (File)
Sun, Mar 12, 00:15
Unknown Object (File)
Sat, Mar 11, 22:50

Details

Summary

Adds new file attachment destruction engine and SQL patch for existing leftover attachments from deleted files.

Test Plan

Upload file, delete file. No Unknown Object in Referenced Files curtain.

Diff Detail

Repository
rP Phorge
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 82
Build 82: arc lint + arc unit

Unit TestsFailed

TimeTest
0 msPhabricatorCelerityTestCase::testCelerityMaps
EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, 'Code coverage n...', '/opt/arcanist/s...', 703, Array) #1 /opt/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
0 msPhabricatorConduitTestCase::testConduitMethods
EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, 'Code coverage n...', '/opt/arcanist/s...', 703, Array) #1 /opt/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
0 msPhabricatorInfrastructureTestCase::testApplicationsInstalled
EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, 'Code coverage n...', '/opt/arcanist/s...', 703, Array) #1 /opt/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
0 msPhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries
EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, 'Code coverage n...', '/opt/arcanist/s...', 703, Array) #1 /opt/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
1 msPhabricatorLibraryTestCase::testEverythingImplemented
EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, 'Code coverage n...', '/opt/arcanist/s...', 703, Array) #1 /opt/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
View Full Test Results (7 Failed)

Event Timeline

Dylsss requested review of this revision.Sep 12 2022, 13:25
This revision is now accepted and ready to land.Jan 28 2023, 10:40

Do you want an hand to land this accepted revision?

Dylsss planned changes to this revision.Wed, Mar 22, 23:21