Differential D25051

Destroy file attachments when file is deleted
Changes PlannedPublic
Actions

Authored by Dylsss on Sep 12 2022, 13:25.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15110: File reference not removed when file is deleted

Summary

Adds new file attachment destruction engine and SQL patch for existing leftover attachments from deleted files.

Test Plan

Upload file, delete file. No Unknown Object in Referenced Files curtain.

Diff Detail

Repository

rP Phorge

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 82
Build 82: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	0 ms	PhabricatorCelerityTestCase::testCelerityMaps EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, 'Code coverage n...', '/opt/arcanist/s...', 703, Array) #1 /opt/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
	0 ms	PhabricatorConduitTestCase::testConduitMethods EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, 'Code coverage n...', '/opt/arcanist/s...', 703, Array) #1 /opt/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
	0 ms	PhabricatorInfrastructureTestCase::testApplicationsInstalled EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, 'Code coverage n...', '/opt/arcanist/s...', 703, Array) #1 /opt/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
	0 ms	PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, 'Code coverage n...', '/opt/arcanist/s...', 703, Array) #1 /opt/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
	1 ms	PhabricatorLibraryTestCase::testEverythingImplemented EXCEPTION (RuntimeException): Code coverage needs to be enabled in php.ini by setting 'xdebug.mode' to 'coverage' #0 [internal function]: PhutilErrorHandler::handleError(2, 'Code coverage n...', '/opt/arcanist/s...', 703, Array) #1 /opt/arcanist/src/unit/engine/phutil/PhutilTestCase.php(703): xdebug_start_code_coverage(3)
		View Full Test Results (7 Failed)