First, thanks for doing this, this is definitively needed. But in its current form, it is effectively impossible to review. There are changes to js files, which I think is a clear indication that this is likely automated.

This patch suppresses the deprecation errors at each site, but there might be a simpler workaround in the same spirit: change the error_reporting calls (of which there are only a handful) to exclude E_DEPRECATED. That would risk masking any other deprecations (probably fine in production, but not in development), whereas this patch risks hiding any non-deprecation errors at these locations.

Depending on how the allow_null RFC is handled, Phabricator/Phorge could potentially need no code changes, except to make it refuse to run on PHP 8.1.

Yeah if that RFC passes then that would make things way easier. And yes I used sed for a lot of the changes.

jeremy.norris subscribed.Mar 6 2022, 16:35

I got differential working under PHP 8.1 by doing a global replace of single parameter strlen commands to add the null coalesce operator

perl -pi -e 's/(strlen\(\$[a-zA-Z\d_]+)\)/$1 ?? "")/g' `find . -type f -name '*.php'`

There were a couple of other fixes needed to a few isolated preg_match(), trim(), strcasecmp() statements.

Then had to revert the PHP upgrade as PHP 8.1 broke a different application :-/

Cigaryno subscribed.Sep 10 2022, 17:50

This revision is nearly impossible to test

See my comments here D25030#1893

Error suppression with "@" is a poor solution to this issue

This revision now requires changes to proceed.Nov 11 2022, 16:11

MacFan4000 abandoned this revision.Nov 11 2022, 16:29

Sten mentioned this in T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4.Feb 1 2023, 16:13

valerio.bozzolan added a task: T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.Mar 26 2023, 10:40

In D25031#1902, @Ekubischta wrote:

This revision is nearly impossible to test

See my comments here D25030#1893

Error suppression with "@" is a poor solution to this issue

Thank you for this comment. Inspired by this, I tried to cover some cases with a different approach. The result is here:

D25097: PHP 8.2: fixes for strlen() not accepting NULL anymore

The reasons are here:

valerio.bozzolan added a task: T15198: PHP 8.2 deprecations fix strategies.Mar 26 2023, 15:09

valerio.bozzolan retitled this revision from Fix most PHP 8.1 issues to Fix most PHP 8.1 and 8.2 issues.

Maybe we can retry here (smaller):

D25097: PHP 8.2: fixes for strlen() not accepting NULL anymore

Revision Contents
Changeset List

Path

Size

Packages

externals/

cowsay/

cowsay

4 lines

Fix most PHP 8.1 and 8.2 issuesAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 83

externals/cowsay/cowsay

externals/diff_match_patch/diff_match_patch.php

externals/figlet/chkfont.c

externals/figlet/figlet.c

externals/figlet/getopt.c

externals/mimemailparser/MimeMailParser.class.php

externals/mimemailparser/attachment.class.php

externals/pear-figlet/Text/Figlet.php

externals/pear-figlet/docs/examples/hello_world.php

externals/phpmailer/class.phpmailer-lite.php

externals/phpmailer/class.phpmailer.php

externals/phpmailer/class.pop3.php

externals/phpmailer/class.smtp.php

externals/phpqrcode/phpqrcode.php

externals/porter-stemmer/src/Porter.php

externals/stripe-php/lib/Stripe/ApiRequestor.php

externals/stripe-php/lib/Stripe/ApiResource.php

externals/xhprof/xhprof_lib.php

resources/sql/autopatches/20140108.ddbpname.2.php

resources/sql/autopatches/20140210.projcfield.1.blurb.php

resources/sql/autopatches/20140211.dx.2.migcommenttext.php

resources/sql/autopatches/20140410.accountsecret.2.php

resources/sql/autopatches/20140722.audit.4.migtext.php

resources/sql/autopatches/20141107.phriction.policy.2.php

resources/sql/autopatches/20141107.phriction.popkeys.php

resources/sql/autopatches/20150506.calendarunnamedevents.1.php

resources/sql/autopatches/20150602.mlist.2.php

resources/sql/autopatches/20151210.land.2.refphid.php

resources/sql/autopatches/20151218.key.2.keyphid.php

resources/sql/autopatches/20151223.proj.05.updatekeys.php

resources/sql/autopatches/20160110.repo.02.slug.php

resources/sql/autopatches/20160202.ipv6.2.php

resources/sql/autopatches/20160503.repo.03.lpathmigrate.php

resources/sql/autopatches/20160503.repo.05.urimigrate.php

resources/sql/autopatches/20160601.user.02.copyprefs.php

resources/sql/autopatches/20170528.maniphestdupes.php

resources/sql/autopatches/20180215.phriction.02.phidvalues.php

resources/sql/autopatches/20181031.board.01.queryreset.php

resources/sql/autopatches/20181213.auth.02.populatephid.php

resources/sql/autopatches/20190115.mfa.02.migrate.php

resources/sql/autopatches/20190206.external.04.providerlink.php

resources/sql/autopatches/20191114.email.02.populate.php

resources/sql/autopatches/20200222.xident.01.migrate.php

resources/sql/autopatches/20210215.changeset.02.phid-populate.php

resources/sql/autopatches/20210802.legalpad_document_signature.02.phid-populate.php

resources/sql/patches/090.forceuniqueprojectnames.php

resources/sql/patches/093.gitremotes.php

resources/sql/patches/20130219.commitsummarymig.php

resources/sql/patches/20130921.xmigratemaniphest.php

resources/sql/patches/20131106.diffphid.2.mig.php

scripts/celerity/generate_emoji.php

scripts/mail/mail_handler.php

scripts/repository/commit_hook.php

scripts/sql/manage_storage.php

scripts/ssh/ssh-auth.php

scripts/ssh/ssh-connect.php

scripts/ssh/ssh-exec.php

scripts/symbols/clear_repository_symbols.php

scripts/symbols/generate_ctags_symbols.php

scripts/symbols/generate_php_symbols.php

scripts/symbols/import_repository_symbols.php

scripts/util/add_macro.php

src/aphront/AphrontRequest.php

src/aphront/__tests__/AphrontRoutingMapTestCase.php

src/aphront/configuration/AphrontApplicationConfiguration.php

src/aphront/headerparser/AphrontHTTPHeaderParser.php

src/aphront/multipartparser/AphrontMultipartParser.php

src/aphront/multipartparser/AphrontMultipartPart.php

src/aphront/requeststream/AphrontRequestStream.php

src/aphront/response/AphrontAjaxResponse.php

src/aphront/response/AphrontFileResponse.php

src/aphront/response/AphrontRedirectResponse.php

src/aphront/response/AphrontResponse.php

src/aphront/response/AphrontWebpageResponse.php

Fix most PHP 8.1 and 8.2 issues
AbandonedPublic
Actions

Revision Contents
Changeset List

src/aphront/tests/AphrontRoutingMapTestCase.php