2024 week 35
2024 week 35
11 May 2024 -24 August 2024
| Repo | Hash |
|---|---|
| rP Phorge | b02615bd5027ee51ac68d48a0a64306b75285789 |
| rARC Arcanist | 04e3e250f7da6a55c908d373a0df9949eeea6d7b |
Highlights
- Custom Fields can be displayed in search results - see Custom Fields manual for details.
- Flags show in Maniphest search results, and Repository will be shown in Differential search results.
- The Remarkup Help button takes you to a real application installed locally (instead of a wiki page located here).
- When intending to comment on a task that is Closed as Duplicate, a warning is shown in the comment field.
- Workboard columns can be collapsed by clicking on their header (allows faster scrolling on mobile to the next column).
General
| Change summary (with main Tag) | Patch | Main Task |
|---|---|---|
| UX: Feed: fix "created this task" to always be the first one | D25626 | T15816 |
| UX: Remove broken button when unsupported (Files, Legalpad, etc.) | D25730 | T15378 |
| UX: Custom Fields show up in search results and with custom icons | D25548 D25549 | T15750 |
| Workboard: Add new column triggers: Add Subscribers + Remove Subscribers | D25080 | T15162 |
| Workboard: Column content can be collapsed (e.g. in mobile view) for faster scrolling | D25672 | T15843 |
| Bug Reports: Fix legacy search bugs causing exceptions instead of login page | D25621 | T15704 |
| Conduit: Allow API phriction.edit to modify view and edit policies | D25693 | T15858 |
| Almanac/Drydock/Harbormaster: Add welcome pages | D25675 | T15018 |
| Charts: Updated d3.js library from version 5.9.2 to 6.7.0 | D25631 | T15820 |
| Remarkup: Make Help a real application to document details of cowsay and figlet | D25698 | T15401 |
| Remarkup: Prevent internal links from opening in a new tab | D25118 | T15161 |
| Phriction: Fix drag & drop file visibility | D25705 | T15106 |
| Conpherence: Fix drag & drop file visibility | D25709 | T15106 |
| Arcanist: Add missing support for non-English Subversion shells | D25691 | T15855 |
| Update timezone information to TZ2024a for the glory of Asia/Bishkek | D25722 | T15876 |
| Files: Remove orphan attachments causing "Unknown Object" in "Referenced Files" | D25051 | T15110 |
| Maniphest: Tasks in public Phorge installations include Open Graph protocol HTML meta tags, allowing other web applications to show a task preview | D25668 | T15472 |
| Maniphest: When removing a comment, the actor is not added as a task subscriber | D25760 | T15899 |
| Differential: A button in the file header bar allows to copy the file path | D25757 | T15897 |
| Herald: Invalid Herald rules are logged (see Dark Console) for easier investigation | D25735 D25736 D25737 | T15921 |
| Diffusion: improve support for Subversion commit pages: fix "Authored On" date | D25796 | T15612 |
| Bug Reports: Various legacy bugs fixed | ||
| Bug Reports: Increased compatibility with PHP 8.1+ | ||
Breaking Changes for Third-Party Code
- The buildStandardPageView() and buildStandardPageResponse() methods were removed from the PhabricatorController class in D25634. These methods were deprecated since 2015. Custom code which calls these methods must be ported to use the newPage() method from the same class.
- The included copy of the d3 JavaScript library to render charts was updated from version 5.9.2 to 6.7.0. Custom code to render charts relying on Phorge's Facts application or on calling d3 methods directly may require API adjustments. See the upstream d3 migration guide.
Database Upgrades
NOTE: As usual, follow Upgrading Phorge. In short, don't forget ./bin/storage upgrade.
| Database Script | Rationale | Details |
|---|---|---|
| 20230917.fileattachment.01.delete.sql | Remove legacy orphan rows from the table phabricator_file.file_attachment related to already-deleted files. | D25051 |
NOTE: If you have 1M+ phabricator_file.file and 10K file_attachment - it may delete 200K rows in 2s
WARNING: In our production this cleanup took 1 minute
IMPORTANT: Share that patch to your DBA to understand your possible downtime! This may be a massive cleanup.
Visual Changes
Tasks Closed as Duplicate
No need anymore to write "This task is closed as duplicate, do not comment here but on the other task". Now this message is bundled in the new comment form:
Related patch: D25546.
More Welcome Pages for Continuous Integration
Drydock and Almanac have now Welcome pages to help you set up your epic CI/CD infrastructure.
Don't worry, it's not you, it is really still very over-complicated. But using your own infrastructure with Phorge is worth it!
 |  |
 |  |
Related patch: D25675
Get Rid of Unknown Objects
Finally you should never see anymore these confusing orphan references from your sidebar:
Related patch: D25051
Tags
None
Referenced Files
| F2236006: Phorge error Unknown objects.png | |
| Oct 9 2024, 09:36 |
| F2243111: Phorge Almanac Networks welcome.png | |
| Aug 28 2024, 10:19 |
| F2243110: Phorge Almanac Services welcome.png | |
| Aug 28 2024, 10:19 |
| F2243112: Phorge Almanac Devices welcome.png | |
| Aug 28 2024, 10:19 |
| F2243109: Phorge Drydock Blueprints welcome.jpg | |
| Aug 28 2024, 10:19 |
| F2243121: Phorge closed as duplicate comment.png | |
| Aug 28 2024, 10:19 |
Subscribers
- Last Author
- valerio.bozzolan
- Last Edited
- Oct 9 2024, 09:36
Event Timeline
Comment Actions
Maybe link to 'that patch' to save everyone's time? (EDIT: Nevermind, missed the "details" bar hidden behind horizontal scroll @ mobile)
Also the page title should probably be 2024 week 35 or something for consistency?