Page MenuHomePhorge

Affects-WikimediaTag
ActivePublic

Members

  • This project does not have any members.
  • View All

Details

Description

Task that can be used to mark something that affects or involves Wikimedia Phabricator.

https://phabricator.wikimedia.org/

Recent Activity

Yesterday

aklapper placed T15650: AphrontDuplicateKeyQueryException dragging task from milestone column to main board column: Duplicate entry for key 'boardPHID' up for grabs.
Thu, Mar 28, 19:54 · Affects-Wikimedia, Bug Reports
aklapper added a subtask for T15650: AphrontDuplicateKeyQueryException dragging task from milestone column to main board column: Duplicate entry for key 'boardPHID': T15764: Moving tasks on a workboard via the "Add Action" dropdown does not update column and column positions tables.
Thu, Mar 28, 19:54 · Affects-Wikimedia, Bug Reports

Tue, Mar 26

avivey closed T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description as Resolved by committing rP216d308507ed: Fix Project Hovercard rendering @mention.
Tue, Mar 26, 18:07 · Affects-Wikimedia, Bug Reports
avivey added a revision to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description: D25562: Fix Project Hovercard rendering @mention.
Tue, Mar 26, 15:40 · Affects-Wikimedia, Bug Reports
avivey added a comment to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.

It might not happen on any other card, because we might not be rendering Remarkup on any other card. Interesting....

Tue, Mar 26, 10:46 · Affects-Wikimedia, Bug Reports
avivey added a comment to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.

So this is quite an edge-case:

  • PhabricatorMentionRemarkupRule wants to give the mention a different color, depending on if the user can view the "context object", in this case the Project.
  • There's an automatic rule, saying a member of a project can always view the project
  • When loading the project for the hovercard, we don't bother loading all the member list
  • When loading the user for the mention, we don't bother loading all its projects
  • so data is not available at the rendering point.
Tue, Mar 26, 10:39 · Affects-Wikimedia, Bug Reports
avivey claimed T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.
Tue, Mar 26, 10:23 · Affects-Wikimedia, Bug Reports

Mon, Mar 25

valerio.bozzolan added a comment to T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.

Another good simple candidate GDPR-friendly:

Mon, Mar 25, 10:36 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan added a revision to T15372: "RuntimeException: Undefined array key" when pasting "a {{{a}}} a" comment (due to regex in PhutilRemarkupInterpreterBlockRule.php): D25559: Update unit test of InterpreterBlockRule for "a {{{a}}}".
Mon, Mar 25, 07:18 · Bug Reports, Affects-Wikimedia
valerio.bozzolan added a revision to T15372: "RuntimeException: Undefined array key" when pasting "a {{{a}}} a" comment (due to regex in PhutilRemarkupInterpreterBlockRule.php): D25415: Make InterpreterBlockRule regex only match on valid interpreter names.
Mon, Mar 25, 07:12 · Bug Reports, Affects-Wikimedia

Sun, Mar 24

valerio.bozzolan triaged T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description as High priority.

Ouch

Sun, Mar 24, 15:46 · Affects-Wikimedia, Bug Reports

Thu, Mar 21

aklapper updated the task description for T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.
Thu, Mar 21, 22:34 · Affects-Wikimedia, Bug Reports
aklapper added a comment to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.

Also note that we have a similar PhabricatorDataNotAttachedException in PhabricatorRepositoryCommit (via getRepository()) in downstream https://phabricator.wikimedia.org/T360714. It's without reproduction steps but sounds a bit similar.

Thu, Mar 21, 20:40 · Affects-Wikimedia, Bug Reports
aklapper updated the task description for T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.
Thu, Mar 21, 20:21 · Affects-Wikimedia, Bug Reports
aklapper closed T15631: "Map returned omits required key" exception for second result page (cursor) for Maniphest search ordered by custom field as Resolved by committing rPd42b3eb0b17a: Fix "Map omits required key" exception by comparing result order against modern….
Thu, Mar 21, 18:26 · Affects-Wikimedia, Bug Reports

Fri, Mar 15

aklapper claimed T15650: AphrontDuplicateKeyQueryException dragging task from milestone column to main board column: Duplicate entry for key 'boardPHID'.
Fri, Mar 15, 16:45 · Affects-Wikimedia, Bug Reports

Sun, Mar 10

valerio.bozzolan added a comment to T15631: "Map returned omits required key" exception for second result page (cursor) for Maniphest search ordered by custom field.

Maybe unrelated. But after we fix PhabricatorCursorPagedPolicyAwareQuery, maybe we will find a crash test also for the first two lines:

Sun, Mar 10, 16:25 · Affects-Wikimedia, Bug Reports
valerio.bozzolan triaged T15631: "Map returned omits required key" exception for second result page (cursor) for Maniphest search ordered by custom field as Normal priority.

Interestingly I was able to reproduce, but only creating 101+ tasks manually and going to the next page. So after that ?after=100 is introduced.

Sun, Mar 10, 12:05 · Affects-Wikimedia, Bug Reports

Jan 4 2024

aklapper added a revision to T15631: "Map returned omits required key" exception for second result page (cursor) for Maniphest search ordered by custom field: D25504: Fix "Map omits required key" exception by comparing result order against modern field keys.
Jan 4 2024, 09:17 · Affects-Wikimedia, Bug Reports

Dec 31 2023

valerio.bozzolan renamed T15163: The Task Cover Image is visible only to the uploader (invisible to Task participants) from Auto-Attach a File when dropping it as Task cover image to The Task Cover Image is visible only to the uploader (invisible to Task participants).
Dec 31 2023, 00:21 · Affects-Wikimedia, Maniphest, User-valerio.bozzolan, Cover Image, Workboard

Dec 18 2023

aklapper closed T15688: "Undefined index: PHID-PROJ-***" in project.search API when project_customfieldstorage table has additional fields not requested, a subtask of T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge, as Resolved.
Dec 18 2023, 11:46 · Discussion Needed, Affects-Wikimedia

Dec 14 2023

20after4 added a subtask for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge: T15694: Consider adopting the "search results context highlighting" feature from Wikimedia's fork.
Dec 14 2023, 17:33 · Discussion Needed, Affects-Wikimedia
20after4 updated the task description for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Dec 14 2023, 17:32 · Discussion Needed, Affects-Wikimedia
20after4 added a comment to T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.

Here's another one that I think deserves to be upstreamed: https://phabricator.wikimedia.org/T230787 adds context and search term highlights to fulltext search results. Currently Phorge and upstream Phabricator only show matching document titles with highlights on keywords in the title but not the body.
The efficiency of my solution is questionable, however, it's working well enough for Wikimedia's use of the feature.

Dec 14 2023, 17:04 · Discussion Needed, Affects-Wikimedia

Dec 8 2023

soloturn added a comment to T15100: [Feature request] Option to measure WIP limits based on card count instead of points, to more closely adhere to Kanban standards..

there is a presentation from eric brechner, who was in microsofts xbox development, about kanban. he does it on whiteboard, extremely sinple:
https://www.youtube.com/watch?v=CD0y-aU1sXo

Dec 8 2023, 08:17 · Feature Requests, Maniphest, Discussion Needed, Affects-Wikimedia, Workboard

Dec 7 2023

valerio.bozzolan updated the task description for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Dec 7 2023, 10:33 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan added a subtask for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge: T15688: "Undefined index: PHID-PROJ-***" in project.search API when project_customfieldstorage table has additional fields not requested.
Dec 7 2023, 10:32 · Discussion Needed, Affects-Wikimedia

Dec 6 2023

aklapper closed T15686: Include 'published' date in Phame atom feeds, a subtask of T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge, as Resolved.
Dec 6 2023, 19:34 · Discussion Needed, Affects-Wikimedia
aklapper closed T15686: Include 'published' date in Phame atom feeds as Resolved by committing rP6c8329fb6614: Include 'published' date of posts in Phame Atom feeds.
Dec 6 2023, 19:34 · Affects-Wikimedia, Feature Requests
valerio.bozzolan added a project to T15686: Include 'published' date in Phame atom feeds: Affects-Wikimedia.
Dec 6 2023, 06:28 · Affects-Wikimedia, Feature Requests
valerio.bozzolan updated the task description for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Dec 6 2023, 06:21 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan added a subtask for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge: T15686: Include 'published' date in Phame atom feeds.
Dec 6 2023, 06:21 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan moved T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge from Backlog to Discussion Needed on the Affects-Wikimedia board.
Dec 6 2023, 06:20 · Discussion Needed, Affects-Wikimedia

Nov 23 2023

valerio.bozzolan updated the task description for T15055: Import translations from translatewiki.net.
Nov 23 2023, 06:23 · Affects-Wikimedia, Phorge

Nov 22 2023

pppery added a comment to T15055: Import translations from translatewiki.net.

Translatewiki finally processed the rebrand a few days ago, as part of https://phabricator.wikimedia.org/T318763

Nov 22 2023, 16:54 · Affects-Wikimedia, Phorge
valerio.bozzolan closed T15674: Image Transforms should reflect policy of parent Image, a subtask of T15163: The Task Cover Image is visible only to the uploader (invisible to Task participants), as Invalid.
Nov 22 2023, 13:08 · Affects-Wikimedia, Maniphest, User-valerio.bozzolan, Cover Image, Workboard

Nov 20 2023

aklapper added a comment to T15055: Import translations from translatewiki.net.

Probably this was moved?

Nov 20 2023, 12:44 · Affects-Wikimedia, Phorge
valerio.bozzolan added a project to T15055: Import translations from translatewiki.net: Affects-Wikimedia.

Cool. Two things:

Nov 20 2023, 11:12 · Affects-Wikimedia, Phorge
valerio.bozzolan added a comment to T15125: Unknown edge constant "26"! when deleting a file with old attachment edges.

Other edges have probably been eliminated in the past. For example this one:

Nov 20 2023, 10:17 · Affects-Wikimedia, Files, Bug Reports
valerio.bozzolan moved T15163: The Task Cover Image is visible only to the uploader (invisible to Task participants) from Code Sprint Candidate to PingDeath 🌚 on the User-valerio.bozzolan board.
Nov 20 2023, 09:09 · Affects-Wikimedia, Maniphest, User-valerio.bozzolan, Cover Image, Workboard
valerio.bozzolan added a revision to T15163: The Task Cover Image is visible only to the uploader (invisible to Task participants): D25475: Drag & Drop Task Cover Image: also attach.
Nov 20 2023, 09:06 · Affects-Wikimedia, Maniphest, User-valerio.bozzolan, Cover Image, Workboard
valerio.bozzolan claimed T15163: The Task Cover Image is visible only to the uploader (invisible to Task participants).
Nov 20 2023, 08:54 · Affects-Wikimedia, Maniphest, User-valerio.bozzolan, Cover Image, Workboard

Nov 16 2023

aklapper closed T15646: Renaming several Pholio Mockup images creates neverending daemon task (PhutilProxyException due to Array to string conversion) as Resolved by committing rPf42dd5819e98: Fix possible array to string conversion renaming Pholio Mockup image.
Nov 16 2023, 09:42 · Affects-Wikimedia, Bug Reports

Nov 13 2023

valerio.bozzolan added a comment to T15646: Renaming several Pholio Mockup images creates neverending daemon task (PhutilProxyException due to Array to string conversion).

Interestingly I was able to reproduce the issue with this nonsense patch, in the hope to emulate an email plain-text generation, even if it's not the case:

Nov 13 2023, 17:12 · Affects-Wikimedia, Bug Reports
valerio.bozzolan added a comment to T15646: Renaming several Pholio Mockup images creates neverending daemon task (PhutilProxyException due to Array to string conversion).

For interesting reasons, I cannot, in any way, get an email about somebody renaming a single Mockup photo. And, my email preferences are like "email me for everything from every application" and email delivery is "email me about myself".

Nov 13 2023, 17:10 · Affects-Wikimedia, Bug Reports

Nov 7 2023

aklapper added a comment to T15650: AphrontDuplicateKeyQueryException dragging task from milestone column to main board column: Duplicate entry for key 'boardPHID'.

Initially, the task is in the project's default column:

MariaDB [phabricator_project]> SELECT cp.id, p.name AS projectName, cp.boardPHID, c.name AS columnName, cp.columnPHID FROM project_columnposition cp INNER JOIN project_column c ON cp.columnPHID = c.phid INNER JOIN phabricator_project.project p ON cp.boardPHID = p.phid WHERE objectPHID ="PHID-TASK-f6ri2kdpcvtb3yncho2n";
+-----+----------------+--------------------------------+------------+--------------------------------+
| id  | projectName    | boardPHID                      | columnName | columnPHID                     |
+-----+----------------+--------------------------------+------------+--------------------------------+
| 509 | T139396-parent | PHID-PROJ-yt43plz2cxlidyu4dlia | Backloggg  | PHID-PCOL-no7jbin6vngwkrghrmrk |
+-----+----------------+--------------------------------+------------+--------------------------------+
Nov 7 2023, 23:00 · Affects-Wikimedia, Bug Reports

Oct 25 2023

valerio.bozzolan closed T15619: Calendar: Impossible to import .ics file (Phorge checks for a non-existing remote URI) as Resolved by committing rP629fa368cb9a: Calendar: fix creation of ICS Files.
Oct 25 2023, 17:09 · Affects-Wikimedia, Bug Reports, Calendar

Oct 24 2023

20after4 added a comment to T15653: Prefilled tag in task form opened from workboard column deletes any project tags defined by form.

Yeah so we are all for "let's just append as default and maybe think about something more for the future, if they ask"

Oct 24 2023, 16:34 · Affects-Wikimedia, Bug Reports
valerio.bozzolan added a comment to T15653: Prefilled tag in task form opened from workboard column deletes any project tags defined by form.

Yeah so we are all for "let's just append as default and maybe think about something more for the future, if they ask"

Oct 24 2023, 14:24 · Affects-Wikimedia, Bug Reports
20after4 added a comment to T15653: Prefilled tag in task form opened from workboard column deletes any project tags defined by form.

What if it were possible to intentionally remove a tag by passing the tag prepended with - to signify removal? like ?tags=-ABCDE to remove a tag but otherwise the behavior would be to just append. I realize this doesn't have the same compatibility advantages but it does offer slightly more flexibility for use in ad-hoc workflows.

Oct 24 2023, 13:54 · Affects-Wikimedia, Bug Reports