Page MenuHomePhorge

Fix wrong argument count in numerous calls' signatures
Needs ReviewPublic

Authored by aklapper on Sun, Apr 27, 16:17.

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Summary

Fix incorrect method/function argument counts which are trivial:

  • /src/applications/config/controller/PhabricatorConfigController.php:13 Method PhabricatorFile::getBestURI() invoked with 1 parameter, 0 required.
  • /src/applications/conpherence/controller/ConpherenceListController.php:135 Method ConpherenceController::buildHeaderPaneContent() invoked with 2 parameters, 1 required.
  • /src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php:74 Method PhutilContextFreeGrammar::generate() invoked with 2 parameters, 0 required.
  • /src/applications/differential/storage/DifferentialChangeset.php:589 Method LiskDAO::makeEphemeral() invoked with 1 parameter, 0 required.
  • /src/applications/diffusion/management/DiffusionRepositorySubversionManagementPanel.php:59 Method DiffusionRepositoryManagementPanel::newCurtainView() invoked with 1 parameter, 0 required.
  • /src/applications/diffusion/xaction/DiffusionCommitAuditTransaction.php:123 Method PhabricatorRepositoryCommit::hasAuditAuthority() invoked with 3 parameters, 2 required.
  • /src/applications/harbormaster/storage/build/HarbormasterBuildArtifact.php:165 Method HarbormasterBuildArtifact::releaseArtifact() invoked with 1 parameter, 0 required.
  • /src/applications/repository/engine/PhabricatorRepositoryPullEngine.php:457 Method PhabricatorRepository::getFetchRules() invoked with 1 parameter, 0 required.
  • /src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php:67 Method PhabricatorConpherenceProfileMenuItem::getConpherence() invoked with 1 parameter, 0 required.
    • /src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php:104 Method PhabricatorConpherenceProfileMenuItem::getConpherence() invoked with 1 parameter, 0 required.
  • /src/applications/search/query/PhabricatorSearchDocumentQuery.php:52 Static method PhabricatorSearchService::newResultSet() invoked with 2 parameters, 1 required.
  • /src/infrastructure/cluster/search/PhabricatorElasticsearchHost.php:78 Method PhabricatorFulltextStorageEngine::indexIsSane() invoked with 1 parameter, 0 required.
  • /src/infrastructure/editor/PhabricatorEditorURIEngine.php:71 Method PhabricatorEditorURIEngine::getURITokensForRepository() invoked with 1 parameter, 0 required.
  • /src/infrastructure/editor/PhabricatorEditorURIEngine.php:84 Method PhabricatorEditorURIEngine::getURITokensForRepository() invoked with 1 parameter, 0 required.
Test Plan

Look up function/method definitions, compare with their calls. Run static code analysis.

Diff Detail

Repository
rP Phorge
Branch
argCounts (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1897
Build 1897: arc lint + arc unit