Page MenuHomePhorge
Feed All Stories

Today

valerio.bozzolan accepted D25865: Allow filtering tokens given by list of token.

(Don't worry, I'm also super confused by arc now. lol - it still does not apply cleanly to me, so I've downloaded the patch...)

Wed, Feb 5, 17:36
valerio.bozzolan updated the summary of D25865: Allow filtering tokens given by list of token.
Wed, Feb 5, 17:34
taavi added a comment to D25865: Allow filtering tokens given by list of token.

Maybe we need to rebase on top of 7955fe6df701 (I don't have the base af404703cbe9 locally)

Wed, Feb 5, 17:26
taavi updated the diff for D25865: Allow filtering tokens given by list of token.

Rebase

Wed, Feb 5, 17:25
valerio.bozzolan added a comment to D25865: Allow filtering tokens given by list of token.

Maybe we need to rebase on top of 7955fe6df701 (I don't have the base af404703cbe9 locally)

Wed, Feb 5, 16:43
taavi requested review of D25865: Allow filtering tokens given by list of token.
Wed, Feb 5, 16:24
taavi added a revision to T15988: Allow filtering tokens given by list of token: D25865: Allow filtering tokens given by list of token.
Wed, Feb 5, 16:24 · Feature Requests
valerio.bozzolan updated the test plan for D25863: Convert tokens given to use SearchEngine.
Wed, Feb 5, 16:07
valerio.bozzolan accepted D25863: Convert tokens given to use SearchEngine.

Thaaanks taavi! Known non-issue: somebody may wonder why in Maniphest the "Queries" are listed before other things. I may answer that in Phame the "Queries" are listed after other things. So this is consistent with Phame /phame/post/ page. lol

Wed, Feb 5, 16:04
valerio.bozzolan updated the test plan for D25863: Convert tokens given to use SearchEngine.
Wed, Feb 5, 16:03
valerio.bozzolan updated the summary of D25863: Convert tokens given to use SearchEngine.
Wed, Feb 5, 15:58
taavi added a comment to D25863: Convert tokens given to use SearchEngine.

If you want to easily try that missing piece I can add it with a little cute amend (keeping your authorship). We can always rollback the patch if you don't like the result or if it creates a nuclear weapon. Sounds OK?

Wed, Feb 5, 15:32
taavi updated the diff for D25863: Convert tokens given to use SearchEngine.

Add searches to navigation menu

Wed, Feb 5, 15:31
aklapper retitled D25864: Allow copying previous milestone's description when creating a new milestone from Allow pasting previous milestone's description when creating a new milestone
Wed, Feb 5, 13:45
aklapper updated the diff for D25835: Strip surrounding whitespace from project and task titles.

Yeah that makes sense, thanks!

Wed, Feb 5, 13:16 · Projects, Maniphest
aklapper updated the task description for T15991: When creating a new project milestone, allow inserting the description of the previous milestone.
Wed, Feb 5, 13:06 · Feature Requests
aklapper requested review of D25864: Allow copying previous milestone's description when creating a new milestone.
Wed, Feb 5, 12:16
aklapper added a revision to T15991: When creating a new project milestone, allow inserting the description of the previous milestone: D25864: Allow copying previous milestone's description when creating a new milestone.
Wed, Feb 5, 12:16 · Feature Requests
aklapper created T15991: When creating a new project milestone, allow inserting the description of the previous milestone.
Wed, Feb 5, 11:26 · Feature Requests
valerio.bozzolan added a comment to D25863: Convert tokens given to use SearchEngine.

If you want to easily try that missing piece I can add it with a little cute amend (keeping your authorship). We can always rollback the patch if you don't like the result or if it creates a nuclear weapon. Sounds OK?

Wed, Feb 5, 08:06

Yesterday

valerio.bozzolan added a comment to D25863: Convert tokens given to use SearchEngine.

OK probably just this is missing

Tue, Feb 4, 13:58
valerio.bozzolan added a comment to D25863: Convert tokens given to use SearchEngine.

It works on my computer but I see that in the left sidebar usually there is "Queries" 🤔 instead it seems to work for ManiphestController and similar ones

Tue, Feb 4, 13:54
valerio.bozzolan updated the test plan for D25863: Convert tokens given to use SearchEngine.
Tue, Feb 4, 13:51
Cigaryno added a project to T15990: ERROR 8192: exit(): Passing null to parameter #1 ($status) of type string|int is deprecated at [arcanist/src/parser/argument/PhutilArgumentParser.php:494]: Arcanist.
Tue, Feb 4, 13:51 · Arcanist, Bug Reports
Cigaryno removed 3 auditor(s) for rP42234d56e5a4: Remove unused PhabricatorApplicationTransactionCommentView::getStatusID(): Remarkup, DeepClone (Extension), Extension Development.
Tue, Feb 4, 13:50
valerio.bozzolan added inline comments to D25776: Remove unused newNoMenuItemsView() function.
Tue, Feb 4, 13:27 · Dashboards
taavi created T15990: ERROR 8192: exit(): Passing null to parameter #1 ($status) of type string|int is deprecated at [arcanist/src/parser/argument/PhutilArgumentParser.php:494].
Tue, Feb 4, 13:14 · Arcanist, Bug Reports
taavi requested review of D25863: Convert tokens given to use SearchEngine.
Tue, Feb 4, 13:11
taavi added a revision to T15988: Allow filtering tokens given by list of token: D25863: Convert tokens given to use SearchEngine.
Tue, Feb 4, 13:11 · Feature Requests
valerio.bozzolan triaged T15989: `arc unit`: Constant E_STRICT is deprecated (with PHP 8.4) as Normal priority.

Welcome PHP 8.4

Tue, Feb 4, 12:39 · PHP 8 support, Bug Reports
taavi created T15989: `arc unit`: Constant E_STRICT is deprecated (with PHP 8.4).
Tue, Feb 4, 12:32 · PHP 8 support, Bug Reports
valerio.bozzolan awarded T15988: Allow filtering tokens given by list of token a Like token.
Tue, Feb 4, 12:00 · Feature Requests
valerio.bozzolan added a comment to T15988: Allow filtering tokens given by list of token.

(Additional context: as follow-up request, the most adopted token MUST always be "fox" or "🦊", forever - even if not available. So maybe the implementation is a bit simpler and efficient 👍 lol)

Tue, Feb 4, 11:55 · Feature Requests
taavi created T15988: Allow filtering tokens given by list of token.
Tue, Feb 4, 11:51 · Feature Requests

Mon, Feb 3

aklapper edited the content of Next Up.
Mon, Feb 3, 20:55
aklapper edited the content of Next Up.
Mon, Feb 3, 20:48
aklapper closed T15890: Workboard: better clarify if it's Archived, a subtask of T15886: Archived Projects: make them "more Archived" , as Resolved.
Mon, Feb 3, 17:57 · Projects
aklapper closed D25774: Strike through archived projects in navigation crumbs.
Mon, Feb 3, 17:57 · Projects
aklapper closed T15890: Workboard: better clarify if it's Archived as Resolved by committing rP0bd838868422: Strike through archived projects in navigation crumbs.
Mon, Feb 3, 17:57 · UX, Projects
aklapper committed rP0bd838868422: Strike through archived projects in navigation crumbs.
Strike through archived projects in navigation crumbs
Mon, Feb 3, 17:57
aklapper updated the diff for D25774: Strike through archived projects in navigation crumbs.
  • rebase again
Mon, Feb 3, 17:55 · Projects
valerio.bozzolan accepted D25774: Strike through archived projects in navigation crumbs.

Double slam-sgtm

Mon, Feb 3, 17:25 · Projects
aklapper updated the diff for D25774: Strike through archived projects in navigation crumbs.

./bin/celerity/map

Mon, Feb 3, 11:13 · Projects
aklapper closed D25862: Communicate max dimensions of profile images before upload.
Mon, Feb 3, 10:53
aklapper closed T15984: Communicate maximum dimensions of avatar images as Resolved by committing rP6facee6140ea: Communicate max dimensions of profile images before upload.
Mon, Feb 3, 10:53 · Projects
aklapper committed rP6facee6140ea: Communicate max dimensions of profile images before upload.
Communicate max dimensions of profile images before upload
Mon, Feb 3, 10:53
aklapper retitled D25776: Remove unused newNoMenuItemsView() function from Fix newEmptyView() parameters in PhabricatorDashboardPortalProfileMenuEngine
Mon, Feb 3, 10:50 · Dashboards
aklapper updated the diff for D25776: Remove unused newNoMenuItemsView() function.

Remove newNoMenuItemsView() instead

Mon, Feb 3, 10:49 · Dashboards
aklapper retitled D25776: Remove unused newNoMenuItemsView() function from Fix newEmptyView() parameters in PhabricatorDashboardPortalProfileMenuEngine
Mon, Feb 3, 10:49 · Dashboards
aklapper added inline comments to D25776: Remove unused newNoMenuItemsView() function.
Mon, Feb 3, 10:46 · Dashboards
aklapper closed T15895: PhabricatorCustomField::readValueFromObject() should not return $this as Resolved by committing rPaaff2415f981: Fix incorrect return value of PhabricatorCustomField::readValueFromObject().
Mon, Feb 3, 09:40
aklapper closed D25751: Fix incorrect return value of PhabricatorCustomField::readValueFromObject().
Mon, Feb 3, 09:40
aklapper committed rPaaff2415f981: Fix incorrect return value of PhabricatorCustomField::readValueFromObject().
Fix incorrect return value of PhabricatorCustomField::readValueFromObject()
Mon, Feb 3, 09:40
reet- updated the question details for Q167: Personal Herald rule for repository activity.
Mon, Feb 3, 09:20 · Herald
reet- asked Q167: Personal Herald rule for repository activity.
Mon, Feb 3, 09:17 · Herald
avivey added a comment to T15987: Preview for patch files.

https://secure.phabricator.com/T13105 is the relevant historical meta-task, I didn't find a matching one here.

Mon, Feb 3, 08:14 · Files
Tgr created T15987: Preview for patch files.
Mon, Feb 3, 08:00 · Files
valerio.bozzolan updated the test plan for D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.
Mon, Feb 3, 08:00 · Remarkup
valerio.bozzolan requested changes to D25776: Remove unused newNoMenuItemsView() function.
Mon, Feb 3, 08:00 · Dashboards
valerio.bozzolan updated the diff for D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.

add little cute comment and newline, to make it clear that the comment belongs only to that line, and really nothing else lol

Mon, Feb 3, 08:00 · Remarkup
valerio.bozzolan accepted D25751: Fix incorrect return value of PhabricatorCustomField::readValueFromObject().

Makes sense looking at

Mon, Feb 3, 08:00
mainframe98 requested changes to D25772: Projects: improve quality of destroy workflow.

I find the current iteration too difficult to read, although that may be partially caused by the mutual language barrier.

Mon, Feb 3, 08:00 · Projects
valerio.bozzolan accepted D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.

It works on my computer. Thaaaanks \o/

Mon, Feb 3, 08:00 · Remarkup

Sun, Feb 2

waldyrious awarded T15701: Clarify that a Project is just a "Tag" a Like token.
Sun, Feb 2, 20:43 · UX, Projects
waldyrious awarded T15504: If registration is disabled, show the button as disabled a Like token.
Sun, Feb 2, 20:25 · Auth, Good Starter Task, UX
Arkus404 edited 4 auditor(s) for rP42234d56e5a4: Remove unused PhabricatorApplicationTransactionCommentView::getStatusID(), removed 1: Arkus404; added 3: Extension Development, DeepClone (Extension), Remarkup.
Sun, Feb 2, 00:04

Sat, Feb 1

Arkus404 awarded rP42234d56e5a4: Remove unused PhabricatorApplicationTransactionCommentView::getStatusID() a Cup of Joe token.
Sat, Feb 1, 23:51
Arkus404 added 1 auditor(s) for rP42234d56e5a4: Remove unused PhabricatorApplicationTransactionCommentView::getStatusID(): Arkus404.
Sat, Feb 1, 23:50

Fri, Jan 31

tusooa asked Q166: Support for request header and body in "Make HTTP Request" step in Harbormaster.
Fri, Jan 31, 02:48 · Almanac/Drydock/Harbormaster
amybones added a comment to T15982: Update the documentation for "Adding New CSS and JS" to not exclude extensions.

A comment in two parts:
First and most relevant to this task: It certainly would be nice to get some of this into documentation! It took me quite awhile to figure this out when doing my own extension development.

Fri, Jan 31, 01:42 · Extension Development, Documentation

Sun, Jan 26

mainframe98 accepted D25535: T15011: Update support for XHPast on Windows.

Took some fiddling with VS2022 to find exactly what I needed to install, but worked like a charm afterwards.

Sun, Jan 26, 13:29

Sat, Jan 25

Cigaryno updated the task description for T15128: Differential: Allow to change "Default Edit Policy".
Sat, Jan 25, 19:23 · Spam mitigation, Policy, Differential, User-Cigaryno
Cigaryno updated the task description for T15128: Differential: Allow to change "Default Edit Policy".
Sat, Jan 25, 18:51 · Spam mitigation, Policy, Differential, User-Cigaryno
Cigaryno updated Cigaryno.
Sat, Jan 25, 18:44
Cigaryno updated Cigaryno.
Sat, Jan 25, 18:44
IamMin updated IamMin.
Sat, Jan 25, 04:53

Fri, Jan 24

Cigaryno moved T15450: Configure another Ponder Question status "Closed, Graduated" from Feature Requests to Bug Reports on the Ponder board.
Fri, Jan 24, 16:29 · Feature Requests, Ponder, phorge.it install
Cigaryno added a project to T15171: Ponder: add "Hide" button on your answer: Feature Requests.
Fri, Jan 24, 16:18 · Feature Requests, Ponder, User-valerio.bozzolan
Cigaryno moved T15985: Fix UX regression in Phame from Backlog to UX & Mobile on the Bug Reports board.
Fri, Jan 24, 16:13 · Phame, Bug Reports, UX
Cigaryno added a project to T15812: Double escaped text when adding an auth provider: Auth.
Fri, Jan 24, 16:12 · Auth, Bug Reports
Cigaryno moved T15985: Fix UX regression in Phame from Backlog to Bug Reports on the Phame board.
Fri, Jan 24, 08:11 · Phame, Bug Reports, UX
Cigaryno added a project to T15985: Fix UX regression in Phame: Phame.
Fri, Jan 24, 08:10 · Phame, Bug Reports, UX
xmain123 added a comment to T15043: Automatically move tasks between columns on project boards.

the vsts has a good workboard experience for this feature, it supply the mapping setting for the board relationship.

Fri, Jan 24, 06:08 · Feature Requests, Workboard

Thu, Jan 23

aklapper added a comment to T15985: Fix UX regression in Phame.

Uhm, right. A quick fix would be removing the margin-left: 300px; CSS rule for div.phui-document-content-outer.

Thu, Jan 23, 11:48 · Phame, Bug Reports, UX
aklapper updated the task description for T15986: Consider disabling unread notification count in page title.
Thu, Jan 23, 07:59
aklapper created T15986: Consider disabling unread notification count in page title.
Thu, Jan 23, 07:57

Wed, Jan 22

valerio.bozzolan edited the content of Next Up.
Wed, Jan 22, 11:41
valerio.bozzolan added a comment to T15985: Fix UX regression in Phame.

Decreasing priority since this happens only if you have not any posts.

Wed, Jan 22, 11:38 · Phame, Bug Reports, UX
valerio.bozzolan lowered the priority of T15985: Fix UX regression in Phame from High to Normal.
Wed, Jan 22, 11:38 · Phame, Bug Reports, UX
valerio.bozzolan edited the content of Next Up.
Wed, Jan 22, 11:30
valerio.bozzolan placed T15985: Fix UX regression in Phame up for grabs.

(Sorry @mturdus I didn't want to assign this to you. It was automatically assigned by sub-task.)

Wed, Jan 22, 11:28 · Phame, Bug Reports, UX
valerio.bozzolan created T15985: Fix UX regression in Phame.
Wed, Jan 22, 11:27 · Phame, Bug Reports, UX
valerio.bozzolan accepted D25862: Communicate max dimensions of profile images before upload.

It works on my computer \o/ thanks

Wed, Jan 22, 07:42
valerio.bozzolan updated the diff for D25862: Communicate max dimensions of profile images before upload.

fix PhabricatorPeopleProfilePictureController and PhabricatorProjectEditPictureController,
thanks to generic "transform" stuff from PhabricatorFileTransform

Wed, Jan 22, 07:33
valerio.bozzolan added a comment to D25862: Communicate max dimensions of profile images before upload.

Hoping to be useful I will amend to fix 2 new errors caused by my suggestion.

Wed, Jan 22, 07:31
valerio.bozzolan added a comment to D25862: Communicate max dimensions of profile images before upload.

Ouch the non-static method raised an error. I'm investigating a possible fix to keep this non-static approach in the next 20 minutes

Wed, Jan 22, 07:19

Tue, Jan 21

aklapper updated the diff for D25862: Communicate max dimensions of profile images before upload.

Do not use consts but keep the two pixel values defined in getMaxTransformDimensions(), make function non-static

Tue, Jan 21, 19:01
avivey added inline comments to D25862: Communicate max dimensions of profile images before upload.
Tue, Jan 21, 08:33