Page MenuHomePhorge
Feed All Stories

Jun 26 2023

valerio.bozzolan created Clarification Needed.
Jun 26 2023, 14:31
valerio.bozzolan added a comment to T15501: Voluntary Usage Survey App.

Premising that a CLI script could be not enough, probably better a frontend button so to be able to know if it's mod_php or PHP-fpm etc.

Jun 26 2023, 14:16 · Discussion Needed
jbo added a comment to T15501: Voluntary Usage Survey App.

Personally, I'd be willing to manually fill out a survey. I'd heavily oppose anything that phones home in any capacity.
An app/script which generates some report which can be manually copy-pasted sounds reasonable.

Jun 26 2023, 13:41 · Discussion Needed
valerio.bozzolan updated the summary of D25308: Dashboard Tabs: render "Move" buttons grayed out more consistently.
Jun 26 2023, 13:10
aklapper closed D25311: Fix typo "recipeint" in metamta.one-mail-per-recipient description.
Jun 26 2023, 12:28
aklapper committed rPe4fe54edf0d3: Fix typo "recipeint" in metamta.one-mail-per-recipient description.
Fix typo "recipeint" in metamta.one-mail-per-recipient description
Jun 26 2023, 12:28
valerio.bozzolan accepted D25311: Fix typo "recipeint" in metamta.one-mail-per-recipient description.

Laaks guud ta me :)

Jun 26 2023, 12:20
aklapper requested review of D25311: Fix typo "recipeint" in metamta.one-mail-per-recipient description.
Jun 26 2023, 12:19
valerio.bozzolan updated valerio.bozzolan.
Jun 26 2023, 11:48
valerio.bozzolan added a comment to T15501: Voluntary Usage Survey App.

Uhm. Maybe we can create a script or a frontend button to auto-answer most of these questions.

Jun 26 2023, 11:21 · Discussion Needed
valerio.bozzolan added inline comments to D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 26 2023, 11:01
aklapper closed T15335: PHP 8.1 null parameter exceptions block rendering the "Browse Projects" overlay dialog, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 26 2023, 10:44 · PHP 8 support
aklapper closed T15335: PHP 8.1 null parameter exceptions block rendering the "Browse Projects" overlay dialog as Resolved.
Jun 26 2023, 10:44 · Arcanist, PHP 8 support
valerio.bozzolan added inline comments to D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 26 2023, 10:34
valerio.bozzolan updated the test plan for D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 26 2023, 10:33
valerio.bozzolan updated the diff for D25299: Remarkup Code-block: parse language specifier in markdown.

add comments to answer questions

Jun 26 2023, 10:29
avivey added inline comments to D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 26 2023, 10:02
valerio.bozzolan added inline comments to D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 26 2023, 09:47
avivey updated the task description for T15481: Support language highlighting for GitHub+StackOverflow+GitLab "Flavored Markdown" code blocks.
Jun 26 2023, 08:59 · Feature Requests, Remarkup
avivey added a comment to D25299: Remarkup Code-block: parse language specifier in markdown.
  1. It's not called "Flavored Markdown" - that's not a complete name. It's either "XXX-flavored markdown" or just "markdown".
  2. Fix the test plan in the description.
  3. what's the deal with the footer? What does it do?
Jun 26 2023, 08:55
valerio.bozzolan updated the diff for D25299: Remarkup Code-block: parse language specifier in markdown.

fix lint 81 lines...

Jun 26 2023, 08:34
valerio.bozzolan updated the diff for D25299: Remarkup Code-block: parse language specifier in markdown.

declare $matches = null;

Jun 26 2023, 08:30
valerio.bozzolan updated the summary of D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 26 2023, 08:18
valerio.bozzolan retitled D25299: Remarkup Code-block: parse language specifier in markdown from Remarkup Code-block: Parse "GitHub-Flavored-Markdown" language specifier to Remarkup Code-block: Parse "Flavored Markdown" language specifier.
Jun 26 2023, 08:16

Jun 25 2023

valerio.bozzolan added a comment to D25299: Remarkup Code-block: parse language specifier in markdown.

I have a better feeling now. Thanks for your suggestions

Jun 25 2023, 21:55
valerio.bozzolan updated the diff for D25299: Remarkup Code-block: parse language specifier in markdown.

even more strict

Jun 25 2023, 21:52
valerio.bozzolan updated the diff for D25299: Remarkup Code-block: parse language specifier in markdown.

be 70% more strict, and implement an allow-list of very important languages

Jun 25 2023, 21:32
valerio.bozzolan added inline comments to D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 25 2023, 19:48
avivey added inline comments to D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 25 2023, 19:44
valerio.bozzolan added inline comments to D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 25 2023, 19:42
avivey added a comment to Q64: File editor extension: updating PhabricatorFile content (Answer 81).

To create a DB, you need to add a class like this one to your app:

Jun 25 2023, 14:18
mturdus added a comment to Q64: File editor extension: updating PhabricatorFile content (Answer 81).

Yes, this was indeed the answer I was afraid of...

Jun 25 2023, 13:42
avivey created T15501: Voluntary Usage Survey App.
Jun 25 2023, 11:33 · Discussion Needed
avivey added inline comments to D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 25 2023, 11:11
aklapper requested review of D25310: Fix PHP 8.1 "strlen(null)" exception opening a File overlay (Lightbox comment frame).
Jun 25 2023, 10:32
aklapper added a revision to T15498: PHP 8.2 "strlen(null)" exception when viewing image details: D25310: Fix PHP 8.1 "strlen(null)" exception opening a File overlay (Lightbox comment frame).
Jun 25 2023, 10:32 · Files, PHP 8 support
valerio.bozzolan added inline comments to D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 25 2023, 09:52
golyalpha added a comment to T15486: Do not expose "Contact Numbers" in user settings when no SMS support is set up in Phorge.

I'd expect that a user's contact numbers might show up on their profile to other registered users. I suspect this might be something that upstream considered implementing at some point but never did for some reason...

Jun 25 2023, 09:39 · Policy
avivey added inline comments to D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 25 2023, 09:32
valerio.bozzolan added inline comments to D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 25 2023, 09:21
valerio.bozzolan renamed T15481: Support language highlighting for GitHub+StackOverflow+GitLab "Flavored Markdown" code blocks from Support language highlighting for GitHub+GitLab "Flavored Markdown" code blocks to Support language highlighting for GitHub+GitLab+StackOverflow "Flavored Markdown" code blocks.
Jun 25 2023, 09:18 · Feature Requests, Remarkup
valerio.bozzolan updated the name of F314240: StackOverflow eating first line.png from "Screenshot_2023_06_25_111655.png" to "StackOverflow eating first line.png".
Jun 25 2023, 09:18
valerio.bozzolan updated the diff for D25299: Remarkup Code-block: parse language specifier in markdown.

Mention T15500

Jun 25 2023, 09:07
valerio.bozzolan created T15500: Improve Remarkup unit tests to always trigger the .txt checks.
Jun 25 2023, 09:04 · Phorge Development Tools, Remarkup
valerio.bozzolan added a comment to T15481: Support language highlighting for GitHub+StackOverflow+GitLab "Flavored Markdown" code blocks.

Interestingly, Remarkup allowed too many things, so this Task cannot be 99.99999% safe.

Jun 25 2023, 09:02 · Feature Requests, Remarkup
avivey added a comment to D25299: Remarkup Code-block: parse language specifier in markdown.
  • update the test plan
Jun 25 2023, 09:00
valerio.bozzolan updated the task description for T15481: Support language highlighting for GitHub+StackOverflow+GitLab "Flavored Markdown" code blocks.
Jun 25 2023, 08:56 · Feature Requests, Remarkup
valerio.bozzolan updated the diff for D25299: Remarkup Code-block: parse language specifier in markdown.

add unit tests, and force execution

Jun 25 2023, 08:48
valerio.bozzolan updated the answer details for Q64: File editor extension: updating PhabricatorFile content (Answer 82).
Jun 25 2023, 07:35
valerio.bozzolan added a comment to Q64: File editor extension: updating PhabricatorFile content.

By the way it could be a good thing to save versions as "different files".

Jun 25 2023, 07:34
valerio.bozzolan added Q64: File editor extension: updating PhabricatorFile content (Answer 82).
Jun 25 2023, 07:34
valerio.bozzolan awarded Q64: File editor extension: updating PhabricatorFile content a Love token.
Jun 25 2023, 07:33
avivey added Q64: File editor extension: updating PhabricatorFile content (Answer 81).
Jun 25 2023, 07:16
mturdus asked Q64: File editor extension: updating PhabricatorFile content.
Jun 25 2023, 07:02
mturdus created T15499: PHP 8.2 "strlen(null)" exception when executing Conduit file.allocate.
Jun 25 2023, 05:57 · Conduit, PHP 8 support
mturdus created T15498: PHP 8.2 "strlen(null)" exception when viewing image details.
Jun 25 2023, 05:41 · Files, PHP 8 support

Jun 24 2023

valerio.bozzolan added a comment to D25299: Remarkup Code-block: parse language specifier in markdown.

Interestingly, whatever fancy stuff I put inside the file tick-block-multi-flavored-markdown.txt, the unit test from arc unit is always green to me :(

Jun 24 2023, 20:25
valerio.bozzolan updated the diff for D25299: Remarkup Code-block: parse language specifier in markdown.

rename a variable, add a unit test file

Jun 24 2023, 20:23
valerio.bozzolan updated the summary of D25299: Remarkup Code-block: parse language specifier in markdown.
Jun 24 2023, 20:05
valerio.bozzolan updated the task description for T15481: Support language highlighting for GitHub+StackOverflow+GitLab "Flavored Markdown" code blocks.
Jun 24 2023, 20:03 · Feature Requests, Remarkup
chris accepted D25309: Fix `arc browse` for php 8.x.
Jun 24 2023, 19:42
avivey requested review of D25309: Fix `arc browse` for php 8.x.
Jun 24 2023, 19:25
avivey added a revision to T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4: D25309: Fix `arc browse` for php 8.x.
Jun 24 2023, 19:25 · PHP 8 support
avivey planned changes to D25275: fix strlen in PhabricatorMailManagementShowOutboundWorkflow.
Jun 24 2023, 19:22 · PHP 8 support
avivey assigned T15485: error when running arc liberate after deleting a source file to goddenrich.
Jun 24 2023, 18:21 · Arcanist, Bug Reports
ton committed R4:b82028194a47: subcommand: add fetch|upload subcommand.
subcommand: add fetch|upload subcommand
Jun 24 2023, 15:38
ton committed R4:5f020f639a7c: fix: correct bugphest name in Cargo.lock.
fix: correct bugphest name in Cargo.lock
Jun 24 2023, 15:38
avivey edited the content of Change Log.
Jun 24 2023, 15:32
ton committed R4:8d98a7351c2e: fix: correct bugphest name in top-level Cargo.toml.
fix: correct bugphest name in top-level Cargo.toml
Jun 24 2023, 14:44
ton committed R4:37cf7232f7ae: readme: list workspaces in the repo.
readme: list workspaces in the repo
Jun 24 2023, 14:42
ton committed R4:593ce3f17e5e: first commit on phorge.
first commit on phorge
Jun 24 2023, 14:36
avivey reopened T15059: Phabricator doesn't email @outlook.com addresses as "Open".

It's an infra issue, but it's our infra :(

Jun 24 2023, 13:42 · phorge.it install
avivey requested changes to D25303: Implements a more informative hovercard for wiki documents.

Formally "requesting changes", but only for the inline SQL code. Everything else I said is just "a suggestion".

Jun 24 2023, 13:35
avivey added a comment to D25303: Implements a more informative hovercard for wiki documents.

Showing project tags might be unique to tasks - Revisions don't show them, and neither do Owners or Commits. It might make sense not to show it here either.

Jun 24 2023, 13:34
bekay added a comment to D25303: Implements a more informative hovercard for wiki documents.

Fixed the indentation and @valerio.bozzolan should now see the breadcrumb. But even if all else fails, at least Wiki Document will be rendered...

Jun 24 2023, 11:25
bekay updated the diff for D25303: Implements a more informative hovercard for wiki documents.

Builds celerity map.

Jun 24 2023, 11:23
bekay updated the diff for D25303: Implements a more informative hovercard for wiki documents.

Fixes missing ancestors and css indentation.

Jun 24 2023, 11:22
avivey retitled D25299: Remarkup Code-block: parse language specifier in markdown from Remarkup: add support to code blocks in "GitHub/GitLab Flavored Markdown" to Remarkup Code-block: Parse "GitHub-Flavored-Markdown" language specifier.
Jun 24 2023, 09:31
avivey added a comment to D25299: Remarkup Code-block: parse language specifier in markdown.
  1. Please move the "what is GHFM" chapters into the task.
  2. I'm updating the title to be more descriptive of the change itself.
  3. Instead of manually testing, add test elements into src/infrastructure/markup/remarkup/__tests__/remarkup/
Jun 24 2023, 09:31
valerio.bozzolan updated the diff for D25305: Workboard: have thin scrollbars.

run tests

Jun 24 2023, 09:13
valerio.bozzolan updated the task description for T15143: Allow to quick-edit a Milestone name from Workboard menu.
Jun 24 2023, 09:11 · UX, Affects-Wikimedia, User-valerio.bozzolan, Workboard
valerio.bozzolan updated the summary of D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages).
Jun 24 2023, 09:11
avivey added a comment to T15485: error when running arc liberate after deleting a source file.

I'm unable to reproduce:
I've deleted a file in arcanist library, and ran arc liberate. I got no error message and the __phutil_library_map__.php was updated correctly.

Jun 24 2023, 09:10 · Arcanist, Bug Reports
valerio.bozzolan changed the visibility for F314015: D25066.mp4.
Jun 24 2023, 09:09
avivey added a comment to T15470: Include user email address in Conduit output when query is run by admin.

For completeness, my arguments against this:

Jun 24 2023, 09:04 · Conduit, Discussion Needed, Feature Requests
valerio.bozzolan updated the diff for D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages).

move a variable in a nicer position

Jun 24 2023, 08:34
valerio.bozzolan updated the summary of D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages).
Jun 24 2023, 08:33
valerio.bozzolan updated the name of F314008: Milestone menu before.png from "image.png" to "Milestone menu before.png".
Jun 24 2023, 08:26
valerio.bozzolan updated the name of F314005: Milestone quick editable name.png from "image.png" to "Milestone quick editable name.png".
Jun 24 2023, 08:23
avivey edited the content of 2023 Week 23.
Jun 24 2023, 07:11
avivey committed rP52be52d429ce: Promote 2023.23 to Stable.
Promote 2023.23 to Stable
Jun 24 2023, 07:11
avivey committed rARCc2cd19e14cd8: Promote 2023.23 to Stable.
Promote 2023.23 to Stable
Jun 24 2023, 07:07

Jun 23 2023

bekay added inline comments to D25303: Implements a more informative hovercard for wiki documents.
Jun 23 2023, 20:18
speck added a comment to D25303: Implements a more informative hovercard for wiki documents.

Code-wise this looks good, though I’m not overly familiar with CSS or how Phorge uses it. Ready to accept after the empty icon thing is resolved.

Jun 23 2023, 19:51
speck added a comment to D25303: Implements a more informative hovercard for wiki documents.

This looks great! Thank you for working on it.

Jun 23 2023, 19:47
bekay added a comment to D25303: Implements a more informative hovercard for wiki documents.

Nice!

I don't have any idea about the homepage, but having no parents leave the icon alone in a row now, to me:

Home test.png (239×402 px, 28 KB)

Jun 23 2023, 19:34
valerio.bozzolan added a comment to D25303: Implements a more informative hovercard for wiki documents.

I don't have any idea about the homepage, but having no parents leave the icon alone in a row now, to me:

Jun 23 2023, 19:24
valerio.bozzolan updated the name of F313622: Home test.png from "image.png" to "Home test.png".
Jun 23 2023, 19:24
bekay added a comment to D25303: Implements a more informative hovercard for wiki documents.

@speck Did that!

Jun 23 2023, 19:05
bekay updated the task description for T15497: Exception when viewing incoming Chat room messages, when not in Participants.
Jun 23 2023, 19:01 · Conpherence