Restored the previous selectors, added some code comments to try to explain better why I wrote them this way. I hope this clarifies things. Thanks!
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Aug 19 2023
Aug 19 2023
aklapper updated the test plan for D25415: Make InterpreterBlockRule regex only match on valid interpreter names.
aklapper added a comment to T15372: "RuntimeException: Undefined array key" when pasting "a {{{a}}} a" comment (due to regex in PhutilRemarkupInterpreterBlockRule.php).
FYI I proposed a partial patch in D25415 which makes the issue more contained at least.
aklapper requested review of D25415: Make InterpreterBlockRule regex only match on valid interpreter names.
valerio.bozzolan added a comment to T15619: Calendar: Impossible to import .ics file (Phorge checks for a non-existing remote URI).
I've invested 8 minutes in this and I'm somehow confused about the possible cause and solution :)
aklapper closed T15620: PHP 8.1 "strlen(null)" exceptions importing ICS file into calendar, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
aklapper committed rP9b105c8e9e54: Fix PHP 8.1 "strlen(null)" exceptions importing ICS file into calendar.
Fix PHP 8.1 "strlen(null)" exceptions importing ICS file into calendar
add noreferrer for privacy reasons
taavi renamed Wikimania Hackathon 2023 Singapore from Wikimania Hackaton 2023 Singapore to Wikimania Hackathon 2023 Singapore.
avivey closed T15621: PHP 8.2: Diviner's Phorge Technical Documentation not accessible, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
avivey closed T15621: PHP 8.2: Diviner's Phorge Technical Documentation not accessible as Resolved by committing rPba4b8cb1ae7d: PHP 8 and Diviner Technical Documentation.
PHP 8 and Diviner Technical Documentation
valerio.bozzolan attached a referenced file: F312321: Screenshot 2023-06-20 at 07-27-41 Editing-team (Kanban Board) · Workboard.png.
valerio.bozzolan attached a referenced file: F312323: Screenshot 2023-06-20 at 07-32-20 Editing-team (Kanban Board) · Workboard.png.
valerio.bozzolan added a comment to D25390: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists.
Thanks my friend
You are a good minion, thanks bob
I will kindly resign since I'm terrible at frontend :) Others: please help here
For faster review I would like to try to explain better to others why it was necessary to change so many selectors to change the Workboards scrollbar, but I'm not 100% sure about .phui-flank-view-body and the shadow thing.
valerio.bozzolan added a comment to D25400: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Can somebody else test this? I need more time, since I have issues with hosted repositories at the moment :(
valerio.bozzolan retitled D25400: Fix a PHP 8.1 deprecated use of strlen with a NULL argument from Fix a PHP 8.1/8.2 deprecated use of strlen with a NULL argument
valerio.bozzolan accepted D25411: Fix PHP 8.1 "strlen(null)" exceptions importing ICS file into calendar.
Thanks! Tested locally. This seems separated from the mentioned regression. Indeed the recurrence ID and the instance ISO seems that must be strings, or NULL, and any other value will cause a violent nuclear implosion as usual, and Phorge somehow likes it.
valerio.bozzolan triaged T15619: Calendar: Impossible to import .ics file (Phorge checks for a non-existing remote URI) as Normal priority.
Interesting. ICS URI import was fixed in 02a4f8b0c8f1279fc but at the cost of breaking ICS file import.
valerio.bozzolan retitled D25413: Show a link to the Phorge homepage from Show a link to the Phorge homepage
It seems we were missing a link to the project homepage.
Also we set the language of the HTML document.
Tested both cases, thanks
Aug 18 2023
Aug 18 2023
mturdus triaged T15621: PHP 8.2: Diviner's Phorge Technical Documentation not accessible as High priority.
aklapper requested review of D25411: Fix PHP 8.1 "strlen(null)" exceptions importing ICS file into calendar.
aklapper added a reverting change for D25061: Fix editing a Calendar import ICS URI: D25411: Fix PHP 8.1 "strlen(null)" exceptions importing ICS file into calendar.
aklapper added a comment to T15619: Calendar: Impossible to import .ics file (Phorge checks for a non-existing remote URI).
I confirm that there is no problem after running git revert 02a4f8b0c8f1279fc0040ad8077942fd8b0d948b.
valerio.bozzolan committed rP3cc5ee6a33df: Documentation: fix unexisting path sshd_config.phabricator.example.
Documentation: fix unexisting path sshd_config.phabricator.example
Sten closed T15617: arc patch fails when binary files are added/removed with PHP 8.1 strlen(null), a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Fix PHP 8.1 arc patch strlen(null) binary file error
Fix a PHP 8.1 deprecated use of strlen with a NULL argument
Looks good to me.
valerio.bozzolan retitled D25398: Fix a PHP 8.1 deprecated use of strlen with a NULL argument from Fix a PHP 8.1/8.2 deprecated use of strlen with a NULL argument
valerio.bozzolan added inline comments to D25410: Documentation: fix unexisting path sshd_config.phabricator.example.
valerio.bozzolan retitled D25410: Documentation: fix unexisting path sshd_config.phabricator.example from Documentation: fix unexisting path sshd_config.phabricator.example
Since the example file was renamed, this change makes the documentation consistent with it.
Also we added exactly one-space somewhere, to create a super-satisfying indentation
in...
Ouch ! Thanks for reporting ! I'll have a look on UI examples (these pages are really cool !) to improve the proposal !
BTW, I'll be away next week so... This will not move forward right now...
Fix a PHP 8.1 deprecated use of strlen with a NULL argument
Great, let's prepare for landing ! BTW, I like your images, espacially this one...
Yeah anyway this looks great
In D25409#11652, @avivey wrote:I think phutil_nonempty_string fails faster then strlen (strlen allowing automatic conversion of string-like things to string and phutil_nonempty_string doesn't), but I'm a little confused right now...
Switch to using phutil_nonempty_string
SUPER NICE \o/ THANKS
Tested with and without D25387.
I think phutil_nonempty_string fails faster then strlen (strlen allowing automatic conversion of string-like things to string and phutil_nonempty_string doesn't), but I'm a little confused right now...
Sten updated the task description for T15617: arc patch fails when binary files are added/removed with PHP 8.1 strlen(null).
In D25409#11648, @avivey wrote:phutil_nonempty_string is basically the exact same thing, but with stricter type control
phutil_nonempty_string is basically the exact same thing, but with stricter type control
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0