Query: Advanced Search

	Include stories about projects I am a member of.

Nah, LC_ALL=C won't change anything. (My system is already in variants of English.)

Mark string as translatable

In D26060#28141, @valerio.bozzolan wrote:
P.S. why is your local unit test failing?

Cannot reproduce:
arc unit src/parser/__tests__/ArcanistBundleTestCase.php

aaaand now, as I was mumbling aloud, maybe super-nice to move the $xform = definition out the foreach, so, we can move this up

(extra extra bonus bonus point: once it's up, we can find the $xform only if it's necessary)

I'm still clueless if this could be more optimized somehow given my lack of understanding of the thumbnail software stack. Just saying.

A rather boring git rebase master with no particular exciting new features

Darrn, I also wanted to accept this but somehow closed this tab. Sorry :D

After applying this patch, phpstan throws a bunch of additional output here, like Class PhabricatorAuthPasswordQuery extends generic class PhabricatorCursorPagedPolicyAwareQuery but does not specify its types: R and such. Probably that is totally fine. Just saying, as a phpstan newbie.

Put minus icon back in

Pasting full unit test output here before garbage collection kicks in:

Assertion failed, expected values to be equal (at PhutilSearchQueryCompilerTestCase.php:303): Function compilation of query: cat title:="Meow Meow"
Expected vs Actual Output Diff
--- Old Value
+++ New Value
@@ -1,18 +1 @@
-Array
-(
-    [0] => Array
-        (
-            [0] => 
-            [1] => and
-            [2] => cat
-        )
-
-    [1] => Array
-        (
-            [0] => title
-            [1] => exact
-            [2] => Meow Meow
-        )
-
-)
-
+false

Go to http://phorge.localhost/search/query/advanced/
In the Query field enter z a a "a phrase" a a a a ~a -b =foo title:u which includes duplicate values
Click Search button

Don't output "1 Terms" but "x Term(s)"

Hi and welcome, thanks for bringing this up! I guess you could Edit Question and change the View Policy of this Ponder Question to either "Trusted Contributors", or something more restrictive via the "Custom Policy" option, like administrators and subscribers, or such.

Hi, please explain specifically what "support for large monitors" means to you.
Large monitors are "supported" as all the content on a Phorge page is correctly displayed, layouted, readable on large monitors, as your screenshot proves. :)

Hi, could you please describe actual problems due to the current layout? Free space is not an issue per-se, for example limiting the content width makes sense.
I'm also a bit wondering why you would put/use the browser full screen when having such a ratio?

diff --git a/src/view/phui/PHUIObjectBoxView.php b/src/view/phui/PHUIObjectBoxView.php
index dce9d57568..13a0a3d061 100644
--- a/src/view/phui/PHUIObjectBoxView.php
+++ b/src/view/phui/PHUIObjectBoxView.php
@@ -318,6 +318,10 @@ final class PHUIObjectBoxView extends AphrontTagView {
       $lists,
       $this->table,
       $pager,
+      // When the anchor link scrolled us below the $showhide search parameters
+      // box, repeat the error message hidden and unseen at the top of the page
+      ($this->showHideOpen == true ? $this->formErrors : null),
       $this->renderChildren(),
     );

^ This would simply be ugly repeating of the error message below the search params box on http://phorge.localhost/maniphest/query/advanced/.
For testing the patch behavior with a results list, replace the line
($this->showHideOpen == true ? $this->formErrors : null),
with
($this->showHideOpen == true ? $header : null),

Advanced Search
Use Results
Edit Query
Hide Query

Thu, Jun 5

Wed, Jun 4

Tue, Jun 3

Mon, Jun 2

Sun, Jun 1

Advanced SearchUse ResultsEdit QueryHide Query