Page MenuHomePhorge

a11y: Set aria-label for comment action options dropdown
AcceptedPublic

Authored by aklapper on Sun, Jun 1, 11:39.

Details

Summary

Forms should have a label per https://dequeuniversity.com/rules/axe/4.10/link-select.
This is not the case for the <select> element above the comment field which has "Add Action..." as its first option which is created via id(new AphrontFormSelectControl()) in PhabricatorApplicationTransactionCommentView. Add an aria-label attribute for screenreader use.

Ref T16072

Test Plan

Diff Detail

Repository
rP Phorge
Branch
a11y-T16072-08 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2041
Build 2041: arc lint + arc unit