Page MenuHomePhorge
Feed Advanced Search

Jul 1 2024

valerio.bozzolan added a comment to D25709: Fix missing file attachment in Conpherence.

To avoid that $xactions[0] we should probably find the desired transaction.

Jul 1 2024, 12:30
valerio.bozzolan removed a revision from T15106: "Upload file" in remarkup text fields should attach by default : D25710: [STUB] Fix missing file attachment in Conpherence.
Jul 1 2024, 12:14Files, Remarkup
valerio.bozzolan added a revision to T15106: "Upload file" in remarkup text fields should attach by default : D25710: [STUB] Fix missing file attachment in Conpherence.
Jul 1 2024, 12:07Files, Remarkup
valerio.bozzolan foisted D25709: Fix missing file attachment in Conpherence upon mturdus.
Jul 1 2024, 11:58
valerio.bozzolan requested review of D25709: Fix missing file attachment in Conpherence.
Jul 1 2024, 11:58
valerio.bozzolan added a revision to T15106: "Upload file" in remarkup text fields should attach by default : D25709: Fix missing file attachment in Conpherence.
Jul 1 2024, 11:58Files, Remarkup
valerio.bozzolan accepted D25705: Fix missing file attachment in Phriction.

Thanks my friend, this works perfectly

Jul 1 2024, 09:31
valerio.bozzolan retitled D25705: Fix missing file attachment in Phriction from Fix file attachment in Phriction and Conpherence
Jul 1 2024, 09:30
valerio.bozzolan updated the summary of D25705: Fix missing file attachment in Phriction.
Jul 1 2024, 09:30
valerio.bozzolan updated the diff for D25705: Fix missing file attachment in Phriction.

we can remove an undeclared variable, and add a nonempty-str check

Jul 1 2024, 09:29
valerio.bozzolan updated the diff for D25705: Fix missing file attachment in Phriction.

dedicating Conpherence its own diff as mturdus requested

Jul 1 2024, 09:24
valerio.bozzolan updated the task description for T15744: Render html color codes in remarkup.
Jul 1 2024, 07:00Discussion Needed, Remarkup
valerio.bozzolan added a comment to T15744: Render html color codes in remarkup.

I think GitHub allows that syntax only in comments 馃

Jul 1 2024, 06:50Discussion Needed, Remarkup

Jun 30 2024

valerio.bozzolan added a comment to D25705: Fix missing file attachment in Phriction.

OK try this to restore your desired situation (so, two diffs)

Jun 30 2024, 20:04
valerio.bozzolan updated the task description for T15872: Understand how to defuse localization in GNU Gettext.
Jun 30 2024, 19:27Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan added inline comments to D25691: Fix arc diff in Subversion for non-English languages.
Jun 30 2024, 19:23
valerio.bozzolan created T15872: Understand how to defuse localization in GNU Gettext.
Jun 30 2024, 19:21Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan updated the diff for D25691: Fix arc diff in Subversion for non-English languages.

OK, I think we have something mathematical and bombproof

Jun 30 2024, 18:06
valerio.bozzolan updated the diff for D25691: Fix arc diff in Subversion for non-English languages.

add even more useful links

Jun 30 2024, 17:29
valerio.bozzolan added a comment to D25691: Fix arc diff in Subversion for non-English languages.

I must read this:

Jun 30 2024, 17:21
valerio.bozzolan accepted D25707: Fix typo in CSS definition.

Papa Beaver's Storytime done. Thanks

Jun 30 2024, 17:17
valerio.bozzolan added a comment to D25705: Fix missing file attachment in Phriction.

Well, to be honest, feel free to generalize the description and commit message to include both changes, since they are the very same thing

Jun 30 2024, 17:13
valerio.bozzolan added a comment to D25705: Fix missing file attachment in Phriction.

(Do you need a little help to split the changes in two diffs?)

Jun 30 2024, 17:12
valerio.bozzolan added a comment to D25691: Fix arc diff in Subversion for non-English languages.

Thanks again. I've found this interesting, so, added in the code itself:

Jun 30 2024, 13:46
valerio.bozzolan updated the diff for D25691: Fix arc diff in Subversion for non-English languages.

improvement thanks to dear @l2dy

Jun 30 2024, 13:33
valerio.bozzolan added a comment to T15744: Render html color codes in remarkup.

Thanks again @20after4 for the efforts.

Jun 30 2024, 13:23Discussion Needed, Remarkup
valerio.bozzolan added inline comments to D25705: Fix missing file attachment in Phriction.
Jun 30 2024, 13:17
valerio.bozzolan added a project to T15744: Render html color codes in remarkup: Discussion Needed.
Jun 30 2024, 13:14Discussion Needed, Remarkup
valerio.bozzolan updated the task description for T15871: Remarkup rule to show colors.
Jun 30 2024, 13:13
valerio.bozzolan merged T15871: Remarkup rule to show colors into T15744: Render html color codes in remarkup.
Jun 30 2024, 13:12Discussion Needed, Remarkup
valerio.bozzolan merged task T15871: Remarkup rule to show colors into T15744: Render html color codes in remarkup.
Jun 30 2024, 13:12
valerio.bozzolan updated the task description for T15744: Render html color codes in remarkup.
Jun 30 2024, 13:12Discussion Needed, Remarkup
valerio.bozzolan updated the summary of D25607: Add docs for color code formatting.
Jun 30 2024, 13:09Documentation
valerio.bozzolan added a revision to T15871: Remarkup rule to show colors: D25607: Add docs for color code formatting.
Jun 30 2024, 13:09
valerio.bozzolan requested changes to D25607: Add docs for color code formatting.

This documentation is nice but unfortunately the feature introduced in 4d12d014fd9d never worked :( So documenting this as-is may create confusion, at the moment. Next steps:

Jun 30 2024, 13:08Documentation
valerio.bozzolan created T15871: Remarkup rule to show colors.
Jun 30 2024, 13:07
valerio.bozzolan added inline comments to D25705: Fix missing file attachment in Phriction.
Jun 30 2024, 11:59
valerio.bozzolan added inline comments to D25705: Fix missing file attachment in Phriction.
Jun 30 2024, 11:57
valerio.bozzolan added a comment to D25705: Fix missing file attachment in Phriction.

Wow 馃槏 looks promising (untested from my side)

Jun 30 2024, 11:55

Jun 28 2024

valerio.bozzolan added a comment to D25672: Allow collapsing/expanding workboard column content by clicking its header.

About the cursor: pointer;, yep it would be super-nice, but no need to create distinctions between mobile and desktop for that probably 馃 let's always show it.

Jun 28 2024, 15:47
valerio.bozzolan awarded D25672: Allow collapsing/expanding workboard column content by clicking its header a Yellow Medal token.
Jun 28 2024, 15:35
valerio.bozzolan added a comment to D25672: Allow collapsing/expanding workboard column content by clicking its header.

Premising that as web developer I'm really super surprised to have never seen in my life a native <summary> + <detail>, even in demos 馃 I've never seen it in basic online courses for beginners ( https://www.w3schools.com/howto/howto_js_collapsible.asp ) - and that's surprising since there it would be nice; not in online forums with super-basic "spoiler" features (e.g. https://www.minecraftforum.net/forums/forums/forum-discussion-info/514283-how-do-i-make-spoilers-on-the-forum ) and there it would be nice, not in Bootstrap and not in MaterializeCSS (and it would be nice to have examples there to save some JavaScript); not in MediaWiki (because there, "esoteric" tags are disabled; so, since the beginning, every single wiki in the planet has 10 lines of JavaScript in their Common.js), etc.

Jun 28 2024, 15:26
valerio.bozzolan updated the task description for T15870: Provide documentation for Javelin scry, find, and findAbove.
Jun 28 2024, 14:48User-valerio.bozzolan, Documentation
valerio.bozzolan created T15870: Provide documentation for Javelin scry, find, and findAbove.
Jun 28 2024, 14:41User-valerio.bozzolan, Documentation
valerio.bozzolan added a comment to D25672: Allow collapsing/expanding workboard column content by clicking its header.

(About my "like Wikipedia" I mean https://en.wikipedia.org/wiki/Template:Hidden )

Jun 28 2024, 12:39
valerio.bozzolan added a comment to D25672: Allow collapsing/expanding workboard column content by clicking its header.

To have this a bit more flexible we should probably toggle visibility by JavaScript. (So, we can keep divs, and this makes the change also a bit more backward compatible probably)

Jun 28 2024, 12:38
valerio.bozzolan added a comment to T15804: Imbalanced AphrontWriteGuard: more beginUnguardedWrites() calls than endUnguardedWrites() calls.

I do not understand if we have some race conditions, or, if the __destruct() is not properly called because of a bug in PHP 8.3.8, which is possible but unlikely

Jun 28 2024, 12:20
valerio.bozzolan requested changes to D25618: Avoid search exception for calendar events when using localized time formats.

Visually marking this as "ongoing discussion for code changes" to keep historically nice error messages

Jun 28 2024, 11:40Calendar
valerio.bozzolan added a comment to D25672: Allow collapsing/expanding workboard column content by clicking its header.

I love this collapsible on mobile since it saves a lot of scrolls, but I think the collapsible on desktop can just add confusion without clear benefits (since the desktop layout is not vertical, and saving vertical space does not help in showing more information). Probably this should only apply on .device-tablet and .device-phone, but not .device-desktop

Jun 28 2024, 11:36
valerio.bozzolan updated the test plan for D25688: Fix broken URIs on "Rendering HTML" Diviner page.
Jun 28 2024, 11:29
valerio.bozzolan accepted D25688: Fix broken URIs on "Rendering HTML" Diviner page.

It makes sense since these are Phorge stuff, not Arcanist stuff. Thanks.

Jun 28 2024, 11:29
valerio.bozzolan accepted D25636: Fix exception awarding empty badge to user.

Agree with your considerations and tested 馃寛

Jun 28 2024, 11:18

Jun 27 2024

valerio.bozzolan updated the answer details for Q135: Files larger than 8MB fails to upload for some S3-compatible apis using upload form at /file/upload (but works using Drag & Drop) (Answer 173).
Jun 27 2024, 15:45
valerio.bozzolan closed Q133: Tags instead of subtypes as resolved.
Jun 27 2024, 15:43phorge.it install
valerio.bozzolan added a comment to Q133: Tags instead of subtypes (Answer 166).

Maybe in the future. At the moment it's just an extra unnecessary configuration.

Jun 27 2024, 15:43
valerio.bozzolan added a comment to Q135: Files larger than 8MB fails to upload for some S3-compatible apis using upload form at /file/upload (but works using Drag & Drop).

I see you marked this question as Resolved. Was it?

Jun 27 2024, 15:41
valerio.bozzolan reopened Q135: Files larger than 8MB fails to upload for some S3-compatible apis using upload form at /file/upload (but works using Drag & Drop).
Jun 27 2024, 15:41
valerio.bozzolan updated the question details for Q135: Files larger than 8MB fails to upload for some S3-compatible apis using upload form at /file/upload (but works using Drag & Drop).
Jun 27 2024, 15:41
valerio.bozzolan marked Q135: Files larger than 8MB fails to upload for some S3-compatible apis using upload form at /file/upload (but works using Drag & Drop) (Answer 169) as hidden.
Jun 27 2024, 15:40
valerio.bozzolan updated the answer details for Q135: Files larger than 8MB fails to upload for some S3-compatible apis using upload form at /file/upload (but works using Drag & Drop) (Answer 173).
Jun 27 2024, 15:39
valerio.bozzolan updated the answer details for Q135: Files larger than 8MB fails to upload for some S3-compatible apis using upload form at /file/upload (but works using Drag & Drop) (Answer 173).
Jun 27 2024, 15:37
valerio.bozzolan updated the answer details for Q135: Files larger than 8MB fails to upload for some S3-compatible apis using upload form at /file/upload (but works using Drag & Drop) (Answer 173).
Jun 27 2024, 15:36
valerio.bozzolan updated the answer details for Q135: Files larger than 8MB fails to upload for some S3-compatible apis using upload form at /file/upload (but works using Drag & Drop) (Answer 173).
Jun 27 2024, 15:35
valerio.bozzolan added Q135: Files larger than 8MB fails to upload for some S3-compatible apis using upload form at /file/upload (but works using Drag & Drop) (Answer 173).
Jun 27 2024, 15:34
valerio.bozzolan updated Q135: Files larger than 8MB fails to upload for some S3-compatible apis using upload form at /file/upload (but works using Drag & Drop) from Files larger than 8MB fails to upload for some S3-compatible apis? to Files larger than 8MB fails to upload for some S3-compatible apis using upload form at /file/upload (but works using Drag & Drop).
Jun 27 2024, 15:06
valerio.bozzolan awarded rP72a6ff69fcda: Add blah a The World Burns token.
Jun 27 2024, 11:37
valerio.bozzolan added a comment to D25703: Fix PHP 8.1 "trim(null)" exception when creating a diff with an empty "Differential Revision:" field.

somewhere before the this

Jun 27 2024, 10:38
valerio.bozzolan accepted D25702: Do not link "here" but use a descriptive link text.

click

Jun 27 2024, 07:31

Jun 26 2024

valerio.bozzolan closed T15867: Fix legacy crash on Motivator backend from anonymous as Resolved by committing rP8825a09f676a: Fix legacy crash when visiting Motivator backend as anon.
Jun 26 2024, 21:26Bug Reports
valerio.bozzolan closed D25700: Fix legacy crash when visiting Motivator backend as anon.
Jun 26 2024, 21:26
valerio.bozzolan committed rP8825a09f676a: Fix legacy crash when visiting Motivator backend as anon.
Fix legacy crash when visiting Motivator backend as anon
Jun 26 2024, 21:25
valerio.bozzolan added a comment to D25700: Fix legacy crash when visiting Motivator backend as anon.

whatcouldgowrong

Jun 26 2024, 21:15
valerio.bozzolan requested review of D25700: Fix legacy crash when visiting Motivator backend as anon.
Jun 26 2024, 21:10
valerio.bozzolan added a revision to T15867: Fix legacy crash on Motivator backend from anonymous: D25700: Fix legacy crash when visiting Motivator backend as anon.
Jun 26 2024, 21:10Bug Reports
valerio.bozzolan claimed T15867: Fix legacy crash on Motivator backend from anonymous.
Jun 26 2024, 21:08Bug Reports
valerio.bozzolan created T15867: Fix legacy crash on Motivator backend from anonymous.
Jun 26 2024, 21:08Bug Reports
valerio.bozzolan added a comment to D25698: Make the Remarkup Help Page Extensible.

I love this at unbelievable level, thanks all 馃寛

Jun 26 2024, 21:01
valerio.bozzolan added a comment to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.

After 15 minutes of reading stuff around on the web, I think we need a little help. Waiting for answers (and waiting for downvotes lol).

Jun 26 2024, 09:12

Jun 25 2024

valerio.bozzolan edited the content of Next Up.
Jun 25 2024, 12:46
valerio.bozzolan edited the content of Next Up.
Jun 25 2024, 07:54
valerio.bozzolan changed the visibility for F2243121: Phorge closed as duplicate comment.png.
Jun 25 2024, 07:50
valerio.bozzolan closed D25675: Drydock and Almanac: add welcome pages.
Jun 25 2024, 07:40
valerio.bozzolan committed rP68762e820417: Drydock and Almanac: add welcome pages.
Drydock and Almanac: add welcome pages
Jun 25 2024, 07:40
valerio.bozzolan updated the summary of D25675: Drydock and Almanac: add welcome pages.
Jun 25 2024, 07:39
valerio.bozzolan changed the visibility for F2243112: Phorge Almanac Devices welcome.png.
Jun 25 2024, 07:38
valerio.bozzolan changed the visibility for F2243111: Phorge Almanac Networks welcome.png.
Jun 25 2024, 07:38
valerio.bozzolan changed the visibility for F2243110: Phorge Almanac Services welcome.png.
Jun 25 2024, 07:37
valerio.bozzolan changed the visibility for F2243109: Phorge Drydock Blueprints welcome.jpg.
Jun 25 2024, 07:37
valerio.bozzolan awarded D25698: Make the Remarkup Help Page Extensible a Yellow Medal token.
Jun 25 2024, 07:21
valerio.bozzolan added inline comments to D25698: Make the Remarkup Help Page Extensible.
Jun 25 2024, 07:21

Jun 23 2024

valerio.bozzolan added a comment to D25697: Run celerity map after rP1fa8c79b1ef86a9edda575b582b18fa24d60ea1f.

This might (or should be) covered by the unit tests

Jun 23 2024, 17:19
valerio.bozzolan updated the task description for T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file.
Jun 23 2024, 17:16Phorge Development Tools, Arcanist, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file.
Jun 23 2024, 17:12Phorge Development Tools, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a comment to D25643: Remove unused methods in PhabricatorEditorExtension.

Feel free to kill this method violently 馃棥 since as you said this is protected (no external usages) + final (no overrides) and visibly broken since 5 years

Jun 23 2024, 17:06
valerio.bozzolan added a comment to T15285: It's damn difficult to type a "Thumb Up" emojii.

Partially related, it's damn easy to type a dagger "馃棥" since it appears by typing :D ... lol

Jun 23 2024, 17:06

Jun 21 2024

valerio.bozzolan updated the summary of D25691: Fix arc diff in Subversion for non-English languages.
Jun 21 2024, 14:49
valerio.bozzolan updated the task description for T15855: Fix "arc diff" in Subversion for non-English languages.
Jun 21 2024, 14:46Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan added a comment to D25691: Fix arc diff in Subversion for non-English languages.

Any chance to share the related stacktrace?

Jun 21 2024, 14:35
valerio.bozzolan added a comment to D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.

What if $cdn has some evil characters? Do we have some escaping

Jun 21 2024, 00:12

Jun 20 2024

valerio.bozzolan added inline comments to D25051: Destroy file attachments when file is deleted, or object is deleted.
Jun 20 2024, 23:39Files