I mean, it should do exactly that,

Do as Valerio said. Tested before and after, two errors less in PHPStan output.

Eh, there is a trade-off: Editing the description of an existing task to add a @mention will not add this newly mentioned user as a task subscriber anymore.

Make lint happy

Either INVITEED_* is a typo or I don't get what the second E stands for. :)

Not sure what "similar working links" means... Something like https://we.phorge.it/diviner/find/?name=PhutilSafeHTML ?

Is this also the reason why links to e.g. https://we.phorge.it/diviner/find/?name=JX.behavior&type=function&jump=1 on https://we.phorge.it/book/javelin/article/behaviors/ or to http://we.phorge.it/diviner/find/?name=JX.Stratcom&type=class&jump=1 are 404s, or do I misunderstand and that's a separate issue?

Urgh. In calling https://we.phorge.it/source/phorge/browse/master/src/applications/diviner/query/DivinerAtomQuery.php$340 , $this->titles is an array which has a length of 1, with its only member being null. Sounds like there's already something fishy before.

Thanks for finding a way to reproduce! I still fail to find the right timing here to produce a testcase, so this is another untested shot in the dark.

No, as project membership is unrelated to task object policy, as a task can associated to more than one project.

In my installation this would not be a reasonable expectation. We have a public project tag used by a team. Some tasks associated with that public project tag are public tasks visible to everyone and anyone, so they are not in an access-restricted Space but default S1. Some tasks associated with that public project tag are temporarily non-public, "secret" tasks that should only be visible to that team and nobody else, so they are in an access-restricted Space that can only be accessed by team members.
So I'd rather envision a Herald rule: for a Maniphest task, if is newly created is true && Space is Sxx, then add project tag #whatever. (The other way round is not particularly feasible: The task would have a default view setting for a moment and potentially visible to outsiders, before moving it to a view-restricted Space).

Remove unneeded if statements.

In D25764#20704, @valerio.bozzolan wrote:

Thanks. Have you already tried with just CSS? Any issue in that?

Remove typo

This is an issue in https://we.phorge.it/source/phorge/browse/master/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php . In getObjectEmbedPattern(), preg_quote($prefix) returns \# and the method finally returns (\B{\#([^.\s?!,:;{}#\(\)"'\*/~]+(?:[^\s?!,:;{}#\(\)"'\*/~]*[^.\s?!,:;{}#\(\)"'\*/~]+)*)([,\s](?:[^}\\]|\\.)*)?}\B)u.
Within apply($text), $text becomes null after that first preg_replace_callback, so the second call barks.

Create $page_size var to avoid casting twice