Page MenuHomePhorge
Feed Advanced Search

Apr 14 2023

valerio.bozzolan added a revision to T15254: Fix arc patch in PHP 8.2: "preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated": D25123: Fix a PHP 8.1 issue related to preg_match() and null subject.
Apr 14 2023, 14:10 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
Apr 14 2023, 14:09 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan triaged T15254: Fix arc patch in PHP 8.2: "preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated" as High priority.
Apr 14 2023, 14:09 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a revision to T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo): D25123: Fix a PHP 8.1 issue related to preg_match() and null subject.
Apr 14 2023, 14:02 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan renamed T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies from PHP 8.1: strlen() does not accept NULL anymore - understand fix strategies to PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
Apr 14 2023, 13:54 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15253: Commit hook is sometime broken: InvalidArgumentException.
Apr 14 2023, 12:50 · User-valerio.bozzolan, Bug Reports, Arcanist
valerio.bozzolan added a revision to T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies: D25122: Fix InvalidArgumentException on commit hook.
Apr 14 2023, 12:50 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a comment to T15253: Commit hook is sometime broken: InvalidArgumentException.

Let's put another red warning in T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies

Apr 14 2023, 12:50 · User-valerio.bozzolan, Bug Reports, Arcanist
valerio.bozzolan updated the task description for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
Apr 14 2023, 12:49 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a revision to T15253: Commit hook is sometime broken: InvalidArgumentException: D25122: Fix InvalidArgumentException on commit hook.
Apr 14 2023, 12:42 · User-valerio.bozzolan, Bug Reports, Arcanist
valerio.bozzolan triaged T15253: Commit hook is sometime broken: InvalidArgumentException as Unbreak Now! priority.
Apr 14 2023, 12:42 · User-valerio.bozzolan, Bug Reports, Arcanist
ton added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Having been invited to chime in from Q46 I will leave my 2 cents here:

Apr 14 2023, 00:48 · Discussion Needed, Arcanist

Apr 12 2023

Cigaryno added a project to T15244: Arcanist is broken on Subversion when moving a file: Bug Reports.
Apr 12 2023, 16:16 · Bug Reports, Arcanist
avivey added a comment to T15244: Arcanist is broken on Subversion when moving a file.

At least using svn 1.13.0, adding --show-inherited-props to the command doesn't print an error and exits with status 0 from the propget command, but I'm not sure what it actually does.

Apr 12 2023, 11:42 · Bug Reports, Arcanist
valerio.bozzolan added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Indeed. Thanks for cleaning. Having said that "Moving a file" is not a "specific" use-case for Subversion users. That kind of bug is an indicator that probably shows to us that this component is essentially not usable by a majority of Subversion* cases.

Apr 12 2023, 10:32 · Discussion Needed, Arcanist
avivey removed a parent task for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo): T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
Apr 12 2023, 10:28 · PHP 8 support, Arcanist, User-valerio.bozzolan
avivey removed a parent task for T15244: Arcanist is broken on Subversion when moving a file: T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
Apr 12 2023, 10:28 · Bug Reports, Arcanist
avivey removed subtasks for T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues.: T15244: Arcanist is broken on Subversion when moving a file, T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), T15174: Phorge←GitHub: create a bot that imports "Pull requests".
Apr 12 2023, 10:28 · Discussion Needed, Arcanist
avivey added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

@valerio.bozzolan - marking all bugs in Arcanist as subtasks of this task is not helpful. This task is about discussing users not being happy about arcanist; No specific bug or specific broken use-case is actually relevant to having users not want to use it, because in almost all cases users either refuse to even try it (so they are not effected the bug).
Bugs that are found and are causing any discomfort are fixed.

Apr 12 2023, 10:28 · Discussion Needed, Arcanist
valerio.bozzolan added a comment to T15244: Arcanist is broken on Subversion when moving a file.

I put this into a subtask of T15096 since it's obvious to me that, without fixing this problem, users simply cannot use Arcanist with Subversion. We cannot just propose to end-users to do not rename a file.

Apr 12 2023, 09:10 · Bug Reports, Arcanist
valerio.bozzolan triaged T15244: Arcanist is broken on Subversion when moving a file as High priority.
Apr 12 2023, 09:09 · Bug Reports, Arcanist

Apr 8 2023

Cigaryno added a project to T15241: arc tab-complete hangs on some flows: Bug Reports.
Apr 8 2023, 12:06 · Bug Reports, Arcanist
Sten added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Honestly the effort to set up arcanist isn't huge (the flow for setting up your CLI cert couldn't be more perfect and user friendly IMO) and it's all worth it because of the productivity gained by automatic lint fixes, easy patch submission and code review checkouts (arc patch is awesome!)

Apr 8 2023, 10:33 · Discussion Needed, Arcanist
avivey claimed T15241: arc tab-complete hangs on some flows.
Apr 8 2023, 07:37 · Bug Reports, Arcanist

Apr 7 2023

valerio.bozzolan added a comment to T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.

Basically phutil_nonempty_scalar() cannot be used since, instead of returning false when receiving false, it explodes.

Apr 7 2023, 16:46 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a parent task for T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans): T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
Apr 7 2023, 16:45 · User-valerio.bozzolan, Arcanist
valerio.bozzolan added a subtask for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies: T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans).
Apr 7 2023, 16:45 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans).
Apr 7 2023, 16:45 · User-valerio.bozzolan, Arcanist
valerio.bozzolan added a comment to T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans).

I've also a strong opinion about phutil_nonempty_stringlike() that should also not throw an exception on true, but it should consider true as a valid nonempty stringlike since it returns the string 1. And, it should consider false as an empty stringlike.

Apr 7 2023, 16:42 · User-valerio.bozzolan, Arcanist
valerio.bozzolan added a revision to T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans): D25117: phutil_nonempty_scalar(): don't throw when receiving a boolean scalar.
Apr 7 2023, 16:26 · User-valerio.bozzolan, Arcanist
valerio.bozzolan updated the task description for T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans).
Apr 7 2023, 16:22 · User-valerio.bozzolan, Arcanist
valerio.bozzolan updated the task description for T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans).
Apr 7 2023, 16:13 · User-valerio.bozzolan, Arcanist
valerio.bozzolan updated the task description for T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans).
Apr 7 2023, 16:10 · User-valerio.bozzolan, Arcanist
valerio.bozzolan triaged T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans) as Low priority.
Apr 7 2023, 16:05 · User-valerio.bozzolan, Arcanist
valerio.bozzolan added a revision to T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies: D25113: AphrontFileResponse: avoid alien usages of setDownload().
Apr 7 2023, 08:16 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15158: "Modernize" codebase to features available since PHP 5.5 (that is the actual announced minimum).
Apr 7 2023, 08:16 · Phorge, Arcanist, User-valerio.bozzolan

Apr 6 2023

valerio.bozzolan added a project to T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies: Documentation.
Apr 6 2023, 13:14 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
avivey edited projects for T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file, added: Arcanist; removed Celerity.
Apr 6 2023, 11:42 · Phorge Development Tools, Arcanist, User-valerio.bozzolan
avivey edited projects for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), added: PHP 8 support; removed PHP 8.2 support.
Apr 6 2023, 11:34 · PHP 8 support, Arcanist, User-valerio.bozzolan
avivey edited projects for T15188: arc lint: "Function utf8_decode() is deprecated" in PHP 8.2, added: PHP 8 support; removed PHP 8.2 support.
Apr 6 2023, 11:34 · PHP 8 support, Arcanist, User-valerio.bozzolan
avivey edited projects for T15197: arc unit --everything: error "Creation of dynamic property is deprecated", added: PHP 8 support; removed PHP 8.2 support.
Apr 6 2023, 11:33 · PHP 8 support, Arcanist, User-valerio.bozzolan
avivey edited projects for T15222: Fix arc unit--everything in PHP 8.2, added: PHP 8 support; removed PHP 8.2 support.
Apr 6 2023, 11:33 · PHP 8 support, Arcanist, User-valerio.bozzolan
avivey edited projects for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies, added: PHP 8 support; removed PHP 8.1 support (deprecated).
Apr 6 2023, 11:33 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
avivey edited projects for T15158: "Modernize" codebase to features available since PHP 5.5 (that is the actual announced minimum), added: Arcanist; removed Arcanist (archived).
Apr 6 2023, 10:31 · Phorge, Arcanist, User-valerio.bozzolan
avivey edited projects for T15173: Running "arc patch D123" 4 times fails, added: Arcanist; removed Arcanist (archived).
Apr 6 2023, 10:31 · Arcanist, User-valerio.bozzolan
avivey edited projects for T15044: Co-Author support in arc land, added: Arcanist; removed Arcanist (archived).
Apr 6 2023, 10:31 · Arcanist
avivey edited projects for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), added: Arcanist; removed Arcanist (archived).
Apr 6 2023, 10:31 · PHP 8 support, Arcanist, User-valerio.bozzolan
avivey edited projects for T15197: arc unit --everything: error "Creation of dynamic property is deprecated", added: Arcanist; removed Arcanist (archived).
Apr 6 2023, 10:31 · PHP 8 support, Arcanist, User-valerio.bozzolan
avivey edited projects for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies, added: Arcanist; removed Arcanist (archived).
Apr 6 2023, 10:31 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan
avivey edited projects for T15188: arc lint: "Function utf8_decode() is deprecated" in PHP 8.2, added: Arcanist; removed Arcanist (archived).
Apr 6 2023, 10:31 · PHP 8 support, Arcanist, User-valerio.bozzolan
avivey edited projects for T15222: Fix arc unit--everything in PHP 8.2, added: Arcanist; removed Arcanist (archived).
Apr 6 2023, 10:31 · PHP 8 support, Arcanist, User-valerio.bozzolan
avivey edited projects for T15051: default.pem in Arcanist is out of date - maybe remove it completely?, added: Arcanist; removed Arcanist (archived).
Apr 6 2023, 10:31 · Arcanist
avivey edited projects for T15052: Deal with DST_Root_CA_X3 expiry (Let's Encrypt), added: Arcanist; removed Arcanist (archived).
Apr 6 2023, 10:31 · Arcanist
avivey edited projects for T15068: Distribution mechanism for arc extensions, added: Arcanist; removed Arcanist (archived).
Apr 6 2023, 10:31 · Arcanist
avivey edited projects for T15072: Update Python-related linters for modern workflows, added: Arcanist; removed Arcanist (archived).
Apr 6 2023, 10:31 · Arcanist
avivey edited projects for T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues., added: Arcanist; removed Arcanist (archived).
Apr 6 2023, 10:30 · Discussion Needed, Arcanist
avivey edited projects for T15124: arc-browse is broken here, added: Arcanist; removed Arcanist (archived).
Apr 6 2023, 10:30 · Arcanist, phorge.it install
avivey edited projects for T15139: arc edit - util to complete the "edit" button , added: Arcanist; removed Arcanist (archived).
Apr 6 2023, 10:30 · Arcanist
avivey created Arcanist.
Apr 6 2023, 10:29