Let's put another red warning in T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Apr 14 2023
Having been invited to chime in from Q46 I will leave my 2 cents here:
Apr 12 2023
At least using svn 1.13.0, adding --show-inherited-props to the command doesn't print an error and exits with status 0 from the propget command, but I'm not sure what it actually does.
Indeed. Thanks for cleaning. Having said that "Moving a file" is not a "specific" use-case for Subversion users. That kind of bug is an indicator that probably shows to us that this component is essentially not usable by a majority of Subversion* cases.
@valerio.bozzolan - marking all bugs in Arcanist as subtasks of this task is not helpful. This task is about discussing users not being happy about arcanist; No specific bug or specific broken use-case is actually relevant to having users not want to use it, because in almost all cases users either refuse to even try it (so they are not effected the bug).
Bugs that are found and are causing any discomfort are fixed.
I put this into a subtask of T15096 since it's obvious to me that, without fixing this problem, users simply cannot use Arcanist with Subversion. We cannot just propose to end-users to do not rename a file.
Apr 8 2023
In T15096#2230, @20after4 wrote:Honestly the effort to set up arcanist isn't huge (the flow for setting up your CLI cert couldn't be more perfect and user friendly IMO) and it's all worth it because of the productivity gained by automatic lint fixes, easy patch submission and code review checkouts (arc patch is awesome!)
Apr 7 2023
Basically phutil_nonempty_scalar() cannot be used since, instead of returning false when receiving false, it explodes.
I've also a strong opinion about phutil_nonempty_stringlike() that should also not throw an exception on true, but it should consider true as a valid nonempty stringlike since it returns the string 1. And, it should consider false as an empty stringlike.