I think the best extra other than brush your teeth three times a day (which not everyone likes) would be review this agreement every week.

I've set can create to Trusted Contributors for now. I don't see a problem with people being able to create documents.

Currently limited to Trusted Contributors, which is enough as these users can be trusted not to break this install.

Let's mark this as "more hackers needed to escape from rabbit hole" lol

I found a number of Phabricator references in comments and error messages in \phorge\support\startup\PhabricatorStartup.php. See D25857: Replace some Phabricator references in PhabricatorStartup.php on comments and errors.

git clean -fx to hopefully avoid test failure

If the goal is to make it denote "inserted text", I think it should be visually different to "underline" - something more similar to the green we use for actual diff views, maybe more subtle. Will need special handling in the color-blindness themes.

Not a concern but a question: @aklapper why blanking Phortune-related SQL files on \phorge\resources\sql\autopatches instead of completely deleting them?

It returned to function again. Not sure why it wasn't working but good to see it working again.

In T15979#20270, @avivey wrote:

@Cigaryno which browser/OS are you using?

(I cannot reproduce anymore, now I see the very - ugly - native desktop notification of my environment lol; but it's difficult to note since I've configured my computer to disappear after 0.5 seconds - also maybe a common problem I guess)

The "Grant permission" button works for me on Chrome/Windows.

You are totally right, I've never seen native browser notifications too. For some reasons I've always confused Phorge's popup with these since they are quite similar in my environment

In T15979#20265, @valerio.bozzolan wrote:

Is there a possibility that you have a browser extension privacy-focused that automatically denies this permission?

Is there a possibility that you have a browser extension privacy-focused that automatically denies this permission?

Any error in your browser console?

Clicking on Send Test Notification, a notification shows up on the bottom of the screen, but this is totally unrelated to browser notifications.
After clicking on the Grant Permission button:

Can you share a screenshot after you click on that button?

In T15640#19898, @valerio.bozzolan wrote:

Wow. Assuming the line is the one with phutil_nonempty_string($branch), why branch "main" is considered a number?

I think that for the "the name I use is not my legal name" use-case, I'm pretty sure it's fine to use the name that is actually used (because that's what the person is normally known as). It's probably easier to justify accepting a name that is used in real life then "internet handle", but ㄟ( ▔, ▔ )ㄏ

Perhaps we need an interact policy for events?

What do other CLAs do about this?

I'm... honestly not sure, I haven't signed one before. If I had to, I'd ask the maintainers before doing so ^^;

Another related bug is that also referenced/attached files are kept on the old page. Maybe different bug report under same umbrella.

Let's promote to bug :D

The current workaround I'm proposing is just:

In T15121#20192, @BlankEclair wrote:

Would the CLA have to be signed with one's legal name?