Page MenuHomePhorge
Feed All Stories

Yesterday

aklapper added inline comments to D25912: Apply "Can Bulk Edit Tasks" to "Move Tasks" workboard options.
Tue, Mar 25, 16:56
Cigaryno updated the task description for T15490: Uninstalling/Installing an application should eventually involve MFA.
Tue, Mar 25, 14:03 · User-valerio.bozzolan, Security
20after4 awarded D25913: Herald actions: Allow setting subtype on Maniphest tasks a Like token.
Tue, Mar 25, 13:55
aklapper edited the content of Next Up.
Tue, Mar 25, 13:28
aklapper closed D25920: Fix invalid CSS vertical-align value for .fancy-datepicker-core.
Tue, Mar 25, 13:28
aklapper committed rPf62918b019fb: Fix invalid CSS vertical-align value for .fancy-datepicker-core.
Fix invalid CSS vertical-align value for .fancy-datepicker-core
Tue, Mar 25, 13:28
aklapper updated the diff for D25920: Fix invalid CSS vertical-align value for .fancy-datepicker-core.

git rebase master

Tue, Mar 25, 13:27
valerio.bozzolan accepted D25920: Fix invalid CSS vertical-align value for .fancy-datepicker-core.
Tue, Mar 25, 13:24
aklapper edited the content of Next Up.
Tue, Mar 25, 11:38
aklapper closed D25924: Remove invalid CSS border-shadow property for input.jx-tokenizer-input.
Tue, Mar 25, 11:37
aklapper committed rPa8c2bce6fe98: Remove invalid CSS border-shadow property for input.jx-tokenizer-input.
Remove invalid CSS border-shadow property for input.jx-tokenizer-input
Tue, Mar 25, 11:37
aklapper updated the diff for D25924: Remove invalid CSS border-shadow property for input.jx-tokenizer-input.

git rebase master

Tue, Mar 25, 11:37
valerio.bozzolan accepted D25924: Remove invalid CSS border-shadow property for input.jx-tokenizer-input.

sgtm

Tue, Mar 25, 11:18
aklapper edited the content of Next Up.
Tue, Mar 25, 11:03
aklapper closed D25925: Fix invalid CSS border-left-color value for .phabricator-action-view-submenu .caret-right.
Tue, Mar 25, 11:03
aklapper committed rP633d4037e5ac: Fix invalid CSS border-left-color value for .phabricator-action-view-submenu ..
Fix invalid CSS border-left-color value for .phabricator-action-view-submenu .
Tue, Mar 25, 11:03
valerio.bozzolan accepted D25925: Fix invalid CSS border-left-color value for .phabricator-action-view-submenu .caret-right.

sgtm

Tue, Mar 25, 10:56
aklapper requested review of D25925: Fix invalid CSS border-left-color value for .phabricator-action-view-submenu .caret-right.
Tue, Mar 25, 10:07
aklapper requested review of D25924: Remove invalid CSS border-shadow property for input.jx-tokenizer-input.
Tue, Mar 25, 09:56
aklapper edited the content of Next Up.
Tue, Mar 25, 09:41
aklapper edited the content of Next Up.
Tue, Mar 25, 09:35
aklapper closed T16022: Herald: Support setting task subtype action, a subtask of T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge, as Resolved.
Tue, Mar 25, 09:35 · Discussion Needed, Affects-Wikimedia
aklapper closed T16022: Herald: Support setting task subtype action as Resolved by committing rP56797b17ede0: Herald actions: Allow setting subtype on Maniphest tasks.
Tue, Mar 25, 09:35 · Affects-Wikimedia, Herald, Feature Requests
aklapper closed D25913: Herald actions: Allow setting subtype on Maniphest tasks.
Tue, Mar 25, 09:35
aklapper committed rP56797b17ede0: Herald actions: Allow setting subtype on Maniphest tasks.
Herald actions: Allow setting subtype on Maniphest tasks
Tue, Mar 25, 09:35
aklapper closed D25923: Fix invalid CSS transition value for .jx-scrollbar-handle.
Tue, Mar 25, 09:29
aklapper committed rPfcd6a4c28aba: Fix invalid CSS transition value for .jx-scrollbar-handle.
Fix invalid CSS transition value for .jx-scrollbar-handle
Tue, Mar 25, 09:29
aklapper updated the diff for D25923: Fix invalid CSS transition value for .jx-scrollbar-handle.

git rebase master

Tue, Mar 25, 09:28
aklapper closed D25922: Fix invalid CSS cursor value for .phabricator-main-menu-brand.
Tue, Mar 25, 09:25
aklapper committed rPfede9f450555: Fix invalid CSS cursor value for .phabricator-main-menu-brand.
Fix invalid CSS cursor value for .phabricator-main-menu-brand
Tue, Mar 25, 09:25
valerio.bozzolan accepted D25922: Fix invalid CSS cursor value for .phabricator-main-menu-brand.

sgtm

Tue, Mar 25, 08:19
valerio.bozzolan accepted D25923: Fix invalid CSS transition value for .jx-scrollbar-handle.

Makes sense thaanks, 0s seems also the documented default

Tue, Mar 25, 07:56

Mon, Mar 24

Cigaryno added a project to T16021: Conpherence: Add "Can Create Rooms" policy: User-Cigaryno.
Mon, Mar 24, 20:09 · User-Cigaryno, Policy, Conpherence
Cigaryno added a project to T16020: Conpherence: Add Default View and Edit Policies: User-Cigaryno.
Mon, Mar 24, 20:09 · User-Cigaryno, Policy, Conpherence
aklapper requested review of D25923: Fix invalid CSS transition value for .jx-scrollbar-handle.
Mon, Mar 24, 17:56
aklapper requested review of D25922: Fix invalid CSS cursor value for .phabricator-main-menu-brand.
Mon, Mar 24, 17:51
aklapper requested review of D25921: Fix invalid CSS overflow value for .phui-oi-name.
Mon, Mar 24, 14:52
aklapper updated the diff for D25889: Add "Authored Tasks" view / item to user profile menu.

Don't change URI path /people/tasks/{$id}/ of assigned tasks not to break potential external linking

Mon, Mar 24, 13:40
aklapper requested review of D25920: Fix invalid CSS vertical-align value for .fancy-datepicker-core.
Mon, Mar 24, 12:11
aklapper requested review of D25919: Fix invalid CSS cursor value for .phui-oi-grippable.
Mon, Mar 24, 11:46
aklapper requested review of D25918: Fix invalid CSS border value for .phui-timeline-preview-header.
Mon, Mar 24, 11:38
aklapper requested review of D25917: Make an IE CSS hack pass W3C CSS validator.
Mon, Mar 24, 11:11
aklapper closed D25916: Remove pre-2013 vendor-prefixed -o- CSS properties.
Mon, Mar 24, 11:06
aklapper committed rP22147cc03b5f: Remove pre-2013 vendor-prefixed -o- CSS properties.
Remove pre-2013 vendor-prefixed -o- CSS properties
Mon, Mar 24, 11:06
aklapper updated the diff for D25916: Remove pre-2013 vendor-prefixed -o- CSS properties.

git rebase master

Mon, Mar 24, 11:06
aklapper closed D25915: Remove pre-2013 vendor-prefixed -moz- CSS properties.
Mon, Mar 24, 11:03
aklapper committed rP8353146b0473: Remove pre-2013 vendor-prefixed -moz- CSS properties.
Remove pre-2013 vendor-prefixed -moz- CSS properties
Mon, Mar 24, 11:03
aklapper updated the diff for D25915: Remove pre-2013 vendor-prefixed -moz- CSS properties.
  • Rebase
Mon, Mar 24, 08:03
aklapper closed D25914: Remove pre-2005 vendor-prefixed -khtml- CSS property.
Mon, Mar 24, 07:59
aklapper committed rP645b1f5a99a7: Remove pre-2005 vendor-prefixed -khtml- CSS property.
Remove pre-2005 vendor-prefixed -khtml- CSS property
Mon, Mar 24, 07:59

Sun, Mar 23

valerio.bozzolan accepted D25914: Remove pre-2005 vendor-prefixed -khtml- CSS property.

Nice

Sun, Mar 23, 22:40
valerio.bozzolan accepted D25915: Remove pre-2013 vendor-prefixed -moz- CSS properties.

(and well done Herald²)

Sun, Mar 23, 22:39
valerio.bozzolan accepted D25916: Remove pre-2013 vendor-prefixed -o- CSS properties.

(And well done Herald)

Sun, Mar 23, 22:38
aklapper requested review of D25916: Remove pre-2013 vendor-prefixed -o- CSS properties.
Sun, Mar 23, 20:48
aklapper updated the summary of D25915: Remove pre-2013 vendor-prefixed -moz- CSS properties.
Sun, Mar 23, 20:10
aklapper requested review of D25915: Remove pre-2013 vendor-prefixed -moz- CSS properties.
Sun, Mar 23, 20:06
aklapper updated the diff for D25914: Remove pre-2005 vendor-prefixed -khtml- CSS property.

Go back to previous khtml only change

Sun, Mar 23, 20:02
aklapper added a comment to D25914: Remove pre-2005 vendor-prefixed -khtml- CSS property.

Great, Phorge. So much for stacked patches... Looks like git checkout -b mozPrefixedCss cssKhtmlOpacity did not do what I had expected it to do.

Sun, Mar 23, 19:51
aklapper updated the diff for D25914: Remove pre-2005 vendor-prefixed -khtml- CSS property.

Remove pre-2013 vendor-prefixed -moz- CSS properties

Sun, Mar 23, 19:50
aklapper retitled D25914: Remove pre-2005 vendor-prefixed -khtml- CSS property from Remove outdated -khtml-opacity from CSS
Sun, Mar 23, 19:49
aklapper added inline comments to D25880: Replace some AphrontView::setUser() calls with AphrontView::setViewer().
Sun, Mar 23, 18:17
aklapper added inline comments to D25880: Replace some AphrontView::setUser() calls with AphrontView::setViewer().
Sun, Mar 23, 18:14
aklapper added inline comments to D25880: Replace some AphrontView::setUser() calls with AphrontView::setViewer().
Sun, Mar 23, 18:10
Cigaryno added a comment to T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file.

@valerio.bozzolan could you please add to either H28 or H29 Affected files contains none of map.php?

Sun, Mar 23, 13:28 · Bug Reports, Phorge Development Tools, Arcanist, User-valerio.bozzolan
aklapper requested review of D25914: Remove pre-2005 vendor-prefixed -khtml- CSS property.
Sun, Mar 23, 13:13
aklapper closed T16019: AphrontFormPolicyControl label vs control ID are off by one as Resolved by committing rPad7560b36491: AphrontFormPolicyControl: Reuse existing control ID.
Sun, Mar 23, 09:12 · Accessibility
aklapper closed D25910: AphrontFormPolicyControl: Reuse existing control ID.
Sun, Mar 23, 09:12
aklapper committed rPad7560b36491: AphrontFormPolicyControl: Reuse existing control ID.
AphrontFormPolicyControl: Reuse existing control ID
Sun, Mar 23, 09:12

Sat, Mar 22

valerio.bozzolan resigned from D25738: Avoid RuntimeException on "Skip past this commit" when commit still importing.

Marking as "probably my previous block is now nonsense - but still not reviewed sorry" asd

Sat, Mar 22, 22:38 · Diffusion
valerio.bozzolan accepted D25910: AphrontFormPolicyControl: Reuse existing control ID.

Uhm yes thanks

Sat, Mar 22, 22:33
valerio.bozzolan accepted D25912: Apply "Can Bulk Edit Tasks" to "Move Tasks" workboard options.
Sat, Mar 22, 21:47
valerio.bozzolan added a comment to D25912: Apply "Can Bulk Edit Tasks" to "Move Tasks" workboard options.

P.S. maybe if the task number is very small (e.g. 2) maybe we can still allow that.

I'd prefer not to introduce non-obvious confusing behavior (sometimes it does, sometimes it doesn't?) to increase code (and testing) complexity for no good reason...

Sat, Mar 22, 21:43
valerio.bozzolan accepted D25913: Herald actions: Allow setting subtype on Maniphest tasks.

It works on my computer and it makes me feel like a happy Phorgi unicorn running in a Phorgi golden forest, whoa

Sat, Mar 22, 21:40
valerio.bozzolan added a comment to T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.

Another good simple candidate GDPR-friendly:

Sat, Mar 22, 21:31 · Discussion Needed, Affects-Wikimedia
Cigaryno added projects to T16022: Herald: Support setting task subtype action: Herald, Affects-Wikimedia.

This is one great Wikimedia patch being upstreamed. Should I make this a sub-task of T15081?

Sat, Mar 22, 12:34 · Affects-Wikimedia, Herald, Feature Requests
aklapper requested review of D25913: Herald actions: Allow setting subtype on Maniphest tasks.
Sat, Mar 22, 10:16
aklapper added a revision to T16022: Herald: Support setting task subtype action: D25913: Herald actions: Allow setting subtype on Maniphest tasks.
Sat, Mar 22, 10:16 · Affects-Wikimedia, Herald, Feature Requests
aklapper created T16022: Herald: Support setting task subtype action.
Sat, Mar 22, 10:06 · Affects-Wikimedia, Herald, Feature Requests
Cigaryno added a comment to D25912: Apply "Can Bulk Edit Tasks" to "Move Tasks" workboard options.

Took the opportunity to fix a typo in the summary.

Sat, Mar 22, 09:59
Cigaryno updated the summary of D25912: Apply "Can Bulk Edit Tasks" to "Move Tasks" workboard options.
Sat, Mar 22, 09:59
aklapper added a comment to D25912: Apply "Can Bulk Edit Tasks" to "Move Tasks" workboard options.

P.S. maybe if the task number is very small (e.g. 2) maybe we can still allow that.

Sat, Mar 22, 09:57
aklapper added inline comments to D25912: Apply "Can Bulk Edit Tasks" to "Move Tasks" workboard options.
Sat, Mar 22, 09:55
valerio.bozzolan added a comment to D25912: Apply "Can Bulk Edit Tasks" to "Move Tasks" workboard options.

(Feel free to copy-paste the downstream task in Phorge - so the lack of task is not used as blocking reason - maybe title "Allow to mitigate spammers from workboard bulk move" or something similar)

Sat, Mar 22, 08:55
aklapper requested review of D25912: Apply "Can Bulk Edit Tasks" to "Move Tasks" workboard options.
Sat, Mar 22, 08:13
xtex edited the content of Organizations Using Phorge.
Sat, Mar 22, 00:59
xtex published a new version of Organizations Using Phorge.
Sat, Mar 22, 00:59
xtex updated xtex.
Sat, Mar 22, 00:17

Fri, Mar 21

mainframe98 awarded T16021: Conpherence: Add "Can Create Rooms" policy a Like token.
Fri, Mar 21, 18:15 · User-Cigaryno, Policy, Conpherence
Cigaryno created T16021: Conpherence: Add "Can Create Rooms" policy.
Fri, Mar 21, 17:32 · User-Cigaryno, Policy, Conpherence
Cigaryno created T16020: Conpherence: Add Default View and Edit Policies.
Fri, Mar 21, 17:31 · User-Cigaryno, Policy, Conpherence
Tgr added a comment to T16017: Notifications: Mark All Read is disabled for some ghosts unread notifications.

I think this makes sense - Mark All Read is about marking all search results read. (I assume; I never used it. But that's what the UI implies, it being grouped with e.g. Use Results which is definitely about doing things with the search results.) So no search results -> nothing to mark as read. The bug is in not getting any results.

Fri, Mar 21, 14:19 · Phorge
aklapper abandoned D25903: Avoid "No such token" exception going to /token/give/ directly.

I believe that this is not the correct approach, thus abandoning.

Fri, Mar 21, 13:48
aklapper updated the test plan for D25911: Diviner: Configuring Outbound Mail: Remove incorrect Gmail references.
Fri, Mar 21, 13:43
aklapper requested review of D25911: Diviner: Configuring Outbound Mail: Remove incorrect Gmail references.
Fri, Mar 21, 13:42
aklapper requested review of D25910: AphrontFormPolicyControl: Reuse existing control ID.
Fri, Mar 21, 12:20
aklapper added a revision to T16019: AphrontFormPolicyControl label vs control ID are off by one: D25910: AphrontFormPolicyControl: Reuse existing control ID.
Fri, Mar 21, 12:20 · Accessibility
aklapper created T16019: AphrontFormPolicyControl label vs control ID are off by one.
Fri, Mar 21, 12:15 · Accessibility
vabocharov added a comment to Q176: The hierarchy of documents is located after the document in the wiki.

@aklapper we are talking specifically about documents that are under another document, that is, about the hierarchy of pages in the wiki.
The screenshot F3250825 just shows that the visualization of the document hierarchy is not very convenient in my opinion, and I ask if it can be moved to the side.

Fri, Mar 21, 08:55 · UX

Thu, Mar 20

AndrewTavis updated the task description for T16018: Update TOTP suggestions to open-source applications.
Thu, Mar 20, 22:14
AndrewTavis created T16018: Update TOTP suggestions to open-source applications.
Thu, Mar 20, 22:08