Page MenuHomePhorge

Give embedded image files with transparency a checkered background
ClosedPublic

Authored by aklapper on Jun 14 2023, 18:44.
Tags
None
Referenced Files
F2940465: D25294.1738073147.diff
Mon, Jan 27, 14:05
F2939220: D25294.1738031411.diff
Mon, Jan 27, 02:30
F2934457: D25294.1737788573.diff
Fri, Jan 24, 07:02
F2933531: D25294.1737773941.diff
Fri, Jan 24, 02:59
F2929395: D25294.1737654722.diff
Wed, Jan 22, 17:52
F2929394: D25294.1737654720.diff
Wed, Jan 22, 17:52
F2929392: D25294.1737654719.diff
Wed, Jan 22, 17:51
F2929391: D25294.1737654719.diff
Wed, Jan 22, 17:51

Details

Summary

Have a consistent rendering experience between File page and file embedded in a task for PNG image files with an alpha channel:
Show a checkered background on the embedded image instead of a white background; show full contrast when hovering over the embedded image.

Closes T15473

Test Plan

See steps in T15473 - compare an image file embedded in a task before and after applying this patch.

  • test in Task description
  • test in Task comment
  • test in Task comment inside something weird like a table

Diff Detail

Repository
rP Phorge
Branch
arcpatch-D25294
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 578
Build 578: arc lint + arc unit

Event Timeline

valerio.bozzolan edited the test plan for this revision. (Show Details)

Nice catch!

lgtm

This revision is now accepted and ready to land.Jun 14 2023, 19:14