Page MenuHomePhorge

Give embedded image files with transparency a checkered background
ClosedPublic

Authored by aklapper on Jun 14 2023, 18:44.
Tags
None
Referenced Files
F2197026: D25294.1716236502.diff
Sun, May 19, 20:21
Unknown Object (File)
Tue, May 14, 12:06
Unknown Object (File)
Sun, May 12, 12:34
Unknown Object (File)
Sun, May 12, 12:34
Unknown Object (File)
Sun, May 12, 12:33
Unknown Object (File)
Sat, May 11, 18:39
Unknown Object (File)
Wed, May 8, 04:21
Unknown Object (File)
Wed, May 8, 03:20

Details

Summary

Have a consistent rendering experience between File page and file embedded in a task for PNG image files with an alpha channel:
Show a checkered background on the embedded image instead of a white background; show full contrast when hovering over the embedded image.

Closes T15473

Test Plan

See steps in T15473 - compare an image file embedded in a task before and after applying this patch.

  • test in Task description
  • test in Task comment
  • test in Task comment inside something weird like a table

Diff Detail

Repository
rP Phorge
Branch
EmbedImageFileCheckeredBg (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 557
Build 557: arc lint + arc unit

Event Timeline

valerio.bozzolan edited the test plan for this revision. (Show Details)

Nice catch!

lgtm

This revision is now accepted and ready to land.Jun 14 2023, 19:14