Page MenuHomePhorge

Strike through archived projects in navigation crumbs
AcceptedPublic

Authored by aklapper on Aug 13 2024, 12:15.

Details

Summary

Going to e.g. the workboard of an archived project, there is no indication when the project has been archived (the blurred project icon is only displayed if the viewport width is >920px). This can lead to confusion why a workboard is completely empty.
Thus render an archived project as strike-through in the navigation bread crumbs.

Closes T15890

Test Plan
  • Go to the {Profile, Workboard, Reports, Members, Subprojects, Reports} pages of an active and an archived project and look at the navigation crumbs bar below Phorge's global top bar.
  • Create an active subproject and active milestone of an archived project (and vice versa) and look at the navigation crumbs.

Diff Detail

Repository
rP Phorge
Branch
T15890crumbsArchivedProject
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/view/phui/PHUICrumbView.php:7XHP1PHP Syntax Error!
Unit
Test Failures
Build Status
Buildable 1521
Build 1521: arc lint + arc unit

Unit TestsFailed

TimeTest
1,106 msPhabricatorLibraryTestCase::testLibraryMap
EXCEPTION (XHPASTSyntaxErrorException): view/phui/PHUICrumbView.php: XHPAST Parse Error: syntax error, unexpected T_STRING, expecting T_VARIABLE on line 7 #0 /var/www/html/phorge/arcanist/src/moduleutils/PhutilLibraryMapBuilder.php(63): PhutilLibraryMapBuilder->analyzeLibrary() #1 /var/www/html/phorge/arcanist/src/__tests__/PhutilLibraryTestCase.php(29): PhutilLibraryMapBuilder->buildMap()
408 msPHUIInvisibleCharacterTestCase::testEmptyPlainText
1 assertion passed.
404 msPHUIInvisibleCharacterTestCase::testEmptyString
1 assertion passed.
410 msPHUIInvisibleCharacterTestCase::testHtmlDecoration
5 assertions passed.
408 msPHUIInvisibleCharacterTestCase::testWithHexChars
1 assertion passed.
View Full Test Results (1 Failed · 40 Passed)

Event Timeline

This revision is now accepted and ready to land.Aug 15 2024, 17:02