The persistent chat, as mentioned in ref T15626, when collapsed, still has an invisible gear icon on the left of the upper arrow icon. It should not be there. This fix removes the core-menu-item class if the chat is minimized and add it back when expanded.
- Group Reviewers
O1: Blessed Committers
- Maniphest Tasks
- T15626: [Web] Persistent chat settings should not be clickable or visible when the chat is minimized
Follow the steps in task ref: T15626 and now the context menu should not be triggered when clicking on the left of the upper arrow
(I'll try to render the Javeline guide here later).
- We don't use document.querySelector - we use JX.DOM.find, you can see an example in line 43
- the else should be in the same line as the }.
It seems undocumented also in the mentioned guide 🤔
Anyway we can also avoid to manually manage with two classlists, and adopt this oneline instead, just like line 66.
JX.DOM.alterClass(clickable_gear_element, 'core-menu-item', !userMinimize);