Differential D25384

Fix icon background color when using Dark Mode
ClosedPublic
Actions

Authored by bob on Aug 11 2023, 12:10.

Details

Reviewers

Matthew
valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15056: Improve Dark Mode

Commits

rP3f5fcdf4ddd8: Fix icon background color when using Dark Mode

Summary

This CSS fix replaces the hard coded background gradient (white) value of icons when using Dark Mode.

Now the "Choose User Icon" popup has visible icons.

Before	After

Test Plan

Flush all Phorge caches
Sign in
Go to user's Settings > Display Preferences and select the Accessibility (user interface) "Dark Mode".
Go to user's profile, edit profile and click on Choose icon.
Check that now the icons in "Choose User Icon" are visible.
Do these steps for each user interface theme in order to check against regression.

Diff Detail

Repository

Branch

arcpatch-D25384

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 748
Build 748: arc lint + arc unit

Event Timeline

bob created this revision.Aug 11 2023, 12:10

Owners added a reviewer: O1: Blessed Committers.Aug 11 2023, 12:10

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptAug 11 2023, 12:10

bob requested review of this revision.Aug 11 2023, 12:10

Harbormaster completed remote builds in B741: Diff 1229.Aug 11 2023, 12:10

bob updated this revision to Diff 1230.Aug 11 2023, 12:13

This comment was removed by bob.

Harbormaster completed remote builds in B742: Diff 1230.Aug 11 2023, 12:13

LGTM

This revision is now accepted and ready to land.Aug 11 2023, 16:30

Thanks

Please also manually run this

./bin/celerity map

(Sorry for that - needs a fix in T15209)

valerio.bozzolan mentioned this in T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file.Aug 11 2023, 17:01

Updating D25384: Update celerity map

Harbormaster completed remote builds in B748: Diff 1248.Aug 14 2023, 09:07

I've updated the celerity map, let me know if I've the green light to land the revision!

valerio.bozzolan edited the test plan for this revision. (Show Details)Aug 15 2023, 00:47

valerio.bozzolan edited the summary of this revision. (Show Details)

valerio.bozzolan added a task: T15056: Improve Dark Mode.

valerio.bozzolan mentioned this in T15056: Improve Dark Mode.Aug 15 2023, 00:52

Yeah bob this change was already accepted, and now it's super-accepted. This change is adorable, thanks!

Closed by commit rP3f5fcdf4ddd8: Fix icon background color when using Dark Mode. · Explain WhyAug 16 2023, 08:30

This revision was automatically updated to reflect the committed changes.

bob added a commit: rP3f5fcdf4ddd8: Fix icon background color when using Dark Mode.

valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 19 2023, 04:47

valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 28 2023, 16:39

Revision Contents
Changeset List

Path

Size

Packages

resources/

celerity/

O1: Blessed Committers

webroot/

rsrc/

css/

phui/

phui-icon-set-selector.css

4 lines

O1: Blessed Committers

Diff 1248

resources/celerity/map.php

Loading...

webroot/rsrc/css/phui/phui-icon-set-selector.css

Loading...