Page MenuHomePhorge

Ponder Answer Comments: indent textarea as Comments
ClosedPublic

Authored by valerio.bozzolan on May 4 2023, 21:34.
Tags
None
Referenced Files
F1399576: D25192.diff
Thu, Feb 22, 07:20
Unknown Object (File)
Sat, Feb 17, 04:43
Unknown Object (File)
Fri, Feb 16, 22:59
Unknown Object (File)
Sun, Feb 11, 18:50
Unknown Object (File)
Fri, Feb 9, 16:38
Unknown Object (File)
Fri, Feb 9, 11:17
Unknown Object (File)
Fri, Jan 26, 11:23
Unknown Object (File)
Jan 20 2024, 17:38

Details

Summary

In a Ponder Answer, when adding a Comment, the textarea indentation was a
a little bit unintuitive.

After this change, the textarea is aligned as a Comment:

BeforeAfter
Ponder - Before.png (694×626 px, 45 KB)
Ponder - After.png (694×626 px, 48 KB)

Other changes are welcome but this seems to me a good minimum.

I also hope this could help not to confuse the Comment field with the Answer field.

Closes T15350

Test Plan
  • create a Ponder Question
  • create an Answer
  • look at the Comments input field that now should be more nicely indented
  • the normal Response field is not changed at all
  • the mobile view is not changed at all
  • click on "Pin Form On Screen" and it must be as before

Diff Detail

Repository
rP Phorge
Branch
arcpatch-D25192_2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 679
Build 679: arc lint + arc unit

Event Timeline

webroot/rsrc/css/application/ponder/ponder-view.css
56

Note: I used the .phui-box.phui-comment-form-view selector instead of just .phui-comment-form-view, so that it's more specific, and it overrides the precedent value.

This was my elegant workaround to avoid a CSS !important otherwise necessary.

This revision is now accepted and ready to land.Jul 17 2023, 06:48
webroot/rsrc/css/application/ponder/ponder-view.css
56

↑ My inline comment is not relevant anymore, since we have the :not() selector that is already incidentally more-precise.

So there is no need to have margin-left: 94px; !important.