Page MenuHomePhorge

Fix middle-click, CTRL+click, right-click etc. on Typehead search results
ClosedPublic

Authored by valerio.bozzolan on Feb 26 2023, 21:51.
Tags
None
Referenced Files
F3336076: D25069.1743569112.diff
Tue, Apr 1, 04:45
F3335263: D25069.1743560411.diff
Tue, Apr 1, 02:20
F3334859: D25069.1743554542.diff
Tue, Apr 1, 00:42
F3334663: D25069.1743552559.diff
Tue, Apr 1, 00:09
F3330297: D25069.1743487114.diff
Mon, Mar 31, 05:58
F3329693: D25069.1743479213.diff
Mon, Mar 31, 03:46
F3318535: D25069.1743286688.diff
Fri, Mar 28, 22:18
F3313406: D25069.1743218470.diff
Fri, Mar 28, 03:21
Tokens
"Love" token, awarded by 20after4."Cup of Joe" token, awarded by valerio.bozzolan."Yellow Medal" token, awarded by avivey.

Details

Summary

Fix middle-click, CTRL+click, right-click etc. on Typehead search results.

Closes T15149

Test Plan

Try the following actions on various typeheads:

  • right-click
  • middle-click
  • CTRL+click
  • normal click

Demonstration video (2M) showing After patch (on localhost) and Before patch (here on we.phorge.it), where I middle-click and normal-click on menu entries:

Notes:

  • the middle click now works (opening in new tab)
  • the CTRL+click (or "command" key + click) now works (opening in new tab)
  • the right click now opens the context menu (previously broken)
  • the normal click should just click (as usual)

Try on:

  • search results while typing in main search bar
  • search results when editing a Task Tags / assigned to, etc.
  • try to click on other weird places
  • $$$

Diff Detail

Repository
rP Phorge
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 119
Build 119: arc lint + arc unit

Event Timeline

rollback last changes made by mistake using arc diff

avivey awarded a token.
This revision is now accepted and ready to land.Mar 3 2023, 10:24