Page MenuHomePhorge

Fix middle-click, CTRL+click, right-click etc. on Typehead search results
ClosedPublic

Authored by valerio.bozzolan on Feb 26 2023, 21:51.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 21, 06:15
Unknown Object (File)
Mon, Feb 19, 16:09
Unknown Object (File)
Fri, Feb 16, 05:17
Unknown Object (File)
Sat, Feb 10, 05:43
Unknown Object (File)
Tue, Jan 30, 14:47
Unknown Object (File)
Sun, Jan 28, 05:03
Unknown Object (File)
Jan 22 2024, 23:26
Unknown Object (File)
Jan 4 2024, 03:09
Tokens
"Love" token, awarded by 20after4."Cup of Joe" token, awarded by valerio.bozzolan."Yellow Medal" token, awarded by avivey.

Details

Summary

Fix middle-click, CTRL+click, right-click etc. on Typehead search results.

Closes T15149

Test Plan

Try the following actions on various typeheads:

  • right-click
  • middle-click
  • CTRL+click
  • normal click

Demonstration video (2M) showing After patch (on localhost) and Before patch (here on we.phorge.it), where I middle-click and normal-click on menu entries:

Notes:

  • the middle click now works (opening in new tab)
  • the CTRL+click (or "command" key + click) now works (opening in new tab)
  • the right click now opens the context menu (previously broken)
  • the normal click should just click (as usual)

Try on:

  • search results while typing in main search bar
  • search results when editing a Task Tags / assigned to, etc.
  • try to click on other weird places
  • $$$

Diff Detail

Repository
rP Phorge
Branch
T15155-fix-search-servers-array-status-icon
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/applications/config/controller/services/PhabricatorConfigClusterSearchController.php:73XHP25Spaces Inside Parentheses
Unit
Test Failures
Build Status
Buildable 120
Build 120: arc lint + arc unit

Unit TestsFailed

TimeTest
728 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
704 msPhabricatorConduitTestCase::testConduitMethods
1 assertion passed.
227 msPhabricatorInfrastructureTestCase::testApplicationsInstalled
1 assertion passed.
229 msPhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries
1 assertion passed.
285 msPhabricatorLibraryTestCase::testEverythingImplemented
1 assertion passed.
View Full Test Results (1 Failed · 6 Passed)

Event Timeline

rollback last changes made by mistake using arc diff

avivey awarded a token.
This revision is now accepted and ready to land.Mar 3 2023, 10:24