Fix middle-click, CTRL+click, right-click etc. on Typehead search results.
Closes T15149
Details
Details
- Reviewers
avivey - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15149: Fix middle-click, CTRL+click, right-click etc. on Typehead search results
- Commits
- rP53c31b7b135c: Fix middle-click, CTRL+click, right-click etc. on Typehead search results
Try the following actions on various typeheads:
- right-click
- middle-click
- CTRL+click
- normal click
Demonstration video (2M) showing After patch (on localhost) and Before patch (here on we.phorge.it), where I middle-click and normal-click on menu entries:
Notes:
- the middle click now works (opening in new tab)
- the CTRL+click (or "command" key + click) now works (opening in new tab)
- the right click now opens the context menu (previously broken)
- the normal click should just click (as usual)
Try on:
- search results while typing in main search bar
- search results when editing a Task Tags / assigned to, etc.
- try to click on other weird places
- $$$
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- T15155-fix-search-servers-array-status-icon
- Lint
Lint Warnings Severity Location Code Message Warning src/applications/config/controller/services/PhabricatorConfigClusterSearchController.php:73 XHP25 Spaces Inside Parentheses - Unit
Test Failures - Build Status
Buildable 120 Build 120: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 728 ms | PhabricatorCelerityTestCase::testCelerityMaps Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it.
ACTUAL VALUE
| |
| 704 ms | PhabricatorConduitTestCase::testConduitMethods 1 assertion passed. | |
| 227 ms | PhabricatorInfrastructureTestCase::testApplicationsInstalled 1 assertion passed. | |
| 229 ms | PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries 1 assertion passed. | |
| 285 ms | PhabricatorLibraryTestCase::testEverythingImplemented 1 assertion passed. | |
| View Full Test Results (1 Failed · 6 Passed) |