Page MenuHomePhorge

Discussion NeededTag
ActivePublic

Members

  • This project does not have any members.
  • View All

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

Tasks that require more thinking/input from community to reach an decision for the most suitable implementation.

Not to be confused with Clarification Needed - to be used when the general background is unclear or partially Invalid.

Recent Activity

Wed, Jul 24

valerio.bozzolan created T15892: Post-Commit Audit review: authors cannot "Raise Concern".
Wed, Jul 24, 09:27 · Discussion Needed, Bug Reports, Diffusion

Tue, Jul 23

valerio.bozzolan added a comment to T15882: When archiving a project, reset its default menu item to Profile.

OK. If you are partially mentioning nonsenses in we.phorge.it itself, you are indeed right.

Tue, Jul 23, 08:50 · Discussion Needed, Feature Requests, Projects

Mon, Jul 22

aklapper added a comment to T15882: When archiving a project, reset its default menu item to Profile.

We might come from different user journeys.
Your users might be aware what the project means, and that the project (and its workboard) is archived, and they do have an initial reason to look at this archived workboard (e.g. default view is not "open tasks" but "all tasks")?
My users clicked an external link to some project tag in something called Phorge, and that project has been archived in the meantime, and that project is set to show the workboard by default, and that is now just empty columns (as the default view of workboards is "open tasks"), and that is confusing and unhelpful.

Mon, Jul 22, 14:17 · Discussion Needed, Feature Requests, Projects

Sun, Jul 21

valerio.bozzolan renamed T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers from Diffusion repository commits: avoid to be a black hoile for webcrawlers to Diffusion repository commits: avoid to be a black hole for webcrawlers.
Sun, Jul 21, 08:39 · Discussion Needed
valerio.bozzolan renamed T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers from Disallow webcrawlers to index Diffusion repository commits to Diffusion repository commits: avoid to be a black hoile for webcrawlers.
Sun, Jul 21, 08:39 · Discussion Needed
valerio.bozzolan added a comment to T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers.

(Trying to make this task a bit more about the root problem, and less about the proposed solution)

Sun, Jul 21, 08:39 · Discussion Needed
valerio.bozzolan added a parent task for T15882: When archiving a project, reset its default menu item to Profile: T15886: Archived Projects: make them "more Archived" .
Sun, Jul 21, 08:33 · Discussion Needed, Feature Requests, Projects
valerio.bozzolan removed a subtask for T15882: When archiving a project, reset its default menu item to Profile: T15886: Archived Projects: make them "more Archived" .
Sun, Jul 21, 08:33 · Discussion Needed, Feature Requests, Projects
valerio.bozzolan added a subtask for T15882: When archiving a project, reset its default menu item to Profile: T15886: Archived Projects: make them "more Archived" .
Sun, Jul 21, 08:33 · Discussion Needed, Feature Requests, Projects
valerio.bozzolan added a comment to T15882: When archiving a project, reset its default menu item to Profile.

I mean. See this archived Project (archived Milestone), that is linked from our changelogs:

Sun, Jul 21, 08:24 · Discussion Needed, Feature Requests, Projects

Sat, Jul 20

aklapper added a comment to T15882: When archiving a project, reset its default menu item to Profile.

For example, some people then may ask "why my default view was changed?" and they will start manually "rollbacking" this to their desired view (e.g. showing closed tasks, from the Workboard, with a filter "Show all tasks").

Sat, Jul 20, 09:27 · Discussion Needed, Feature Requests, Projects
valerio.bozzolan added a project to T15882: When archiving a project, reset its default menu item to Profile: Discussion Needed.

Premising that I like the implementation but I think it's not the desired solution.

Sat, Jul 20, 08:50 · Discussion Needed, Feature Requests, Projects

Mon, Jul 1

valerio.bozzolan updated the task description for T15744: Render html color codes in remarkup.
Mon, Jul 1, 07:00 · Discussion Needed, Remarkup
valerio.bozzolan added a comment to T15744: Render html color codes in remarkup.

I think GitHub allows that syntax only in comments 🤔

Mon, Jul 1, 06:50 · Discussion Needed, Remarkup
20after4 added a comment to T15744: Render html color codes in remarkup.

I was unaware of #0969DA syntax from github/gitlab.

Mon, Jul 1, 02:55 · Discussion Needed, Remarkup
20after4 added a comment to T15744: Render html color codes in remarkup.

I was unaware of #0969DA syntax from github/gitlab. I'm not sure if I like that syntax better than {} but I am generally in favor of using the same syntax as other systems in order to converge towards defacto standardization.

Mon, Jul 1, 02:46 · Discussion Needed, Remarkup

Sun, Jun 30

valerio.bozzolan added a comment to T15744: Render html color codes in remarkup.

Thanks again @20after4 for the efforts.

Sun, Jun 30, 13:23 · Discussion Needed, Remarkup
valerio.bozzolan added a project to T15744: Render html color codes in remarkup: Discussion Needed.
Sun, Jun 30, 13:14 · Discussion Needed, Remarkup

May 8 2024

avivey added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Another problem dramatically frequent for newcomers (at least in my office).

It's relatively too much easy to start with a similar commit message:
...

May 8 2024, 08:25 · Discussion Needed, Arcanist

May 7 2024

valerio.bozzolan added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

At least, please go to GitLab, instead of GitHub, so at least you use Free Software :)

May 7 2024, 09:08 · Discussion Needed, Arcanist
micax added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Just some (probably final) thoughts on arcanist and phabricator/phorge. After quite a bit of discussion internally, we are moving on to GitHub with our repositories (which were previously stored in another Git server - not Phabricator). But that move also spells the end for our/my 10+ year long use of Phabricator, because when we move to GitHub, we'll also be ditching Phabricator for code reviews.

May 7 2024, 07:58 · Discussion Needed, Arcanist

Apr 25 2024

Iniquity added a comment to T15082: Consider allowing milestone columns to be ordered arbitrarily on workboards.

It seems to me that this problem can be solved with an additional setting that turns this functionality on or off.

Apr 25 2024, 19:10 · Discussion Needed, Affects-Wikimedia, Workboard

Apr 24 2024

avivey moved T15231: Maybe make automatic workboard display sub-projects as columns? from Backlog to Discussion Needed on the Workboard board.
Apr 24 2024, 06:25 · Discussion Needed, Workboard

Apr 11 2024

revi added a comment to T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers.

Probably my somewhat 10 cents at a broader level;

Apr 11 2024, 17:58 · Discussion Needed

Apr 4 2024

avivey added a comment to T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers.

We don't create the links to page$line in most places as hrefs, so this shouldn't be an issue.

  • Don't exist in Diffusion
  • Do exist in Paste
  • Don't exist in Differential
Apr 4 2024, 21:34 · Discussion Needed
aklapper added a comment to T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers.

If it's that easy

Apr 4 2024, 21:02 · Discussion Needed
avivey added a comment to T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers.

I'm guessing $ is used instead of # because (1) a user-agent might not send the # part to the server, and (2) the natural behavior of # ("scroll to this anchor") isn't what the intended behavior ("highlight these lines and scroll to the first one").

Apr 4 2024, 07:10 · Discussion Needed

Apr 3 2024

valerio.bozzolan added a comment to T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers.

Ah, also adding a smalll meta "noindex" HTML tag on legacy file.php$123 pages and similar ones, would maybe help a little bit.

Apr 3 2024, 17:17 · Discussion Needed
20after4 added a comment to T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers.

Thinking more, I think we'd like to allow the robots to index latest version of the code - these days the big boys know how to handle that. Stopping them from crawling older versions is still important.

Anyway, I vote to revert the change - commit pages can have discussions in.

Apr 3 2024, 17:03 · Discussion Needed
20after4 added a comment to T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers.

If it's that easy, then I'm both impressed and surprised it remained this way for so long. I'm actually not quite sure I understand the reasoning for not using # to begin with.

Apr 3 2024, 16:58 · Discussion Needed

Apr 2 2024

aklapper added a comment to T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers.

A root problem is that highlighted line number(s) should be a # fragment really, to do not multiply pages exponentially.

Apr 2 2024, 19:34 · Discussion Needed
bekay closed T15728: Repo home view and browse view share the same menu tab as Resolved by committing rPba835fe0eced: Seperate repository home and browse view in tab menu.
Apr 2 2024, 13:56 · Discussion Needed, Diffusion

Mar 25 2024

valerio.bozzolan added a comment to T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.

Another good simple candidate GDPR-friendly:

Mar 25 2024, 10:36 · Discussion Needed, Affects-Wikimedia

Mar 19 2024

valerio.bozzolan updated the task description for T15161: Internal resources should avoid to become external links, as default.
Mar 19 2024, 16:41 · User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan closed T15182: Simplify the way "internal links" are identified, a subtask of T15161: Internal resources should avoid to become external links, as default, as Resolved.
Mar 19 2024, 16:34 · User-valerio.bozzolan, Discussion Needed, Remarkup

Mar 14 2024

aklapper added a comment to T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers.

A root problem is that highlighted line number(s) should be a # fragment really, to do not multiply pages exponentially.

Mar 14 2024, 09:53 · Discussion Needed

Mar 11 2024

valerio.bozzolan added a comment to T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers.

A root problem is that highlighted line number(s) should be a # fragment really, to do not multiply pages exponentially.

Mar 11 2024, 08:59 · Discussion Needed

Feb 21 2024

bekay added a comment to T15728: Repo home view and browse view share the same menu tab.

I tried to understand the situation. Thanks.

In your opinion: on the repo view (with clone buttons) is it really important to link to the other similar "reduced" view (without clone buttons)?

Feb 21 2024, 10:15 · Discussion Needed, Diffusion
valerio.bozzolan added a comment to T15728: Repo home view and browse view share the same menu tab.

I tried to understand the situation. Thanks.

Feb 21 2024, 08:03 · Discussion Needed, Diffusion

Feb 14 2024

bekay added a revision to T15728: Repo home view and browse view share the same menu tab: D25538: Separate repository home and browse view in tab menu.
Feb 14 2024, 17:27 · Discussion Needed, Diffusion

Feb 13 2024

20after4 added a comment to T15705: Lower the search ranking of disabled user accounts.

I agree, disabled users should be hidden in the global search typeahead results.

Feb 13 2024, 23:22 · UX
20after4 added a comment to T15736: JavaScript modernization (umbrella task).
In T15736#15681, @bekay wrote:
  • Get rid of the JX namespace and the the require comments - use import and export like it is done in modern js
Feb 13 2024, 23:21 · UX, Discussion Needed
avivey added a comment to T15739: Replace celerity postprocessors with real css variables.

I'm not against replacing the mechanism - It's just that the original task description doesn't specify why that would be good (i.e., what the benefit would be).
That's clear from the discussion now, but should generally be included in the ticket description - the "describe "what", not "how"" principle.

Feb 13 2024, 07:57 · Discussion Needed
sirocyl added a comment to T15739: Replace celerity postprocessors with real css variables.

A big benefit of using client-side variables in CSS, is that one can use the browser's prefers-color-scheme media query to select light or dark mode based on the user's browser or system setting, automatically, and that the transition from light to dark mode, or to other accent/highlight color schemes, requires no reload.

Feb 13 2024, 04:02 · Discussion Needed

Feb 12 2024

bekay added a comment to T15739: Replace celerity postprocessors with real css variables.

Well, I see a tremendous critism and scepticism concerning modern client side techniques here. The world of frontend tooling has changed tremendously in the last 5 years. And I understand concerns, but nobody has to write JavaScript for certain browsers anymore. Javelin for example tries to solve so many problems that Babel solves with one config entry. But that's okay and I like the architecture here and know we can't change everything at once.

Feb 12 2024, 21:05 · Discussion Needed
avivey added a comment to T15739: Replace celerity postprocessors with real css variables.

Ok, I don't understand the specifics of css-vars, but if they're better, they're better.

Feb 12 2024, 20:18 · Discussion Needed
bekay added a comment to T15739: Replace celerity postprocessors with real css variables.

The overwriting of variables with media queries could be configured inside the theming class. So possible breakpoints can be part of a theming API.

Feb 12 2024, 20:16 · Discussion Needed
bekay added a comment to T15739: Replace celerity postprocessors with real css variables.

And my general approach is: when the client can do something (and that even better), why should the server do it?

Feb 12 2024, 20:04 · Discussion Needed
bekay added a comment to T15739: Replace celerity postprocessors with real css variables.

@avivey CSS vars are a vital part of modern modularized theming. They are versatile, can be overwritten with media queries or per class/element basis. They are editable in browser dev tools. If you would ask me: this step is pretty important.

Feb 12 2024, 20:01 · Discussion Needed
bekay added a comment to T15736: JavaScript modernization (umbrella task).

to have a working dev server when developing js - at the moment I have to ./bin/celerity map after every change to js and css to see my changes...

Are you sure about that? I thought celerity map was only needed when adding a file (in dev mode).

Feb 12 2024, 19:47 · UX, Discussion Needed