Page MenuHomePhorge

Discussion NeededTag
ActivePublic

Members

  • This project does not have any members.
  • View All

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

Tasks that require more thinking/input from community to reach an decision for the most suitable implementation.

Not to be confused with Clarification Needed - to be used when the general background is unclear or partially Invalid.

Recent Activity

Thu, Apr 11

revi added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

Probably my somewhat 10 cents at a broader level;

Thu, Apr 11, 17:58 · Discussion Needed

Thu, Apr 4

avivey added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

We don't create the links to page$line in most places as hrefs, so this shouldn't be an issue.

  • Don't exist in Diffusion
  • Do exist in Paste
  • Don't exist in Differential
Thu, Apr 4, 21:34 · Discussion Needed
aklapper added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

If it's that easy

Thu, Apr 4, 21:02 · Discussion Needed
avivey added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

I'm guessing $ is used instead of # because (1) a user-agent might not send the # part to the server, and (2) the natural behavior of # ("scroll to this anchor") isn't what the intended behavior ("highlight these lines and scroll to the first one").

Thu, Apr 4, 07:10 · Discussion Needed

Wed, Apr 3

valerio.bozzolan added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

Ah, also adding a smalll meta "noindex" HTML tag on legacy file.php$123 pages and similar ones, would maybe help a little bit.

Wed, Apr 3, 17:17 · Discussion Needed
20after4 added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

Thinking more, I think we'd like to allow the robots to index latest version of the code - these days the big boys know how to handle that. Stopping them from crawling older versions is still important.

Anyway, I vote to revert the change - commit pages can have discussions in.

Wed, Apr 3, 17:03 · Discussion Needed
20after4 added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

If it's that easy, then I'm both impressed and surprised it remained this way for so long. I'm actually not quite sure I understand the reasoning for not using # to begin with.

Wed, Apr 3, 16:58 · Discussion Needed

Tue, Apr 2

aklapper added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

A root problem is that highlighted line number(s) should be a # fragment really, to do not multiply pages exponentially.

Tue, Apr 2, 19:34 · Discussion Needed
bekay closed T15728: Repo home view and browse view share the same menu tab as Resolved by committing rPba835fe0eced: Seperate repository home and browse view in tab menu.
Tue, Apr 2, 13:56 · Discussion Needed, Diffusion

Mon, Mar 25

valerio.bozzolan added a comment to T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.

Another good simple candidate GDPR-friendly:

Mon, Mar 25, 10:36 · Discussion Needed, Affects-Wikimedia

Tue, Mar 19

valerio.bozzolan updated the task description for T15161: Internal resources should avoid to become external links, as default.
Tue, Mar 19, 16:41 · User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan closed T15182: Simplify the way "internal links" are identified, a subtask of T15161: Internal resources should avoid to become external links, as default, as Resolved.
Tue, Mar 19, 16:34 · User-valerio.bozzolan, Discussion Needed, Remarkup

Mar 14 2024

aklapper added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

A root problem is that highlighted line number(s) should be a # fragment really, to do not multiply pages exponentially.

Mar 14 2024, 09:53 · Discussion Needed

Mar 11 2024

valerio.bozzolan added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

A root problem is that highlighted line number(s) should be a # fragment really, to do not multiply pages exponentially.

Mar 11 2024, 08:59 · Discussion Needed

Feb 21 2024

bekay added a comment to T15728: Repo home view and browse view share the same menu tab.

I tried to understand the situation. Thanks.

In your opinion: on the repo view (with clone buttons) is it really important to link to the other similar "reduced" view (without clone buttons)?

Feb 21 2024, 10:15 · Discussion Needed, Diffusion
valerio.bozzolan added a comment to T15728: Repo home view and browse view share the same menu tab.

I tried to understand the situation. Thanks.

Feb 21 2024, 08:03 · Discussion Needed, Diffusion

Feb 14 2024

bekay added a revision to T15728: Repo home view and browse view share the same menu tab: D25538: Separate repository home and browse view in tab menu.
Feb 14 2024, 17:27 · Discussion Needed, Diffusion

Feb 13 2024

20after4 added a comment to T15705: Lower the search ranking of disabled user accounts.

I agree, disabled users should be hidden in the global search typeahead results.

Feb 13 2024, 23:22 · Discussion Needed, UX
20after4 added a comment to T15736: JavaScript modernization (umbrella task).
In T15736#15681, @bekay wrote:
  • Get rid of the JX namespace and the the require comments - use import and export like it is done in modern js
Feb 13 2024, 23:21 · UX, Discussion Needed
avivey added a comment to T15739: Replace celerity postprocessors with real css variables.

I'm not against replacing the mechanism - It's just that the original task description doesn't specify why that would be good (i.e., what the benefit would be).
That's clear from the discussion now, but should generally be included in the ticket description - the "describe "what", not "how"" principle.

Feb 13 2024, 07:57 · Discussion Needed
sirocyl added a comment to T15739: Replace celerity postprocessors with real css variables.

A big benefit of using client-side variables in CSS, is that one can use the browser's prefers-color-scheme media query to select light or dark mode based on the user's browser or system setting, automatically, and that the transition from light to dark mode, or to other accent/highlight color schemes, requires no reload.

Feb 13 2024, 04:02 · Discussion Needed

Feb 12 2024

bekay added a comment to T15739: Replace celerity postprocessors with real css variables.

Well, I see a tremendous critism and scepticism concerning modern client side techniques here. The world of frontend tooling has changed tremendously in the last 5 years. And I understand concerns, but nobody has to write JavaScript for certain browsers anymore. Javelin for example tries to solve so many problems that Babel solves with one config entry. But that's okay and I like the architecture here and know we can't change everything at once.

Feb 12 2024, 21:05 · Discussion Needed
avivey added a comment to T15739: Replace celerity postprocessors with real css variables.

Ok, I don't understand the specifics of css-vars, but if they're better, they're better.

Feb 12 2024, 20:18 · Discussion Needed
bekay added a comment to T15739: Replace celerity postprocessors with real css variables.

The overwriting of variables with media queries could be configured inside the theming class. So possible breakpoints can be part of a theming API.

Feb 12 2024, 20:16 · Discussion Needed
bekay added a comment to T15739: Replace celerity postprocessors with real css variables.

And my general approach is: when the client can do something (and that even better), why should the server do it?

Feb 12 2024, 20:04 · Discussion Needed
bekay added a comment to T15739: Replace celerity postprocessors with real css variables.

@avivey CSS vars are a vital part of modern modularized theming. They are versatile, can be overwritten with media queries or per class/element basis. They are editable in browser dev tools. If you would ask me: this step is pretty important.

Feb 12 2024, 20:01 · Discussion Needed
bekay added a comment to T15736: JavaScript modernization (umbrella task).

to have a working dev server when developing js - at the moment I have to ./bin/celerity map after every change to js and css to see my changes...

Are you sure about that? I thought celerity map was only needed when adding a file (in dev mode).

Feb 12 2024, 19:47 · UX, Discussion Needed
avivey added a comment to T15736: JavaScript modernization (umbrella task).

also, adding this file in src/extensions/ will let you have css/js files from src/extensions/rsrc/ loaded automatically:

Feb 12 2024, 19:46 · UX, Discussion Needed
avivey added a comment to T15736: JavaScript modernization (umbrella task).

to have a working dev server when developing js - at the moment I have to ./bin/celerity map after every change to js and css to see my changes...

Feb 12 2024, 19:44 · UX, Discussion Needed
avivey added a comment to T15739: Replace celerity postprocessors with real css variables.

Looks to me that the existing system is better at providing Themes? It allows real code, inheritance, etc. to set variable values.
That is, I think Extension Themes are better off writing PHP Post-Processor rather then CSS vars.

Feb 12 2024, 19:36 · Discussion Needed
bekay updated the task description for T15739: Replace celerity postprocessors with real css variables.
Feb 12 2024, 17:27 · Discussion Needed
bekay added a comment to T15705: Lower the search ranking of disabled user accounts.

I don't know if that is part of this task, but the global typeahead search should hide all disabled users, wikis and repos, shouldn't it? This is nothing you want as a fast suggestion...

Feb 12 2024, 16:46 · Discussion Needed, UX
bekay updated the task description for T15739: Replace celerity postprocessors with real css variables.
Feb 12 2024, 16:40 · Discussion Needed
bekay updated the task description for T15739: Replace celerity postprocessors with real css variables.
Feb 12 2024, 16:32 · Discussion Needed
bekay updated the task description for T15739: Replace celerity postprocessors with real css variables.
Feb 12 2024, 16:31 · Discussion Needed
bekay created T15739: Replace celerity postprocessors with real css variables.
Feb 12 2024, 16:24 · Discussion Needed
bekay added a comment to T15736: JavaScript modernization (umbrella task).

Well, my idea would be:

Feb 12 2024, 12:56 · UX, Discussion Needed

Feb 11 2024

20after4 triaged T15736: JavaScript modernization (umbrella task) as Wishlist priority.
Feb 11 2024, 22:32 · UX, Discussion Needed
20after4 added a subtask for T15736: JavaScript modernization (umbrella task): T15168: Improve JavaScript i18n.
Feb 11 2024, 22:32 · UX, Discussion Needed
20after4 created T15736: JavaScript modernization (umbrella task).
Feb 11 2024, 22:31 · UX, Discussion Needed

Feb 6 2024

20after4 added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

When I was at Wikimedia I remember a lot of issues from search robots endlessly indexing dynamic pages.

Feb 6 2024, 02:26 · Discussion Needed

Feb 5 2024

avivey added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

In case of what?

Feb 5 2024, 08:54 · Discussion Needed
valerio.bozzolan added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

OK. Then we can add a Task about how to easily configure robot changes without forking, in case.

Feb 5 2024, 08:52 · Discussion Needed
avivey added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

Thinking more, I think we'd like to allow the robots to index latest version of the code - these days the big boys know how to handle that. Stopping them from crawling older versions is still important.

Feb 5 2024, 07:47 · Discussion Needed

Feb 1 2024

20after4 added a comment to T15705: Lower the search ranking of disabled user accounts.

So apparently the ferret search engine doesn't really have any sort of dynamic ranking. The ranking is entirely based on how many ngrams match the query...with one singular exception - all user results are boosted above everything else.

Feb 1 2024, 19:19 · Discussion Needed, UX
20after4 claimed T15705: Lower the search ranking of disabled user accounts.

I'll try to figure out a architecturally-appropriate way to do this. The users do get grayed out in the typeahead search, just not on the results pages.

Feb 1 2024, 18:52 · Discussion Needed, UX
valerio.bozzolan added a comment to T15705: Lower the search ranking of disabled user accounts.

Partially related, from the mentioned search it's easy to recognize closed Tasks, but Users are not greyed out when Disabled.

Feb 1 2024, 10:42 · Discussion Needed, UX

Jan 28 2024

bekay updated the task description for T15728: Repo home view and browse view share the same menu tab.
Jan 28 2024, 12:17 · Discussion Needed, Diffusion
bekay created T15728: Repo home view and browse view share the same menu tab.
Jan 28 2024, 12:12 · Discussion Needed, Diffusion
bekay closed T15716: Remarkup header have a fixed line height and are less readable with increased size as Resolved by committing rPf8db94f2bfbe: Add flexible line height to remarkup headers.
Jan 28 2024, 11:45 · Discussion Needed, Remarkup