Page MenuHomePhorge
Feed Advanced Search

Wed, May 8

avivey added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Another problem dramatically frequent for newcomers (at least in my office).

It's relatively too much easy to start with a similar commit message:
...

Wed, May 8, 08:25 · Discussion Needed, Arcanist

Tue, May 7

valerio.bozzolan added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

At least, please go to GitLab, instead of GitHub, so at least you use Free Software :)

Tue, May 7, 09:08 · Discussion Needed, Arcanist
micax added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

Just some (probably final) thoughts on arcanist and phabricator/phorge. After quite a bit of discussion internally, we are moving on to GitHub with our repositories (which were previously stored in another Git server - not Phabricator). But that move also spells the end for our/my 10+ year long use of Phabricator, because when we move to GitHub, we'll also be ditching Phabricator for code reviews.

Tue, May 7, 07:58 · Discussion Needed, Arcanist

Apr 25 2024

Iniquity added a comment to T15082: Consider allowing milestone columns to be ordered arbitrarily on workboards.

It seems to me that this problem can be solved with an additional setting that turns this functionality on or off.

Apr 25 2024, 19:10 · Discussion Needed, Affects-Wikimedia, Workboard

Apr 24 2024

avivey moved T15231: Maybe make automatic workboard display sub-projects as columns? from Backlog to Discussion Needed on the Workboard board.
Apr 24 2024, 06:25 · Discussion Needed, Workboard

Apr 11 2024

revi added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

Probably my somewhat 10 cents at a broader level;

Apr 11 2024, 17:58 · Discussion Needed

Apr 4 2024

avivey added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

We don't create the links to page$line in most places as hrefs, so this shouldn't be an issue.

  • Don't exist in Diffusion
  • Do exist in Paste
  • Don't exist in Differential
Apr 4 2024, 21:34 · Discussion Needed
aklapper added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

If it's that easy

Apr 4 2024, 21:02 · Discussion Needed
avivey added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

I'm guessing $ is used instead of # because (1) a user-agent might not send the # part to the server, and (2) the natural behavior of # ("scroll to this anchor") isn't what the intended behavior ("highlight these lines and scroll to the first one").

Apr 4 2024, 07:10 · Discussion Needed

Apr 3 2024

valerio.bozzolan added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

Ah, also adding a smalll meta "noindex" HTML tag on legacy file.php$123 pages and similar ones, would maybe help a little bit.

Apr 3 2024, 17:17 · Discussion Needed
20after4 added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

Thinking more, I think we'd like to allow the robots to index latest version of the code - these days the big boys know how to handle that. Stopping them from crawling older versions is still important.

Anyway, I vote to revert the change - commit pages can have discussions in.

Apr 3 2024, 17:03 · Discussion Needed
20after4 added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

If it's that easy, then I'm both impressed and surprised it remained this way for so long. I'm actually not quite sure I understand the reasoning for not using # to begin with.

Apr 3 2024, 16:58 · Discussion Needed

Apr 2 2024

aklapper added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

A root problem is that highlighted line number(s) should be a # fragment really, to do not multiply pages exponentially.

Apr 2 2024, 19:34 · Discussion Needed
bekay closed T15728: Repo home view and browse view share the same menu tab as Resolved by committing rPba835fe0eced: Seperate repository home and browse view in tab menu.
Apr 2 2024, 13:56 · Discussion Needed, Diffusion

Mar 25 2024

valerio.bozzolan added a comment to T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.

Another good simple candidate GDPR-friendly:

Mar 25 2024, 10:36 · Discussion Needed, Affects-Wikimedia

Mar 19 2024

valerio.bozzolan updated the task description for T15161: Internal resources should avoid to become external links, as default.
Mar 19 2024, 16:41 · User-valerio.bozzolan, Discussion Needed, Remarkup
valerio.bozzolan closed T15182: Simplify the way "internal links" are identified, a subtask of T15161: Internal resources should avoid to become external links, as default, as Resolved.
Mar 19 2024, 16:34 · User-valerio.bozzolan, Discussion Needed, Remarkup

Mar 14 2024

aklapper added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

A root problem is that highlighted line number(s) should be a # fragment really, to do not multiply pages exponentially.

Mar 14 2024, 09:53 · Discussion Needed

Mar 11 2024

valerio.bozzolan added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

A root problem is that highlighted line number(s) should be a # fragment really, to do not multiply pages exponentially.

Mar 11 2024, 08:59 · Discussion Needed

Feb 21 2024

bekay added a comment to T15728: Repo home view and browse view share the same menu tab.

I tried to understand the situation. Thanks.

In your opinion: on the repo view (with clone buttons) is it really important to link to the other similar "reduced" view (without clone buttons)?

Feb 21 2024, 10:15 · Discussion Needed, Diffusion
valerio.bozzolan added a comment to T15728: Repo home view and browse view share the same menu tab.

I tried to understand the situation. Thanks.

Feb 21 2024, 08:03 · Discussion Needed, Diffusion

Feb 14 2024

bekay added a revision to T15728: Repo home view and browse view share the same menu tab: D25538: Separate repository home and browse view in tab menu.
Feb 14 2024, 17:27 · Discussion Needed, Diffusion

Feb 13 2024

20after4 added a comment to T15705: Lower the search ranking of disabled user accounts.

I agree, disabled users should be hidden in the global search typeahead results.

Feb 13 2024, 23:22 · Discussion Needed, UX
20after4 added a comment to T15736: JavaScript modernization (umbrella task).
In T15736#15681, @bekay wrote:
  • Get rid of the JX namespace and the the require comments - use import and export like it is done in modern js
Feb 13 2024, 23:21 · UX, Discussion Needed
avivey added a comment to T15739: Replace celerity postprocessors with real css variables.

I'm not against replacing the mechanism - It's just that the original task description doesn't specify why that would be good (i.e., what the benefit would be).
That's clear from the discussion now, but should generally be included in the ticket description - the "describe "what", not "how"" principle.

Feb 13 2024, 07:57 · Discussion Needed
sirocyl added a comment to T15739: Replace celerity postprocessors with real css variables.

A big benefit of using client-side variables in CSS, is that one can use the browser's prefers-color-scheme media query to select light or dark mode based on the user's browser or system setting, automatically, and that the transition from light to dark mode, or to other accent/highlight color schemes, requires no reload.

Feb 13 2024, 04:02 · Discussion Needed

Feb 12 2024

bekay added a comment to T15739: Replace celerity postprocessors with real css variables.

Well, I see a tremendous critism and scepticism concerning modern client side techniques here. The world of frontend tooling has changed tremendously in the last 5 years. And I understand concerns, but nobody has to write JavaScript for certain browsers anymore. Javelin for example tries to solve so many problems that Babel solves with one config entry. But that's okay and I like the architecture here and know we can't change everything at once.

Feb 12 2024, 21:05 · Discussion Needed
avivey added a comment to T15739: Replace celerity postprocessors with real css variables.

Ok, I don't understand the specifics of css-vars, but if they're better, they're better.

Feb 12 2024, 20:18 · Discussion Needed
bekay added a comment to T15739: Replace celerity postprocessors with real css variables.

The overwriting of variables with media queries could be configured inside the theming class. So possible breakpoints can be part of a theming API.

Feb 12 2024, 20:16 · Discussion Needed
bekay added a comment to T15739: Replace celerity postprocessors with real css variables.

And my general approach is: when the client can do something (and that even better), why should the server do it?

Feb 12 2024, 20:04 · Discussion Needed
bekay added a comment to T15739: Replace celerity postprocessors with real css variables.

@avivey CSS vars are a vital part of modern modularized theming. They are versatile, can be overwritten with media queries or per class/element basis. They are editable in browser dev tools. If you would ask me: this step is pretty important.

Feb 12 2024, 20:01 · Discussion Needed
bekay added a comment to T15736: JavaScript modernization (umbrella task).

to have a working dev server when developing js - at the moment I have to ./bin/celerity map after every change to js and css to see my changes...

Are you sure about that? I thought celerity map was only needed when adding a file (in dev mode).

Feb 12 2024, 19:47 · UX, Discussion Needed
avivey added a comment to T15736: JavaScript modernization (umbrella task).

also, adding this file in src/extensions/ will let you have css/js files from src/extensions/rsrc/ loaded automatically:

Feb 12 2024, 19:46 · UX, Discussion Needed
avivey added a comment to T15736: JavaScript modernization (umbrella task).

to have a working dev server when developing js - at the moment I have to ./bin/celerity map after every change to js and css to see my changes...

Feb 12 2024, 19:44 · UX, Discussion Needed
avivey added a comment to T15739: Replace celerity postprocessors with real css variables.

Looks to me that the existing system is better at providing Themes? It allows real code, inheritance, etc. to set variable values.
That is, I think Extension Themes are better off writing PHP Post-Processor rather then CSS vars.

Feb 12 2024, 19:36 · Discussion Needed
bekay updated the task description for T15739: Replace celerity postprocessors with real css variables.
Feb 12 2024, 17:27 · Discussion Needed
bekay added a comment to T15705: Lower the search ranking of disabled user accounts.

I don't know if that is part of this task, but the global typeahead search should hide all disabled users, wikis and repos, shouldn't it? This is nothing you want as a fast suggestion...

Feb 12 2024, 16:46 · Discussion Needed, UX
bekay updated the task description for T15739: Replace celerity postprocessors with real css variables.
Feb 12 2024, 16:40 · Discussion Needed
bekay updated the task description for T15739: Replace celerity postprocessors with real css variables.
Feb 12 2024, 16:32 · Discussion Needed
bekay updated the task description for T15739: Replace celerity postprocessors with real css variables.
Feb 12 2024, 16:31 · Discussion Needed
bekay created T15739: Replace celerity postprocessors with real css variables.
Feb 12 2024, 16:24 · Discussion Needed
bekay added a comment to T15736: JavaScript modernization (umbrella task).

Well, my idea would be:

Feb 12 2024, 12:56 · UX, Discussion Needed

Feb 11 2024

20after4 triaged T15736: JavaScript modernization (umbrella task) as Wishlist priority.
Feb 11 2024, 22:32 · UX, Discussion Needed
20after4 added a subtask for T15736: JavaScript modernization (umbrella task): T15168: Improve JavaScript i18n.
Feb 11 2024, 22:32 · UX, Discussion Needed
20after4 created T15736: JavaScript modernization (umbrella task).
Feb 11 2024, 22:31 · UX, Discussion Needed

Feb 6 2024

20after4 added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

When I was at Wikimedia I remember a lot of issues from search robots endlessly indexing dynamic pages.

Feb 6 2024, 02:26 · Discussion Needed

Feb 5 2024

avivey added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

In case of what?

Feb 5 2024, 08:54 · Discussion Needed
valerio.bozzolan added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

OK. Then we can add a Task about how to easily configure robot changes without forking, in case.

Feb 5 2024, 08:52 · Discussion Needed
avivey added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

Thinking more, I think we'd like to allow the robots to index latest version of the code - these days the big boys know how to handle that. Stopping them from crawling older versions is still important.

Feb 5 2024, 07:47 · Discussion Needed

Feb 1 2024

20after4 added a comment to T15705: Lower the search ranking of disabled user accounts.

So apparently the ferret search engine doesn't really have any sort of dynamic ranking. The ranking is entirely based on how many ngrams match the query...with one singular exception - all user results are boosted above everything else.

Feb 1 2024, 19:19 · Discussion Needed, UX
20after4 claimed T15705: Lower the search ranking of disabled user accounts.

I'll try to figure out a architecturally-appropriate way to do this. The users do get grayed out in the typeahead search, just not on the results pages.

Feb 1 2024, 18:52 · Discussion Needed, UX
valerio.bozzolan added a comment to T15705: Lower the search ranking of disabled user accounts.

Partially related, from the mentioned search it's easy to recognize closed Tasks, but Users are not greyed out when Disabled.

Feb 1 2024, 10:42 · Discussion Needed, UX

Jan 28 2024

bekay updated the task description for T15728: Repo home view and browse view share the same menu tab.
Jan 28 2024, 12:17 · Discussion Needed, Diffusion
bekay created T15728: Repo home view and browse view share the same menu tab.
Jan 28 2024, 12:12 · Discussion Needed, Diffusion
bekay closed T15716: Remarkup header have a fixed line height and are less readable with increased size as Resolved by committing rPf8db94f2bfbe: Add flexible line height to remarkup headers.
Jan 28 2024, 11:45 · Discussion Needed, Remarkup

Jan 22 2024

bekay added a revision to T15716: Remarkup header have a fixed line height and are less readable with increased size: D25523: Add flexible line height to remarkup headers.
Jan 22 2024, 16:57 · Discussion Needed, Remarkup
bekay closed T15715: Typehead results of main search should not truncate important information as Resolved.
Jan 22 2024, 16:36 · Discussion Needed, UX

Jan 20 2024

aklapper added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

User content is also content, thus yes.

Jan 20 2024, 08:05 · Discussion Needed, Governance

Jan 19 2024

valerio.bozzolan added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

Good question. Maybe also related to L2.

Jan 19 2024, 21:02 · Discussion Needed, Governance
speck closed T15322: Footer: specify a default Libre license for Phorge contents as Resolved.
Jan 19 2024, 20:45 · Discussion Needed, Governance
speck claimed T15322: Footer: specify a default Libre license for Phorge contents.
Jan 19 2024, 20:45 · Discussion Needed, Governance
speck added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

Is it assumed that using the site will automatically license the user’s content under these, or should there be a line for that?

Jan 19 2024, 18:54 · Discussion Needed, Governance
20after4 added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

+1 on Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses.

Jan 19 2024, 17:59 · Discussion Needed, Governance
avivey added a comment to T15716: Remarkup header have a fixed line height and are less readable with increased size.

Values given in em units may produce unexpected results...

Jan 19 2024, 10:32 · Discussion Needed, Remarkup

Jan 18 2024

bekay created T15716: Remarkup header have a fixed line height and are less readable with increased size.
Jan 18 2024, 18:33 · Discussion Needed, Remarkup
valerio.bozzolan added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

Yes. I think we should wait for a kind Administrator to implement the first one.

Jan 18 2024, 17:31 · Discussion Needed, Governance
bekay added a revision to T15715: Typehead results of main search should not truncate important information: D25520: Show title entirely and cut of secondary information gracefully in typeahead results of main search.
Jan 18 2024, 14:24 · Discussion Needed, UX
bekay added a comment to T15715: Typehead results of main search should not truncate important information.

@aklapper @valerio.bozzolan See D25520.

Jan 18 2024, 13:26 · Discussion Needed, UX
bekay triaged T15715: Typehead results of main search should not truncate important information as Normal priority.
Jan 18 2024, 13:08 · Discussion Needed, UX
bekay claimed T15715: Typehead results of main search should not truncate important information.
Jan 18 2024, 13:08 · Discussion Needed, UX
valerio.bozzolan added a comment to T15715: Typehead results of main search should not truncate important information.

BTW I like the proposed screenshot. So I also agree to: feel free to share the solution 👍

Jan 18 2024, 08:50 · Discussion Needed, UX
aklapper added a comment to T15715: Typehead results of main search should not truncate important information.

My fix would work with this css class

I did not realize you had a fix. Please share it. :)

Jan 18 2024, 08:22 · Discussion Needed, UX
bekay added a comment to T15715: Typehead results of main search should not truncate important information.

I guess you could get the result that you're looking for by editing the file webroot/rsrc/css/aphront/typeahead.css and removing the line white-space: nowrap; from the definition of div.jx-typeahead-results a.jx-result. I just don't know which side effects this may have in other places...

Jan 18 2024, 08:08 · Discussion Needed, UX

Jan 17 2024

aklapper added a comment to T15715: Typehead results of main search should not truncate important information.

I guess you could get the result that you're looking for by editing the file webroot/rsrc/css/aphront/typeahead.css and removing the line white-space: nowrap; from the definition of div.jx-typeahead-results a.jx-result. I just don't know which side effects this may have in other places...

Jan 17 2024, 19:07 · Discussion Needed, UX
bekay created T15715: Typehead results of main search should not truncate important information.
Jan 17 2024, 16:42 · Discussion Needed, UX

Jan 13 2024

avivey added a comment to T15705: Lower the search ranking of disabled user accounts.

Also for Archived Projects, and maybe some other objects.
I'm not sure if there's a generic way to do this, or if each search-engine needs to be updated manually.

Jan 13 2024, 10:12 · Discussion Needed, UX
aklapper added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

+1 on Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses.

Jan 13 2024, 03:06 · Discussion Needed, Governance

Jan 10 2024

valerio.bozzolan added a comment to T15705: Lower the search ranking of disabled user accounts.

Completely agree on lowering their ranking as default

Jan 10 2024, 10:06 · Discussion Needed, UX

Jan 9 2024

20after4 created T15705: Lower the search ranking of disabled user accounts.
Jan 9 2024, 22:42 · Discussion Needed, UX

Dec 18 2023

aklapper closed T15688: "Undefined index: PHID-PROJ-***" in project.search API when project_customfieldstorage table has additional fields not requested, a subtask of T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge, as Resolved.
Dec 18 2023, 11:46 · Discussion Needed, Affects-Wikimedia

Dec 14 2023

valerio.bozzolan added a comment to T15161: Internal resources should avoid to become external links, as default.

Since I can, thanks to that revision, at work I've put this additional CSS rule for extra nonsense scary climax.

Dec 14 2023, 18:05 · User-valerio.bozzolan, Discussion Needed, Remarkup
20after4 added a subtask for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge: T15694: Consider adopting the "search results context highlighting" feature from Wikimedia's fork.
Dec 14 2023, 17:33 · Discussion Needed, Affects-Wikimedia
20after4 updated the task description for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Dec 14 2023, 17:32 · Discussion Needed, Affects-Wikimedia
20after4 added a comment to T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.

Here's another one that I think deserves to be upstreamed: https://phabricator.wikimedia.org/T230787 adds context and search term highlights to fulltext search results. Currently Phorge and upstream Phabricator only show matching document titles with highlights on keywords in the title but not the body.
The efficiency of my solution is questionable, however, it's working well enough for Wikimedia's use of the feature.

Dec 14 2023, 17:04 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan updated the task description for T15161: Internal resources should avoid to become external links, as default.
Dec 14 2023, 16:42 · User-valerio.bozzolan, Discussion Needed, Remarkup

Dec 8 2023

soloturn added a comment to T15100: [Feature request] Option to measure WIP limits based on card count instead of points, to more closely adhere to Kanban standards..

there is a presentation from eric brechner, who was in microsofts xbox development, about kanban. he does it on whiteboard, extremely sinple:
https://www.youtube.com/watch?v=CD0y-aU1sXo

Dec 8 2023, 08:17 · Feature Requests, Maniphest, Discussion Needed, Affects-Wikimedia, Workboard

Dec 7 2023

valerio.bozzolan updated the task description for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Dec 7 2023, 10:33 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan added a subtask for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge: T15688: "Undefined index: PHID-PROJ-***" in project.search API when project_customfieldstorage table has additional fields not requested.
Dec 7 2023, 10:32 · Discussion Needed, Affects-Wikimedia

Dec 6 2023

aklapper closed T15686: Include 'published' date in Phame atom feeds, a subtask of T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge, as Resolved.
Dec 6 2023, 19:34 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan updated the task description for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Dec 6 2023, 06:21 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan added a subtask for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge: T15686: Include 'published' date in Phame atom feeds.
Dec 6 2023, 06:21 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan moved T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge from Backlog to Discussion Needed on the Affects-Wikimedia board.
Dec 6 2023, 06:20 · Discussion Needed, Affects-Wikimedia

Nov 20 2023

valerio.bozzolan added a project to Q86: Policy lifecycle of security tasks: Discussion Needed.
Nov 20 2023, 22:15 · Discussion Needed

Nov 19 2023

avivey reopened T15670: Disallow webcrawlers to index Diffusion repository commits as "Open".
Nov 19 2023, 09:14 · Discussion Needed
avivey added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

From a product POV, I agree with @valerio.bozzolan - there is (sometimes) some information on commits that would be nice to index in a search engine - comments, mostly.

Nov 19 2023, 09:01 · Discussion Needed

Nov 18 2023

aklapper added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

Valerio: Uhm, I'm sorry, I had not seen your comment here before I landed the patch (as I had checked my Differential page instead of my notifications).

Nov 18 2023, 08:29 · Discussion Needed

Nov 17 2023

aklapper closed T15670: Disallow webcrawlers to index Diffusion repository commits as Resolved by committing rP05f4d5071fdc: Disallow webcrawlers to index Diffusion commits.
Nov 17 2023, 07:45 · Discussion Needed

Nov 16 2023

valerio.bozzolan added a project to T15670: Disallow webcrawlers to index Diffusion repository commits: Discussion Needed.

This is something that may be not appreciated by some people.

Nov 16 2023, 10:23 · Discussion Needed

Nov 15 2023

Sten added a comment to T15501: Voluntary Usage Survey App.

One of my favourite updates in my workplace was to store counts of feature usage per month in a table. Move forward 3 years, and whenever we need to update some code in a feature, we check for it in the table, and if it's not been used in 3 years we just scrap the feature.

Nov 15 2023, 18:14 · Discussion Needed

Oct 11 2023

valerio.bozzolan triaged T15082: Consider allowing milestone columns to be ordered arbitrarily on workboards as Wishlist priority.

I triage this to Wishlist since it's indeed useful to some people but it's somehow still controversial. In order to attract more eyes, adding also Discussion Needed.

Oct 11 2023, 06:22 · Discussion Needed, Affects-Wikimedia, Workboard