At the moment, in a normal Phorge installation, commit authors cannot mark their own commits as problematic, during post-commit review.
In fact, authors does not see the Raise Concern action at all:
The feature "Raise Concern" was "modernized" in 2017:
rP82c891f58663: Add modern "Accept", "Raise Concern" and "Resign" transactions to Audit
Note that in the upstream task created in 2016, allowing authors to "Raise Concern" was considered an already-established feature:
When an author has addressed concerns, there is no way for them to punt the audit back into the auditors' queues
https://secure.phabricator.com/T10978
Proposed Change
The authors should always be able to flag their own commits as problematic.
So, we should remove the current (probably nonsense) block:
The current block was probably copied by mistake from here:
Extra Considerations
Phorge/Phabricator has a setting called audit.can-author-close-audit that allows authors to self-audit their commits. This option is disabled by default.
But, even with this option enabled, authors still cannot "Raise Concern" on their commits (!). So this makes me even more sure that this is just a mistake in good faith.
Quality Assurance
- check that authors always can "Raise Concern"
- check that, even after that, authors still cannot self-approve (just like before)
- check that authors can then "Request Verification" to have their commit finally re-approved (just like before, after they receive "Raise Concern")
This may create some creative space to further improve these workflows. But at the moment the important part is to allow authors to Raise Concern to quickly mark their work as broken to other coworkers.
Questions
Does it sound OK?