Reset to original diff.

Update

@mturdus I have landed this but have reintroduced this code which you have removed - I hope you can remove it again. Sorry for that!

In D25619#22881, @aklapper wrote:

@bekay: Would you like to merge this?

In T16028#21601, @pppery wrote:

{#js-draw-lib} does work.

@pppery I don't know if you wanna step in, since the change was introduced by you.

@mturdus Can you spare some time to review this diff?

In D25619#17560, @valerio.bozzolan wrote:

Maybe "feature" but note the left sidebar, is not anymore connected to the end of the viewport:

Before	After

./bin/celerity map

• Fixes non stretching nav bar if content is absolute or does not fill entire page height

In D25619#17360, @speck wrote:

Ah, yes thank you for the video. I should have clarified but was asking for screenies of the result after this change. The changes look reasonable but I’m not a regular css user

@speck here you can see the described overflowing:

Test for feed: https://we.phorge.it/source/phorge/browse/master/src/view/layout/AphrontSideNavFilterView.php

All described here with screenshot (and now video): T15809

Root problem is the https://we.phorge.it/source/phorge/browse/master/src/view/layout/AphrontSideNavFilterView.php with its styles: https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/css/phui/phui-basic-nav-view.css

I have a nice working version here, which renders the diagram with the drawio viewer javascript component:

• Fixes regression from missing html element

You are right of course!

Yeah, there are some malformed URLs we should tackle for sure.

I have edited the answer. Because with draw.io you can integrate Mermaid out of the box. With R5 you can start using the syntax like instantly.

@valerio.bozzolan Could you try again to install it? There is a readme with new instructions.

In D25577#16640, @mturdus wrote:

Now it's working!

@mturdus right, I don't have the whole picture of this little bit wild codebase 😁 Thanks for the pointer. As far as I can see, this image and the DOMContentLoaded event handler serves no purpose anymore. All is working without it. I have renamed the main js and some functions in it for clarity. Would love if you could give it a try.

• Renames behavior and some functions and gets rid of unnecessary image proxy

Fixed by R5:91dd43de7dee: T15781: arc liberate throws exception

@mturdus I have added some console logs in the js code (so patch and purge the caches on <phorge-base>config/cache/!)

• Caches draw.io assets, uses base64 method of diagram and adds some console logs for js debugging

Firefox does work for me. Does Chrome work for you?

@mturdus You don't have to download the diff, you can do an arc patch D25577 (and you should, because I have changed something again). Mh, but I don't know why it should not work.... 🤔

• Dumps base64 image data directly while remarkup rendering and adds js/css files for remarkup object rule

@mturdus Is the phorge_extension.js file loaded?

@mturdus Just test this if you like. I think this is a first step in the right direction: D25577

Well I have worked the entire day on this (and I see your mentioned issues)... main problem is: extension is not working with security.alternate-file-domain. That I have fixed at least for the creation/editing of diagrams. I have changed pretty much and would love to send a diff.

(Working on fixing it...)

I never use them, because there is no real method search. I think, we should be considering generating a documentation with a real php documention tool. But whatever we do: I think we can remove them in their current form.

In D25538#16175, @avivey wrote:

I'd even suggest we can go one step further, and in the Home tab show the Readme above the files (and maybe change the order/highlight some other UI elements too).

• Moves readme to the top in home view

Well, my idea was to use the already implemented logic of the diagram extension and just extend it with another diagram renderer. But @mturdus is not responding 😁

Well, you know what would be next level for a dev? If (s)he clicks on it, the color is copied to the clipboard. We can't use this behavior, because behaviors loose their state in the remarkup cache...

Updated Pygments with pip to 2.17.2 und cut the time in half. So yeah, that's already an improvement.