Request review for the second part of the change!

$edit_mode has a true value for 'create' or 'edit', and false (null) for read. The strlen() is superfluous.

In D25363#10531, @speck wrote:

Could this be abused, e.g. create an event with a thousand emails then import it and see if those emails are registered? If so how does that compare to existing means of discovering registered users?

Could this be abused, e.g. create an event with a thousand emails then import it and see if those emails are registered? If so how does that compare to existing means of discovering registered users?

Rebased with master and tested :) Nice thanks! Sorry for waiting

fix huge mistake from me

update celerity map

I thought we had "2 spaces" and the rest encoded as lints... I'll try to take a look.

hi I'm a space linter

Sorry, didn't see your earlier ping. Approved.

But reviewing this is the price @Matthew :D (you know ihih)

In D25362#10494, @valerio.bozzolan wrote:

Can I amend this change fixing spaces? I have some time to waste right now and I love this kind of "del del del" ihih

Can I amend this change fixing spaces? I have some time to waste right now and I love this kind of "del del del" ihih

Unfortunately, PHPStorm defaults to four spaces. I'm not really willing to spend a ton of time arguing with it (especially since my day job requires four spaces) ... though it would be helpful if we could come up with some clear code rules and them implement them in the repository using phpcs.

I'm not really opinionated in indentation but it seems the majority of the lines are indented with 4 spaces instead of two

So I'm following proposal n. 2 in D25363.

remove newline

Adjust spacing

Uh nice!

Fix lint errors

Here are some screenshots of this change in action:

I'm not able to reproduce anymore.

I think the problem here is that the command ./bin/cache purge --all does not reset the PhabricatorPeopleQuery cache.

Explicitly check for null instead of using phutil_nonempty_string()

I think you are misunderstanding the technical considerations.

I also like to discuss. Please read this:

If it is likely in principle that you would accept a patch, then it may be most sensible to leave the discussion open. Perhaps it would be found by someone wishing to contribute.

Again, you have not convinced me to work on that, for you, for free :)

Oh wow, that was quick, thanks @avivey . I will probably be able to apply the patch to our Phorge instance sometime next week, I'll let you know how it went!

I am not intent on maintaining my own fork for private use, but the processing pathways for the segmented versus consolidated cases are only minimally different, and may easily be switched dynamically, within some hypothetical future version of the application, depending on the deployment.

I understand your interest in this simplification. I think your opinion is helpful, useful, and I hope you will somehow solve your problem.

Your objection concerning the reference to Nextcloud is based on quote mining. It is neither germane nor accurate.

Note that Q67 tries to make similarities between LAMP apps like nextCloud and Phorge, but nextCloud has not 400+ database tables. This is just a minimal indication of the complexity, that may indicate that this design principle may be not totally suitable for this.

(comment migrated as answer)

In T15568#12244, @valerio.bozzolan wrote:

every extension should have its own

Ah, yeah, even better I think, if possible

You absolutely have the choice to decline requests, but I think it is not quite fair to consider the current one as though connected strongly to Softaculous.

every extension should have its own

I think we should avoid to extend PhutilURI for some interesting reasons:

In T15568#12239, @avivey wrote:

I was thinking of adding a script to ./bin to manage (mostly add/remove from load-libraries, maybe also clone) extensions.

Probably related, I think that any installed extension should not cause any touch to /src/__phutil_library_init__.php, as long as it's versioned in git in Phorge and so will cause of course merge conflicts after any update.

I was thinking of adding a script to ./bin to manage (mostly add/remove from load-libraries, maybe also clone) extensions.

@brainchild We receive feature requests here, and we have the choice to decline them here. The admin team has discussed it, we have decided that the current database setup works best for Phorge as is discussed in the documents avivey has linked. As such, changes will not be made to Phorge's database architecture at this time. If you are looking for something to provision with Softaculous, please consider a different solution.