So, no PHP changes? Interesting.

This is related to https://secure.phabricator.com/T13546. "classic" Arcanist workflows were being upgraded to Toolsets, but the migration was not complete. See comments starting with TOOLSETS: , e.g. in ArcanistConfigurationSource.php.

• Wrap long line

• Rephrase Next Steps entry

Opening this up from draft if communication/reviews are happening

Phrasing

Okay I misunderstood the default value. I don’t think a security tag is necessary either.

In D25464#13372, @speck wrote:

This will require documentation of some sort, specifically for the upgrade notes to indicate that if someone relies on rendering PDFs currently then after upgrading they would need to update that configuration.

I think making a task to document the issue and linking in the release notes would be a good approach and what upstream would typically have done.

This will require documentation of some sort, specifically for the upgrade notes to indicate that if someone relies on rendering PDFs currently then after upgrading they would need to update that configuration.

Any problems with this fix?

Is switching to using phutil_nonempty_scalar a blocker?
I don't think it should be because otherwise, we could have just done a bulk change across the whole codebase converting

• Javascript updated to make collapsible containers more generic, and not specific to indices
• Removed unused 'active' as per review
• Moved setting the display of the container from Javascript to CSS as per review
• Added i18n support for the button text (no need for a TODO!)
• Extended variable/attribute names to make the code a bit more self-documenting

In D25464#13328, @speck wrote:

The Referenced Files section of this diff looks like someone is looking for a vulnerability. Any idea what’s happening here?

arc diff throws an error and arc land ignores it. Instead of getting it to work with Differential, I'm amending the commit manually with git commit --amend -s after arc land --hold.

Update commit message

I see this change as safe since:

Thaanks! Over-tested intensively with NULL, 'asd', objects, aliens, lizards etc.

The Referenced Files section of this diff looks like someone is looking for a vulnerability. Any idea what’s happening here?

Since this is for the timeline text maybe it should check for array and just say “multiple images” rather than grabbing the first.

Update per last comment

I am not sure about all these changes. In particular, the changes in PhabricatorSetupIssueUIExample.php and PhabricatorSetupIssueView.php probably warrant extra scrutiny.

• Update the resources map

Maybe I have to test this against PHP 8.1

Update config description

Mozilla's fixes were quick but not in good quality for direct submission to Phorge. I have adapted or rewritten two of the changes into D25462 and D25464.

Before landing this change, I would like to know the right way to credit both the original author and my modifications with Arcanist (Q85).

Thanks!

Reword

Awesome thanks for adding details and clarification

Impressing test plan :D Tested intensively. No nuclear implosions. Yuppie yeah! ✨

Note that I cannot see Task T15663