following suggestions from my friend avivey

(I have a déjà vu about this patch, I do not know why)

Thanks for this patch (again)!

run arc lint again

Thanks for this patch,

Accepting (but not as O1) since this seems totally legit to me now. Thanks for your update

Thanks for updating

fix native HTML stuff

I discovered this while testing this patch: D25216: Fix PHP 8.1 "strlen(null)" exceptions setting up Username/Password Authentication Provider

Thanks for this patch, again! :)

Thanks for this patch (again!)

Thanks for your update

There’s possibly other reasons why they left it undocumented but it was a while back and I haven’t gone digging in the upstream for details.

Historically the reason why these aren’t documented is that they originally required installing 3rd party tools on the server. They were documented in tasks upstream but there was a security issue found with using graphviz so at that time out of caution they reimplemented figlet and cowsay in php rather than passing arguments to a 3rd party executable. After the implementation change documentation was never updated.

Hi @amit can you please confirm if D25204 fixes your problem? I tested it locally and it works, but having a double-check from you would be super-nice. Thanks!

I verified the SHA256 manually downloading that from https://curl.se/ca/cacert-2022-07-19.pem

Discovered from D25142

Oh I didn't realize it wasn't documented.

In D25142#6649, @speck wrote:

Then in a comment use remarkup to use figlet

For a basic test additional compressed figlet font files have to be installed. I think it’s under src/support/figlet or src/resources/figlet or similar - pretty sure there’s a readme file in the location indicating it goes there. Then in a comment use remarkup to use figlet and verify it’s using the font you installed. For the zip check presumably you’d need to update php.ini to disable the zip extension.

Hi @TitanNano, thanks again. If you have 5 minutes, feel free to reply to avivey since I'm also interested

Do you have any practical tip about how to test this?

We really need to turn on T15042 so diffs can be landed from the webpage

Hi @speck, can I help to land this nice patch?

Hi @Leon95, can I help?

Does anybody want to share any question? :)

Issue on my end, will try to get the Mysql credentials set up for running tests

Ah! That makes sense!

(Unless there's some PHP 8.2 bug in my arc invocation... )

Pretty sure, here's the full --trace output, you can see it's trying to talk to we.phorge.it (also, I see we.phorge.it in my ~/.arcrc)